Skip to content

Commit 0270add

Browse files
committed
Fix test to use listen_path field for FUSE manager
Signed-off-by: Kohei Tokunaga <[email protected]>
1 parent b4db2b9 commit 0270add

File tree

3 files changed

+18
-11
lines changed

3 files changed

+18
-11
lines changed

script/cri-containerd/test-legacy.sh

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,10 @@ set -euo pipefail
1919
CONTEXT="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )/"
2020
REPO="${CONTEXT}../../"
2121
CONTAINERD_SOCK=unix:///run/containerd/containerd.sock
22-
SNAPSHOTTER_SOCK=unix:///run/containerd-stargz-grpc/containerd-stargz-grpc.sock
22+
IMAGE_ENDPOINT_SOCK=unix:///run/containerd-stargz-grpc/containerd-stargz-grpc.sock
23+
if [ "${FUSE_MANAGER:-}" == "true" ] ; then
24+
IMAGE_ENDPOINT_SOCK=unix:///run/containerd-stargz-grpc/cri.sock
25+
fi
2326

2427
source "${CONTEXT}/const.sh"
2528
source "${REPO}/script/util/utils.sh"
@@ -65,7 +68,7 @@ if [ "${FAIL}" == "" ] ; then
6568
# FIXME: remove the skip flag once kind adds support for the user namespace
6669
# See also https://github.com/kubernetes-sigs/kind/issues/3436
6770
docker exec -i "${TEST_NODE_ID}" /go/bin/critest \
68-
--runtime-endpoint=${CONTAINERD_SOCK} --image-endpoint=${SNAPSHOTTER_SOCK} \
71+
--runtime-endpoint=${CONTAINERD_SOCK} --image-endpoint=${IMAGE_ENDPOINT_SOCK} \
6972
--ginkgo.skip 'runtime should support NamespaceMode_POD'
7073
) ; then
7174
FAIL=true

script/cri-containerd/test-stargz.sh

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,10 @@ REPO="${CONTEXT}../../"
2222
REGISTRY_HOST="cri-registry"
2323
TEST_NODE_NAME="cri-testenv-container"
2424
CONTAINERD_SOCK=unix:///run/containerd/containerd.sock
25-
SNAPSHOTTER_SOCK=unix:///run/containerd-stargz-grpc/containerd-stargz-grpc.sock
25+
IMAGE_ENDPOINT_SOCK=unix:///run/containerd-stargz-grpc/containerd-stargz-grpc.sock
26+
if [ "${FUSE_MANAGER:-}" == "true" ] ; then
27+
IMAGE_ENDPOINT_SOCK=unix:///run/containerd-stargz-grpc/cri.sock
28+
fi
2629
PREPARE_NODE_NAME="cri-prepare-node"
2730

2831
source "${CONTEXT}/const.sh"
@@ -191,7 +194,7 @@ echo "==============================="
191194
# FIXME: remove the skip flag once kind adds support for the user namespace
192195
# See also https://github.com/kubernetes-sigs/kind/issues/3436
193196
docker exec "${TEST_NODE_NAME}" /go/bin/critest \
194-
--runtime-endpoint=${CONTAINERD_SOCK} --image-endpoint=${SNAPSHOTTER_SOCK} \
197+
--runtime-endpoint=${CONTAINERD_SOCK} --image-endpoint=${IMAGE_ENDPOINT_SOCK} \
195198
--ginkgo.skip 'runtime should support NamespaceMode_POD'
196199

197200
echo "Check if stargz snapshotter is working"

script/cri-containerd/test.sh

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,8 @@ fi
116116

117117
FUSE_MANAGER_CONFIG=""
118118
if [ "${FUSE_MANAGER:-}" == "true" ] ; then
119-
FUSE_MANAGER_CONFIG='[fuse_manager]
119+
FUSE_MANAGER_CONFIG='listen_path = "/run/containerd-stargz-grpc/cri.sock"
120+
[fuse_manager]
120121
enable = true'
121122
fi
122123

@@ -166,18 +167,18 @@ COPY ./test.conflist /etc/cni/net.d/test.conflist
166167
167168
${ADDITIONAL_INST}
168169
169-
RUN if [ "${BUILTIN_SNAPSHOTTER:-}" != "true" ] ; then \
170-
sed -i '1imetadata_store = "${USE_METADATA_STORE}"' "${SNAPSHOTTER_CONFIG_FILE}" && \
171-
echo '[fuse]' >> "${SNAPSHOTTER_CONFIG_FILE}" && \
172-
echo "passthrough = ${USE_FUSE_PASSTHROUGH}" >> "${SNAPSHOTTER_CONFIG_FILE}" ; \
173-
fi
174-
175170
RUN <<EEE
176171
cat <<EOT >> "${SNAPSHOTTER_CONFIG_FILE}"
177172
${FUSE_MANAGER_CONFIG}
178173
EOT
179174
EEE
180175
176+
RUN if [ "${BUILTIN_SNAPSHOTTER:-}" != "true" ] ; then \
177+
sed -i '1imetadata_store = "${USE_METADATA_STORE}"' "${SNAPSHOTTER_CONFIG_FILE}" && \
178+
echo '[fuse]' >> "${SNAPSHOTTER_CONFIG_FILE}" && \
179+
echo "passthrough = ${USE_FUSE_PASSTHROUGH}" >> "${SNAPSHOTTER_CONFIG_FILE}" ; \
180+
fi
181+
181182
ENTRYPOINT [ "/usr/local/bin/entrypoint", "/sbin/init" ]
182183
EOF
183184
docker build -t "${NODE_TEST_IMAGE_NAME}" ${DOCKER_BUILD_ARGS:-} "${TMP_CONTEXT}"

0 commit comments

Comments
 (0)