fixup: Fix for the case where a metadata refresh enqueued on an unreachable broker prevents refreshing the controller or the coordinator until that broker becomes reachable again

Fixes the fallthrough case that wasn't executed
if metadata retry failed

Author: emasab

src/rdkafka_request.c

@@ -2627,24 +2627,22 @@ static void rd_kafka_handle_Metadata(rd_kafka_t *rk,
                     rd_kafka_buf_retry(rkb, request))
                         return;
                 /* FALLTHRU */
-        } else {
-                rd_rkb_log(rkb, LOG_WARNING, "METADATA",
-                           "Metadata request failed: %s: %s (%dms): %s",
-                           request->rkbuf_u.Metadata.reason,
-                           rd_kafka_err2str(err),
-                           (int)(request->rkbuf_ts_sent / 1000),
-                           rd_kafka_actions2str(actions));
-                /* Respond back to caller on non-retriable errors */
-                if (rko && rko->rko_replyq.q) {
-                        rko->rko_err            = err;
-                        rko->rko_u.metadata.md  = NULL;
-                        rko->rko_u.metadata.mdi = NULL;
-                        rd_kafka_replyq_enq(&rko->rko_replyq, rko, 0);
-                        rko = NULL;
-                }
         }
 
-
+        rd_rkb_log(rkb, LOG_WARNING, "METADATA",
+                "Metadata request failed: %s: %s (%dms): %s",
+                request->rkbuf_u.Metadata.reason,
+                rd_kafka_err2str(err),
+                (int)(request->rkbuf_ts_sent / 1000),
+                rd_kafka_actions2str(actions));
+        /* Respond back to caller on non-retriable errors */
+        if (rko && rko->rko_replyq.q) {
+                rko->rko_err            = err;
+                rko->rko_u.metadata.md  = NULL;
+                rko->rko_u.metadata.mdi = NULL;
+                rd_kafka_replyq_enq(&rko->rko_replyq, rko, 0);
+                rko = NULL;
+        }
 
         /* FALLTHRU */