Skip to content

Commit e2d5499

Browse files
committed
Address comment
1 parent ec34ec6 commit e2d5499

File tree

1 file changed

+34
-24
lines changed

1 file changed

+34
-24
lines changed

test/Confluent.Kafka.IntegrationTests/Tests/AdminClient_ListConsumerGroups.cs

Lines changed: 34 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -68,34 +68,44 @@ public void AdminClient_ListConsumerGroups(string bootstrapServers)
6868
BootstrapServers = bootstrapServers
6969
}).Build())
7070
{
71-
var consumerConfig = new ConsumerConfig
71+
72+
var consumerConfig = new ConsumerConfig
73+
{
74+
GroupId = groupId,
75+
BootstrapServers = bootstrapServers,
76+
SessionTimeoutMs = 6000,
77+
ClientId = clientId,
78+
};
79+
80+
using (var consumer =
81+
new TestConsumerBuilder<byte[], byte[]>(consumerConfig).Build())
82+
{
83+
try
7284
{
73-
GroupId = groupId,
74-
BootstrapServers = bootstrapServers,
75-
SessionTimeoutMs = 6000,
76-
ClientId = clientId,
77-
};
78-
var consumer = new TestConsumerBuilder<byte[], byte[]>(consumerConfig).Build();
79-
consumer.Subscribe(new string[] { partitionedTopic });
80-
// Wait for rebalance.
81-
consumer.Consume(TimeSpan.FromSeconds(10));
85+
consumer.Subscribe(new string[] { partitionedTopic });
86+
// Wait for rebalance.
87+
consumer.Consume(TimeSpan.FromSeconds(10));
8288

83-
// Our consumer group should be present with same group type option
84-
var groups = adminClient.ListConsumerGroupsAsync(listOptionsWithUsed).Result;
85-
Assert.Empty(groups.Valid.Where(group => group.Type != usedType));
86-
Assert.Single(groups.Valid.Where(group => group.GroupId == groupId));
87-
88-
var group = groups.Valid.Find(group => group.GroupId == groupId);
89-
Assert.Equal(ConsumerGroupState.Stable, group.State);
90-
Assert.False(group.IsSimpleConsumerGroup);
89+
// Our consumer group should be present with same group type option
90+
var groups = adminClient.ListConsumerGroupsAsync(listOptionsWithUsed).Result;
91+
Assert.Empty(groups.Valid.Where(group => group.Type != usedType));
92+
Assert.Single(groups.Valid.Where(group => group.GroupId == groupId));
93+
94+
var group = groups.Valid.Find(group => group.GroupId == groupId);
95+
Assert.Equal(ConsumerGroupState.Stable, group.State);
96+
Assert.False(group.IsSimpleConsumerGroup);
9197

92-
// Our consumer group should not be present with opposite group type option
93-
groups = adminClient.ListConsumerGroupsAsync(listOptionsWithOpposite).Result;
94-
Assert.Empty(groups.Valid.Where(group => group.Type != oppositeType));
95-
Assert.Empty(groups.Valid.Where(group => group.GroupId == groupId));
98+
// Our consumer group should not be present with opposite group type option
99+
groups = adminClient.ListConsumerGroupsAsync(listOptionsWithOpposite).Result;
100+
Assert.Empty(groups.Valid.Where(group => group.Type != oppositeType));
101+
Assert.Empty(groups.Valid.Where(group => group.GroupId == groupId));
102+
}
103+
finally
104+
{
105+
consumer.Close();
106+
}
107+
}
96108

97-
consumer.Close();
98-
consumer.Dispose();
99109
}
100110

101111
Assert.Equal(0, Library.HandleCount);

0 commit comments

Comments
 (0)