Skip to content

Commit 823367e

Browse files
vsalvinovsalvino
authored
Remove discontinued Google Analytics support (Universal Analytics) (#593)
Google shut down Universal Analytics in June 2023, so it will no longer work. We already support the successor, GA4, so this is just a removal of the old stuff.
1 parent 35c69af commit 823367e

File tree

6 files changed

+28
-30
lines changed

6 files changed

+28
-30
lines changed

‎coderedcms/migrations/0040_remove_analyticssettings_ga_tracking_id.py

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
# Generated by Django 4.1.12 on 2023-10-20 16:29
2+
3+
from django.db import migrations
4+
5+
6+
class Migration(migrations.Migration):
7+
dependencies = [
8+
("coderedcms", "0039_alter_classifierterm_slug"),
9+
]
10+
11+
operations = [
12+
migrations.RemoveField(
13+
model_name="analyticssettings",
14+
name="ga_tracking_id",
15+
),
16+
]

‎coderedcms/models/tests/test_wagtailsettings_models.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ def setUp(self):
2323

2424
# Populate settings.
2525
self.settings = AnalyticsSettings.for_site(self.site)
26-
self.settings.ga_tracking_id = "UA-123"
26+
self.settings.ga_g_tracking_id = "G-123"
2727
self.settings.head_scripts = "<script>evil_tracker</script>"
2828
self.settings.body_scripts = "<script>annoying_tracker</script>"
2929
self.settings.save()
@@ -35,12 +35,12 @@ def test_get(self):
3535
response = self.client.get(self.homepage.url, follow=True)
3636
self.assertEqual(response.status_code, 200)
3737

38-
def test_ga_tracking_id(self):
38+
def test_ga_g_tracking_id(self):
3939
"""
40-
Make sure the ga_tracking_id is present.
40+
Make sure the ga_g_tracking_id is present.
4141
"""
4242
response = self.client.get(self.homepage.url, follow=True)
43-
self.assertIn(self.settings.ga_tracking_id, str(response.content), 1)
43+
self.assertIn(self.settings.ga_g_tracking_id, str(response.content), 1)
4444

4545
def test_head_scripts(self):
4646
"""

‎coderedcms/models/wagtailsettings_models.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -265,14 +265,6 @@ class AnalyticsSettings(BaseSiteSetting):
265265
class Meta:
266266
verbose_name = _("Tracking")
267267

268-
ga_tracking_id = models.CharField(
269-
blank=True,
270-
max_length=255,
271-
verbose_name=_("UA Tracking ID"),
272-
help_text=_(
273-
'Your Google "Universal Analytics" tracking ID (begins with "UA-")'
274-
),
275-
)
276268
ga_g_tracking_id = models.CharField(
277269
blank=True,
278270
max_length=255,
@@ -321,7 +313,6 @@ class Meta:
321313
MultiFieldPanel(
322314
[
323315
FieldPanel("ga_g_tracking_id"),
324-
FieldPanel("ga_tracking_id"),
325316
FieldPanel("ga_track_button_clicks"),
326317
],
327318
heading=_("Google Analytics"),

‎coderedcms/templates/coderedcms/pages/base.html

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -7,23 +7,15 @@
77

88
<head>
99
{% block tracking %}
10-
{% if settings.coderedcms.AnalyticsSettings.ga_tracking_id or settings.coderedcms.AnalyticsSettings.ga_g_tracking_id %}
10+
{% if settings.coderedcms.AnalyticsSettings.ga_g_tracking_id %}
1111
<!-- Global site tag (gtag.js) - Google Analytics -->
12-
{% if settings.coderedcms.AnalyticsSettings.ga_tracking_id %}
13-
<script async src="https://www.googletagmanager.com/gtag/js?id={{settings.coderedcms.AnalyticsSettings.ga_tracking_id}}"></script>
14-
{% else %}
1512
<script async src="https://www.googletagmanager.com/gtag/js?id={{settings.coderedcms.AnalyticsSettings.ga_g_tracking_id}}"></script>
16-
{% endif %}
1713
<script>
1814
cr_track_clicks = {{settings.coderedcms.AnalyticsSettings.ga_track_button_clicks|yesno:"true,false"}};
1915
window.dataLayer = window.dataLayer || [];
2016
function gtag(){dataLayer.push(arguments);}
2117
gtag('js', new Date());
22-
// {% if settings.coderedcms.AnalyticsSettings.ga_tracking_id %}
23-
gtag('config', '{{settings.coderedcms.AnalyticsSettings.ga_tracking_id}}');
24-
// {% endif %} {% if settings.coderedcms.AnalyticsSettings.ga_g_tracking_id %}
2518
gtag('config', '{{settings.coderedcms.AnalyticsSettings.ga_g_tracking_id}}');
26-
// {% endif %}
2719
</script>
2820
{% endif %}
2921
{% if settings.coderedcms.AnalyticsSettings.gtm_id %}

‎docs/how_to/add_tracking_scripts.rst

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,16 +19,16 @@ Google Analytics
1919
----------------
2020

2121
There are two types of Google Analytics accounts --- "Google Analytics 4" (GA4)
22-
and "Universal Analytics" (for old accounts created before 2021):
22+
and "Universal Analytics" (which is discontinued as of July 2023):
2323

2424
* **Google Analytics 4 (GA4)** account IDs begin with **G-**
2525

26-
* **Universal Analytics** account IDs begin with **UA-**. Google is shutting
27-
down UA accounts in July 2023, so it is recommended to use GA4 accounts
28-
instead.
26+
* **Universal Analytics** account IDs begin with **UA-**. Google shut
27+
down UA accounts in July 2023, so these will no longer work.
2928

30-
* If you are using both account types, you can enter both IDs and the data will
31-
populate both accounts.
29+
.. deprecated:: 3.0
30+
31+
Support for Universal Analytics was removed in CRX version 3.0.
3232

3333

3434
Google Tag Manager (GTM)

‎tutorial/mysite/website/fixtures/database.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4703,7 +4703,7 @@
47034703
"localhost",
47044704
80
47054705
],
4706-
"ga_tracking_id": "",
4706+
"ga_g_tracking_id": "",
47074707
"ga_track_button_clicks": false
47084708
}
47094709
},
@@ -4995,4 +4995,3 @@
49954995
}
49964996
}
49974997
]
4998-

0 commit comments

Comments
 (0)