fix(serializer): handle missing topics and correct variable naming

ryan-gang · ryan-gang · commit 5285a69315e9 · 2025-07-28T21:03:51.000+05:30
diff --git a/protocol/serializer/generate_log_dir.go b/protocol/serializer/generate_log_dir.go
@@ -10,12 +10,16 @@ import (
 )
 
 func GenerateLogDirs(logger *logger.Logger, topics []string) error {
-	topicData := []common.TopicConfig{}
+	topicsData := []common.TopicConfig{}
 	for _, topicName := range topics {
-		topicData = append(topicData, common.TOPICS[topicName])
+		topicData, ok := common.TOPICS[topicName]
+		if !ok {
+			panic(fmt.Sprintf("CodeCrafters Internal Error: topic %s not found", topicName))
+		}
+		topicsData = append(topicsData, topicData)
 	}
 
-	return generateLogDirs(logger, len(topics) == 0, topicData)
+	return generateLogDirs(logger, len(topics) == 0, topicsData)
 }
 
 // GenerateLogDirs generates the log directories and files for the test cases.

Original file line number	Diff line number	Diff line change
`@@ -10,12 +10,16 @@ import (`
`10`	`10`	`)`
`11`	`11`
`12`	`12`	`func GenerateLogDirs(logger *logger.Logger, topics []string) error {`
`13`		`- topicData := []common.TopicConfig{}`
	`13`	`+ topicsData := []common.TopicConfig{}`
`14`	`14`	`for _, topicName := range topics {`
`15`		`- topicData = append(topicData, common.TOPICS[topicName])`
	`15`	`+ topicData, ok := common.TOPICS[topicName]`
	`16`	`+ if !ok {`
	`17`	`+ panic(fmt.Sprintf("CodeCrafters Internal Error: topic %s not found", topicName))`
	`18`	`+ }`
	`19`	`+ topicsData = append(topicsData, topicData)`
`16`	`20`	`}`
`17`	`21`
`18`		`- return generateLogDirs(logger, len(topics) == 0, topicData)`
	`22`	`+ return generateLogDirs(logger, len(topics) == 0, topicsData)`
`19`	`23`	`}`
`20`	`24`
`21`	`25`	`// GenerateLogDirs generates the log directories and files for the test cases.`