Skip to content

ISSUE-2105 Retry mechanism without delay causing failures #2106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 2, 2022
Merged

ISSUE-2105 Retry mechanism without delay causing failures #2106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
294a0a9
ISSUE-2105 Retry mechanism without delay causing failures
liran2000 Aug 2, 2022
7ac394d
ISSUE-2105 Retry mechanism without delay causing failures
liran2000 Aug 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...t-admin-server/src/main/java/de/codecentric/boot/admin/server/services/IntervalCheck.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ public void start() {
this.subscription = Flux.interval(this.interval)
.doOnSubscribe((s) -> log.debug("Scheduled {}-check every {}", this.name, this.interval))
.log(log.getName(), Level.FINEST).subscribeOn(this.scheduler).concatMap((i) -> this.checkAllInstances())
.retryWhen(Retry.indefinitely()
.retryWhen(Retry.backoff(Long.MAX_VALUE, Duration.ofSeconds(1))
.doBeforeRetry((s) -> log.warn("Unexpected error in {}-check", this.name, s.failure())))
.subscribe();
}
Expand Down
2 changes: 1 addition & 1 deletion ...min-server/src/test/java/de/codecentric/boot/admin/server/services/IntervalCheckTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ public void should_check_after_error() throws InterruptedException {
when(this.checkFn.apply(any())).thenReturn(Mono.error(new RuntimeException("Test"))).thenReturn(Mono.empty());

this.intervalCheck.start();
Thread.sleep(100);
Thread.sleep(1500);
verify(this.checkFn, atLeast(2)).apply(InstanceId.of("Test"));
}

Expand Down