cleanup

Author: ulischulte

spring-boot-admin-server/src/main/java/de/codecentric/boot/admin/server/services/IntervalCheck.java

@@ -70,9 +70,6 @@ public class IntervalCheck {
 	@Nullable
 	private Scheduler scheduler;
 
-	@Setter
-	private Consumer<Throwable> errorConsumer;
-
 	@Setter
 	private Consumer<Throwable> retryConsumer;
 
@@ -95,8 +92,8 @@ public void start() {
 			.doOnSubscribe((s) -> log.debug("Scheduled {}-check every {}", this.name, this.interval))
 			.log(log.getName(), Level.FINEST) //
 			.subscribeOn(this.scheduler) //
-			.flatMap((i) -> this.checkAllInstances()) // Allow concurrent check cycles
-														// if previous is slow
+			// Allow concurrent check cycles if previous is slow
+			.flatMap((i) -> this.checkAllInstances(), Math.max(1, Runtime.getRuntime().availableProcessors() / 2))
 			.retryWhen(createRetrySpec())
 			.subscribe(null, (Throwable error) -> log.error("Unexpected error in {}-check", this.name, error));
 	}

spring-boot-admin-server/src/test/java/de/codecentric/boot/admin/server/services/IntervalCheckTest.java

@@ -195,8 +195,8 @@ void should_not_lose_checks_under_backpressure_latest() {
 		@SuppressWarnings("unchecked")
 		Function<InstanceId, Mono<Void>> slowCheckFn = mock(Function.class);
 
-		IntervalCheck slowCheck = new IntervalCheck("backpressure-test", slowCheckFn, CHECK_INTERVAL,
-				Duration.ofMillis(50), Duration.ofSeconds(1));
+		IntervalCheck slowCheck = new IntervalCheck("backpressure-test", slowCheckFn, CHECK_INTERVAL, CHECK_INTERVAL,
+				Duration.ofSeconds(1));
 
 		// Add multiple instances to increase load and cause drops
 		Set<InstanceId> instanceIds = IntStream.range(0, 50)
@@ -222,7 +222,7 @@ void should_not_lose_checks_under_backpressure_latest() {
 			}
 			else {
 				// Sometimes slow
-				return Mono.delay(CHECK_INTERVAL.plus(Duration.ofMillis(100))).then();
+				return Mono.delay(CHECK_INTERVAL.plus(Duration.ofMillis(500))).then();
 			}
 		}).when(slowCheckFn).apply(any());