Skip to content

Commit 9e862db

Browse files
committed
[Fiber] Don't throw away the Error object retaining the owner stack (facebook#33976)
We currently throw away the Error once we've used to the owner stack of a Fiber once. This maybe helps a bit with memory and redoing it but we really don't expect most Fibers to hit this at all. It's not very hot. If we throw away the Error, then we can't use native debugger protocols to inspect the native stack. Instead, we'd have to maintain a url to resource map indefinitely like what Chrome DevTools does to map a url to a resource. Technically it's not even technically correct since the file path might not be reversible and could in theory conflict. DiffTrain build for [4f34cc4](facebook@4f34cc4)
1 parent 7499d7e commit 9e862db

24 files changed

+335
-340
lines changed

compiled-rn/VERSION_NATIVE_FB

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
19.2.0-native-fb-edac0dde-20250723
1+
19.2.0-native-fb-4f34cc4a-20250724

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-dev.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<87343f2cd6d22ca50c6dbb3330202cbd>>
10+
* @generated SignedSource<<36576a06e92c04401c7b6a51ba51b65e>>
1111
*/
1212

1313
"use strict";
@@ -404,5 +404,5 @@ __DEV__ &&
404404
exports.useFormStatus = function () {
405405
return resolveDispatcher().useHostTransitionStatus();
406406
};
407-
exports.version = "19.2.0-native-fb-edac0dde-20250723";
407+
exports.version = "19.2.0-native-fb-4f34cc4a-20250724";
408408
})();

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-prod.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<9c95b9e32da696550769c8f4262ee088>>
10+
* @generated SignedSource<<19b337269316c827065a6292577a989b>>
1111
*/
1212

1313
"use strict";
@@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
203203
exports.useFormStatus = function () {
204204
return ReactSharedInternals.H.useHostTransitionStatus();
205205
};
206-
exports.version = "19.2.0-native-fb-edac0dde-20250723";
206+
exports.version = "19.2.0-native-fb-4f34cc4a-20250724";

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-profiling.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<9c95b9e32da696550769c8f4262ee088>>
10+
* @generated SignedSource<<19b337269316c827065a6292577a989b>>
1111
*/
1212

1313
"use strict";
@@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
203203
exports.useFormStatus = function () {
204204
return ReactSharedInternals.H.useHostTransitionStatus();
205205
};
206-
exports.version = "19.2.0-native-fb-edac0dde-20250723";
206+
exports.version = "19.2.0-native-fb-4f34cc4a-20250724";

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-dev.js

Lines changed: 123 additions & 124 deletions
Large diffs are not rendered by default.

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-prod.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<f3c31651b2d9e5cd23d1775d30691e66>>
10+
* @generated SignedSource<<987465422a3c8669ee3e87c5ee069431>>
1111
*/
1212

1313
/*
@@ -17123,14 +17123,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1712317123
};
1712417124
var isomorphicReactPackageVersion$jscomp$inline_2004 = React.version;
1712517125
if (
17126-
"19.2.0-native-fb-edac0dde-20250723" !==
17126+
"19.2.0-native-fb-4f34cc4a-20250724" !==
1712717127
isomorphicReactPackageVersion$jscomp$inline_2004
1712817128
)
1712917129
throw Error(
1713017130
formatProdErrorMessage(
1713117131
527,
1713217132
isomorphicReactPackageVersion$jscomp$inline_2004,
17133-
"19.2.0-native-fb-edac0dde-20250723"
17133+
"19.2.0-native-fb-4f34cc4a-20250724"
1713417134
)
1713517135
);
1713617136
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -17152,10 +17152,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1715217152
};
1715317153
var internals$jscomp$inline_2523 = {
1715417154
bundleType: 0,
17155-
version: "19.2.0-native-fb-edac0dde-20250723",
17155+
version: "19.2.0-native-fb-4f34cc4a-20250724",
1715617156
rendererPackageName: "react-dom",
1715717157
currentDispatcherRef: ReactSharedInternals,
17158-
reconcilerVersion: "19.2.0-native-fb-edac0dde-20250723"
17158+
reconcilerVersion: "19.2.0-native-fb-4f34cc4a-20250724"
1715917159
};
1716017160
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1716117161
var hook$jscomp$inline_2524 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -17253,4 +17253,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
1725317253
listenToAllSupportedEvents(container);
1725417254
return new ReactDOMHydrationRoot(initialChildren);
1725517255
};
17256-
exports.version = "19.2.0-native-fb-edac0dde-20250723";
17256+
exports.version = "19.2.0-native-fb-4f34cc4a-20250724";

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-profiling.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<e2f18c005429830c9fa80043d53b9f3c>>
10+
* @generated SignedSource<<201ce386f08a0993745350b476773407>>
1111
*/
1212

1313
/*
@@ -19081,14 +19081,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1908119081
};
1908219082
var isomorphicReactPackageVersion$jscomp$inline_2244 = React.version;
1908319083
if (
19084-
"19.2.0-native-fb-edac0dde-20250723" !==
19084+
"19.2.0-native-fb-4f34cc4a-20250724" !==
1908519085
isomorphicReactPackageVersion$jscomp$inline_2244
1908619086
)
1908719087
throw Error(
1908819088
formatProdErrorMessage(
1908919089
527,
1909019090
isomorphicReactPackageVersion$jscomp$inline_2244,
19091-
"19.2.0-native-fb-edac0dde-20250723"
19091+
"19.2.0-native-fb-4f34cc4a-20250724"
1909219092
)
1909319093
);
1909419094
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -19110,10 +19110,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1911019110
};
1911119111
var internals$jscomp$inline_2251 = {
1911219112
bundleType: 0,
19113-
version: "19.2.0-native-fb-edac0dde-20250723",
19113+
version: "19.2.0-native-fb-4f34cc4a-20250724",
1911419114
rendererPackageName: "react-dom",
1911519115
currentDispatcherRef: ReactSharedInternals,
19116-
reconcilerVersion: "19.2.0-native-fb-edac0dde-20250723",
19116+
reconcilerVersion: "19.2.0-native-fb-4f34cc4a-20250724",
1911719117
getLaneLabelMap: function () {
1911819118
for (
1911919119
var map = new Map(), lane = 1, index$319 = 0;
@@ -19226,4 +19226,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
1922619226
listenToAllSupportedEvents(container);
1922719227
return new ReactDOMHydrationRoot(initialChildren);
1922819228
};
19229-
exports.version = "19.2.0-native-fb-edac0dde-20250723";
19229+
exports.version = "19.2.0-native-fb-4f34cc4a-20250724";

0 commit comments

Comments
 (0)