Commit 9e862db
committed
[Fiber] Don't throw away the Error object retaining the owner stack (facebook#33976)
We currently throw away the Error once we've used to the owner stack of
a Fiber once. This maybe helps a bit with memory and redoing it but we
really don't expect most Fibers to hit this at all. It's not very hot.
If we throw away the Error, then we can't use native debugger protocols
to inspect the native stack. Instead, we'd have to maintain a url to
resource map indefinitely like what Chrome DevTools does to map a url to
a resource. Technically it's not even technically correct since the file
path might not be reversible and could in theory conflict.
DiffTrain build for [4f34cc4](facebook@4f34cc4)1 parent 7499d7e commit 9e862db
File tree
24 files changed
+335
-340
lines changed- compiled-rn
- facebook-fbsource/xplat/js
- RKJSModules/vendor/react
- react-dom/cjs
- react-test-renderer/cjs
- react/cjs
- react-native-github/Libraries/Renderer
- implementations
- tools/eslint-plugin-react-hooks
24 files changed
+335
-340
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| |||
404 | 404 | | |
405 | 405 | | |
406 | 406 | | |
407 | | - | |
| 407 | + | |
408 | 408 | | |
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| |||
203 | 203 | | |
204 | 204 | | |
205 | 205 | | |
206 | | - | |
| 206 | + | |
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| |||
203 | 203 | | |
204 | 204 | | |
205 | 205 | | |
206 | | - | |
| 206 | + | |
Lines changed: 123 additions & 124 deletions
Large diffs are not rendered by default.
Lines changed: 6 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| |||
17123 | 17123 | | |
17124 | 17124 | | |
17125 | 17125 | | |
17126 | | - | |
| 17126 | + | |
17127 | 17127 | | |
17128 | 17128 | | |
17129 | 17129 | | |
17130 | 17130 | | |
17131 | 17131 | | |
17132 | 17132 | | |
17133 | | - | |
| 17133 | + | |
17134 | 17134 | | |
17135 | 17135 | | |
17136 | 17136 | | |
| |||
17152 | 17152 | | |
17153 | 17153 | | |
17154 | 17154 | | |
17155 | | - | |
| 17155 | + | |
17156 | 17156 | | |
17157 | 17157 | | |
17158 | | - | |
| 17158 | + | |
17159 | 17159 | | |
17160 | 17160 | | |
17161 | 17161 | | |
| |||
17253 | 17253 | | |
17254 | 17254 | | |
17255 | 17255 | | |
17256 | | - | |
| 17256 | + | |
Lines changed: 6 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| |||
19081 | 19081 | | |
19082 | 19082 | | |
19083 | 19083 | | |
19084 | | - | |
| 19084 | + | |
19085 | 19085 | | |
19086 | 19086 | | |
19087 | 19087 | | |
19088 | 19088 | | |
19089 | 19089 | | |
19090 | 19090 | | |
19091 | | - | |
| 19091 | + | |
19092 | 19092 | | |
19093 | 19093 | | |
19094 | 19094 | | |
| |||
19110 | 19110 | | |
19111 | 19111 | | |
19112 | 19112 | | |
19113 | | - | |
| 19113 | + | |
19114 | 19114 | | |
19115 | 19115 | | |
19116 | | - | |
| 19116 | + | |
19117 | 19117 | | |
19118 | 19118 | | |
19119 | 19119 | | |
| |||
19226 | 19226 | | |
19227 | 19227 | | |
19228 | 19228 | | |
19229 | | - | |
| 19229 | + | |
0 commit comments