Skip to content

Commit ad1facd

Browse files
authored
Merge pull request #102 from andrew-james-dmw/master
Add missing `supports` implementations in SQL generation code
2 parents 9e999cd + c4ba9fa commit ad1facd

File tree

5 files changed

+27
-1
lines changed

5 files changed

+27
-1
lines changed

src/main/java/liquibase/ext/spanner/sqlgenerator/CreateDatabaseChangeLogLockTableGeneratorSpanner.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
import liquibase.sqlgenerator.SqlGeneratorChain;
77
import liquibase.sqlgenerator.core.CreateDatabaseChangeLogLockTableGenerator;
88
import liquibase.statement.core.CreateDatabaseChangeLogLockTableStatement;
9+
import liquibase.ext.spanner.ICloudSpanner;
910

1011
public class CreateDatabaseChangeLogLockTableGeneratorSpanner
1112
extends CreateDatabaseChangeLogLockTableGenerator {
@@ -31,4 +32,9 @@ public Sql[] generateSql(
3132
public int getPriority() {
3233
return PRIORITY_DATABASE;
3334
}
35+
36+
@Override
37+
public boolean supports(CreateDatabaseChangeLogLockTableStatement statement, Database database) {
38+
return (database instanceof ICloudSpanner);
39+
}
3440
}

src/main/java/liquibase/ext/spanner/sqlgenerator/CreateTableGeneratorSpanner.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import liquibase.sqlgenerator.core.CreateTableGenerator;
2222
import liquibase.statement.core.CreateTableStatement;
2323
import liquibase.structure.DatabaseObject;
24+
import liquibase.ext.spanner.ICloudSpanner;
2425

2526
public class CreateTableGeneratorSpanner extends CreateTableGenerator {
2627

@@ -75,4 +76,9 @@ public Sql[] generateSql(
7576
public int getPriority() {
7677
return PRIORITY_DATABASE;
7778
}
79+
80+
@Override
81+
public boolean supports(CreateTableStatement statement, Database database) {
82+
return (database instanceof ICloudSpanner);
83+
}
7884
}

src/main/java/liquibase/ext/spanner/sqlgenerator/InitializeChangeLogLockTableGeneratorSpanner.java

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
import liquibase.statement.core.DeleteStatement;
2424
import liquibase.statement.core.InitializeDatabaseChangeLogLockTableStatement;
2525
import liquibase.statement.core.InsertStatement;
26+
import liquibase.ext.spanner.ICloudSpanner;
2627

2728
public class InitializeChangeLogLockTableGeneratorSpanner
2829
extends AbstractSqlGenerator<InitializeDatabaseChangeLogLockTableStatement> {
@@ -62,4 +63,10 @@ public Sql[] generateSql(
6263
},
6364
database);
6465
}
65-
}
66+
67+
@Override
68+
public boolean supports(InitializeDatabaseChangeLogLockTableStatement statement, Database database) {
69+
return (database instanceof ICloudSpanner);
70+
}
71+
72+
}

src/main/java/liquibase/ext/spanner/sqlgenerator/InsertOrUpdateGeneratorSpanner.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,4 +97,5 @@ protected String getRecordCheck(InsertOrUpdateStatement insertOrUpdateStatement,
9797
protected String getElse(Database database) {
9898
return "";
9999
}
100+
100101
}

src/main/java/liquibase/ext/spanner/sqlgenerator/InsertWithSelectGeneratorSpanner.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
import liquibase.sqlgenerator.core.InsertGenerator;
2626
import liquibase.statement.DatabaseFunction;
2727
import liquibase.statement.core.InsertStatement;
28+
import liquibase.ext.spanner.ICloudSpanner;
2829

2930
/** Generator for INSERT statements in the form 'INSERT INTO FOO (..) SELECT ...'. */
3031
public class InsertWithSelectGeneratorSpanner extends InsertGenerator {
@@ -35,6 +36,11 @@ public int getPriority() {
3536
return 0;
3637
}
3738

39+
@Override
40+
public boolean supports(InsertStatement statement, Database database) {
41+
return (database instanceof ICloudSpanner);
42+
}
43+
3844
@Override
3945
public Sql[] generateSql(InsertStatement statement, Database database,
4046
SqlGeneratorChain sqlGeneratorChain) {

0 commit comments

Comments
 (0)