Skip to content

Commit e83c7ad

Browse files
committed
fix: dug last remarks
Signed-off-by: Remi Cattiau <[email protected]>
1 parent 8768da8 commit e83c7ad

File tree

1 file changed

+38
-36
lines changed

1 file changed

+38
-36
lines changed

cloudevents/adapters/github.md

Lines changed: 38 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ https://docs.github.com/en/webhooks/webhook-events-and-payloads
1010
Each section below describes how to determine the CloudEvents attributes
1111
based on the specified event.
1212

13+
For time attribute, if the proposed value is null, the default timestamp should be used.
14+
1315
### BranchProtectionConfigurationEvent
1416

1517
| CloudEvents Attribute | Value |
@@ -552,18 +554,18 @@ based on the specified event.
552554

553555
### PackageEvent
554556

555-
| CloudEvents Attribute | Value |
556-
| :-------------------- | :------------------------------------- |
557-
| `id` | "X-GitHub-Delivery" HTTP header value |
558-
| `source` | "repository.url" value |
559-
| `specversion` | `1.0` |
560-
| `type` | `com.github.package.` + "action" value |
561-
| `datacontentencoding` | Omit |
562-
| `datacontenttype` | `application/json` |
563-
| `dataschema` | Omit |
564-
| `subject` | "package.id" value |
565-
| `time` | "package.(updated\|created)\_at" value |
566-
| `data` | Content of HTTP request body |
557+
| CloudEvents Attribute | Value |
558+
| :-------------------- | :------------------------------------------------------------------------- |
559+
| `id` | "X-GitHub-Delivery" HTTP header value |
560+
| `source` | "repository.url" value |
561+
| `specversion` | `1.0` |
562+
| `type` | `com.github.package.` + "action" value |
563+
| `datacontentencoding` | Omit |
564+
| `datacontenttype` | `application/json` |
565+
| `dataschema` | Omit |
566+
| `subject` | "package.id" value |
567+
| `time` | "package.updated_at" value, unless "null", then "package.created_at" value |
568+
| `data` | Content of HTTP request body |
567569

568570
### PageBuildEvent
569571

@@ -882,33 +884,33 @@ based on the specified event.
882884

883885
### SecretScanningAlertEvent
884886

885-
| CloudEvents Attribute | Value |
886-
| :-------------------- | :--------------------------------------------------- |
887-
| `id` | "X-GitHub-Delivery" HTTP header value |
888-
| `source` | "repository.url" value |
889-
| `specversion` | `1.0` |
890-
| `type` | `com.github.secret_scanning_alert.` + "action" value |
891-
| `datacontentencoding` | Omit |
892-
| `datacontenttype` | `application/json` |
893-
| `dataschema` | Omit |
894-
| `subject` | "alert.number" value |
895-
| `time` | "alert.updated_at" value or "alert.created_at" |
896-
| `data` | Content of HTTP request body |
887+
| CloudEvents Attribute | Value |
888+
| :-------------------- | :---------------------------------------------------------------------- |
889+
| `id` | "X-GitHub-Delivery" HTTP header value |
890+
| `source` | "repository.url" value |
891+
| `specversion` | `1.0` |
892+
| `type` | `com.github.secret_scanning_alert.` + "action" value |
893+
| `datacontentencoding` | Omit |
894+
| `datacontenttype` | `application/json` |
895+
| `dataschema` | Omit |
896+
| `subject` | "alert.number" value |
897+
| `time` | "alert.updated_at" value , unless "null", then "alert.created_at" value |
898+
| `data` | Content of HTTP request body |
897899

898900
### SecretScanningAlertLocationEvent
899901

900-
| CloudEvents Attribute | Value |
901-
| :-------------------- | :------------------------------------------------------------ |
902-
| `id` | "X-GitHub-Delivery" HTTP header value |
903-
| `source` | "repository.url" value |
904-
| `specversion` | `1.0` |
905-
| `type` | `com.github.secret_scanning_alert_location.` + "action" value |
906-
| `datacontentencoding` | Omit |
907-
| `datacontenttype` | `application/json` |
908-
| `dataschema` | Omit |
909-
| `subject` | "alert.number" value |
910-
| `time` | "alert.updated_at" value or "alert.created_at" |
911-
| `data` | Content of HTTP request body |
902+
| CloudEvents Attribute | Value |
903+
| :-------------------- | :---------------------------------------------------------------------- |
904+
| `id` | "X-GitHub-Delivery" HTTP header value |
905+
| `source` | "repository.url" value |
906+
| `specversion` | `1.0` |
907+
| `type` | `com.github.secret_scanning_alert_location.` + "action" value |
908+
| `datacontentencoding` | Omit |
909+
| `datacontenttype` | `application/json` |
910+
| `dataschema` | Omit |
911+
| `subject` | "alert.number" value |
912+
| `time` | "alert.updated_at" value , unless "null", then "alert.created_at" value |
913+
| `data` | Content of HTTP request body |
912914

913915
### SecurityAdvisoryEvent
914916

0 commit comments

Comments
 (0)