Skip to content

Commit c527ab4

Browse files
spalladinofrangio
authored andcommitted
ERC20 totalSupply changed from public property to a function (OpenZeppelin#666)
Fixes OpenZeppelin#434
1 parent b1ea3f6 commit c527ab4

12 files changed

+27
-10
lines changed

contracts/examples/SimpleToken.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ contract SimpleToken is StandardToken {
2222
* @dev Constructor that gives msg.sender all of existing tokens.
2323
*/
2424
function SimpleToken() public {
25-
totalSupply = INITIAL_SUPPLY;
25+
totalSupply_ = INITIAL_SUPPLY;
2626
balances[msg.sender] = INITIAL_SUPPLY;
2727
Transfer(0x0, msg.sender, INITIAL_SUPPLY);
2828
}

contracts/mocks/BasicTokenMock.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ contract BasicTokenMock is BasicToken {
99

1010
function BasicTokenMock(address initialAccount, uint256 initialBalance) public {
1111
balances[initialAccount] = initialBalance;
12-
totalSupply = initialBalance;
12+
totalSupply_ = initialBalance;
1313
}
1414

1515
}

contracts/mocks/BurnableTokenMock.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ contract BurnableTokenMock is BurnableToken {
77

88
function BurnableTokenMock(address initialAccount, uint initialBalance) public {
99
balances[initialAccount] = initialBalance;
10-
totalSupply = initialBalance;
10+
totalSupply_ = initialBalance;
1111
}
1212

1313
}

contracts/mocks/ERC223TokenMock.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ contract ERC223TokenMock is BasicToken {
1212

1313
function ERC223TokenMock(address initialAccount, uint256 initialBalance) public {
1414
balances[initialAccount] = initialBalance;
15-
totalSupply = initialBalance;
15+
totalSupply_ = initialBalance;
1616
}
1717

1818
// ERC223 compatible transfer function (except the name)

contracts/mocks/ERC827TokenMock.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ contract ERC827TokenMock is ERC827Token {
99

1010
function ERC827TokenMock(address initialAccount, uint256 initialBalance) public {
1111
balances[initialAccount] = initialBalance;
12-
totalSupply = initialBalance;
12+
totalSupply_ = initialBalance;
1313
}
1414

1515
}

contracts/mocks/SafeERC20Helper.sol

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,10 @@ import "../token/ERC20/SafeERC20.sol";
55

66

77
contract ERC20FailingMock is ERC20 {
8+
function totalSupply() public view returns (uint256) {
9+
return 0;
10+
}
11+
812
function transfer(address, uint256) public returns (bool) {
913
return false;
1014
}
@@ -28,6 +32,10 @@ contract ERC20FailingMock is ERC20 {
2832

2933

3034
contract ERC20SucceedingMock is ERC20 {
35+
function totalSupply() public view returns (uint256) {
36+
return 0;
37+
}
38+
3139
function transfer(address, uint256) public returns (bool) {
3240
return true;
3341
}

contracts/mocks/StandardTokenMock.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ contract StandardTokenMock is StandardToken {
99

1010
function StandardTokenMock(address initialAccount, uint256 initialBalance) public {
1111
balances[initialAccount] = initialBalance;
12-
totalSupply = initialBalance;
12+
totalSupply_ = initialBalance;
1313
}
1414

1515
}

contracts/token/BasicToken.sol

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,15 @@ contract BasicToken is ERC20Basic {
1414

1515
mapping(address => uint256) balances;
1616

17+
uint256 totalSupply_;
18+
19+
/**
20+
* @dev total number of tokens in existence
21+
*/
22+
function totalSupply() public view returns (uint256) {
23+
return totalSupply_;
24+
}
25+
1726
/**
1827
* @dev transfer token for a specified address
1928
* @param _to The address to transfer to.

contracts/token/BurnableToken.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ contract BurnableToken is BasicToken {
2222

2323
address burner = msg.sender;
2424
balances[burner] = balances[burner].sub(_value);
25-
totalSupply = totalSupply.sub(_value);
25+
totalSupply_ = totalSupply_.sub(_value);
2626
Burn(burner, _value);
2727
}
2828
}

contracts/token/CappedToken.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ contract CappedToken is MintableToken {
2424
* @return A boolean that indicates if the operation was successful.
2525
*/
2626
function mint(address _to, uint256 _amount) onlyOwner canMint public returns (bool) {
27-
require(totalSupply.add(_amount) <= cap);
27+
require(totalSupply_.add(_amount) <= cap);
2828

2929
return super.mint(_to, _amount);
3030
}

0 commit comments

Comments
 (0)