'circusctl options <watcher>' command -- output modification #1096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge pull request circus-tent#1089 from mercma/master
be representative of what is in the configuration (ini) file
This also removes some of the details that were output that
are for internal purposes (e.g. std[out|err|in]_stream dict)
example watcher:
[watcher:exec]
cmd = /usr/bin/python3
args = /root/circus/exec.py
stdout_stream.class = FileStream
stdout_stream.filename = /root/circus/logger.log
close_child_stderr = false
close_child_stdout = false
close_child_stdin = true
use_papa = true
old output:
error: command b'{"command":"options","properties":{"name":"exec"},"id":"6d93620716dd4555bcbc35181e5ded28"}': Object of type FileStream is not JSON serializable
new output:
args: /root/circus/exec.py
close_child_stderr: False
close_child_stdin: True
close_child_stdout: False
cmd: /usr/bin/python3
copy_env: False
env:
executable:
gid:
graceful_timeout: 30.0
max_age: 0
max_age_variance: 30
max_retry: 5
numprocesses: 1
on_demand: False
priority: 0
respawn: True
send_hup: False
shell: False
shell_args:
singleton: False
stdout_stream.class: FileStream
stdout_stream.filename: /root/circus/logger.log
stop_children: False
stop_signal: 15
uid:
use_papa: True
use_sockets: False
warmup_delay: 0
working_dir: /root/circus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes the output of the:
'circusctl options '
to match the information in the [watcher:] section of the configuration file. You can now view any rlimit_, and std[out|err]_stream options. The dict information from std[out|err]_stream_conf has been removed from the output, replace with std[out|err]_stream. (as it would appear in the configuration file)