Treating google.protobuf.ListValue as an array (#145)

* Treating google.protobuf.ListValue as an array

* Adding ListValue to our list of well-known types

---------

Co-authored-by: Prawn <Prawn@Prawn>

Author: chrusty

internal/converter/testdata/google_value.go

@@ -26,15 +26,20 @@ const GoogleValue = `{
                     ],
                     "title": "Value",
                     "description": "` + "`Value`" + ` represents a dynamically typed value which can be either null, a number, a string, a boolean, a recursive struct value, or a list of values. A producer of value is expected to set one of these variants. Absence of any variant indicates an error. The JSON representation for ` + "`Value`" + ` is JSON value."
+                },
+                "some_list": {
+                    "additionalProperties": true,
+                    "type": "array"
                 }
             },
             "additionalProperties": true,
             "type": "object",
             "title": "Google Value"
         }
     }
-}`
+}
+`
 
-const GoogleValueFail = `{"arg": null}`
+const GoogleValueFail = `{"arg": null, "some_list": 4}`
 
-const GoogleValuePass = `{"arg": 12345}`
+const GoogleValuePass = `{"arg": 12345, "some_list": [1,2,3,4]}`

internal/converter/testdata/proto/GoogleValue.proto

@@ -5,4 +5,5 @@ import "google/protobuf/struct.proto";
 
 message GoogleValue {
   google.protobuf.Value arg = 1;
+  google.protobuf.ListValue some_list = 2;
 }

internal/converter/types.go

@@ -19,18 +19,19 @@ var (
 	globalPkg = newProtoPackage(nil, "")
 
 	wellKnownTypes = map[string]bool{
+		"BoolValue":   true,
+		"BytesValue":  true,
 		"DoubleValue": true,
+		"Duration":    true,
 		"FloatValue":  true,
-		"Int64Value":  true,
-		"UInt64Value": true,
 		"Int32Value":  true,
-		"UInt32Value": true,
-		"BoolValue":   true,
+		"Int64Value":  true,
+		"ListValue":   true,
 		"StringValue": true,
-		"BytesValue":  true,
-		"Value":       true,
-		"Duration":    true,
 		"Struct":      true,
+		"UInt32Value": true,
+		"UInt64Value": true,
+		"Value":       true,
 	}
 )
 
@@ -541,6 +542,8 @@ func (c *Converter) recursiveConvertMessageType(curPkg *ProtoPackage, msgDesc *d
 			jsonSchemaType.Type = gojsonschema.TYPE_STRING
 		case "Struct":
 			jsonSchemaType.Type = gojsonschema.TYPE_OBJECT
+		case "ListValue":
+			jsonSchemaType.Type = gojsonschema.TYPE_ARRAY
 		}
 
 		// If we're allowing nulls then prepare a OneOf: