Issue #7391: mute System.{err,out} in tests

Author: pbludov

pom.xml

@@ -271,7 +271,7 @@
     <dependency>
       <groupId>org.itsallcode</groupId>
       <artifactId>junit5-system-extensions</artifactId>
-      <version>1.0.3</version>
+      <version>1.1.0</version>
       <scope>test</scope>
     </dependency>
     <!-- till https://github.com/checkstyle/checkstyle/issues/7368 -->

src/test/java/com/puppycrawl/tools/checkstyle/JavadocPropertiesGeneratorTest.java

@@ -88,8 +88,8 @@ protected final String getNonCompilablePath(String filename) throws IOException
      */
     @BeforeEach
     public void setUp(@SysErr Capturable systemErr, @SysOut Capturable systemOut) {
-        systemErr.capture();
-        systemOut.capture();
+        systemErr.captureMuted();
+        systemOut.captureMuted();
     }
 
     @Test

src/test/java/com/puppycrawl/tools/checkstyle/MainTest.java

@@ -177,8 +177,8 @@ private static String getFilePath(String filename) throws IOException {
      */
     @BeforeEach
     public void setUp(@SysErr Capturable systemErr, @SysOut Capturable systemOut) {
-        systemErr.capture();
-        systemOut.capture();
+        systemErr.captureMuted();
+        systemOut.captureMuted();
 
         LOG.setLevel(ORIGINAL_LOG_LEVEL);
 

src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/AbstractJavadocCheckTest.java

@@ -41,6 +41,7 @@
 import org.itsallcode.io.Capturable;
 import org.itsallcode.junit.sysextensions.SystemErrGuard;
 import org.itsallcode.junit.sysextensions.SystemErrGuard.SysErr;
+import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.ExtendWith;
 import org.junit.jupiter.api.io.TempDir;
@@ -64,6 +65,19 @@ protected String getPackageLocation() {
         return "com/puppycrawl/tools/checkstyle/checks/javadoc/abstractjavadoc";
     }
 
+    /**
+     * <p>Configures the environment for each test.</p>
+     * <ul>
+     * <li>Start output capture for {@link System#err}</li>
+     * </ul>
+     *
+     * @param systemErr wrapper for {@code System.err}
+     */
+    @BeforeEach
+    public void setUp(@SysErr Capturable systemErr) {
+        systemErr.captureMuted();
+    }
+
     @Test
     public void testJavadocTagsWithoutArgs() throws Exception {
         final DefaultConfiguration checkconfig = createModuleConfig(TempCheck.class);
@@ -112,7 +126,6 @@ public void testCustomTag() throws Exception {
 
     @Test
     public void testParsingErrors(@SysErr Capturable systemErr) throws Exception {
-        systemErr.capture();
         final DefaultConfiguration checkConfig = createModuleConfig(TempCheck.class);
         final String[] expected = {
             "4: " + getCheckMessage(MSG_JAVADOC_MISSED_HTML_CLOSE, 4, "unclosedTag"),
@@ -135,7 +148,6 @@ public void testWithMultipleChecks() throws Exception {
 
     @Test
     public void testAntlrError(@SysErr Capturable systemErr) throws Exception {
-        systemErr.capture();
         final DefaultConfiguration checkConfig = createModuleConfig(TempCheck.class);
         final String[] expected = {
             "4: " + getCheckMessage(MSG_JAVADOC_PARSE_RULE_ERROR, 78,
@@ -148,7 +160,6 @@ public void testAntlrError(@SysErr Capturable systemErr) throws Exception {
     @Test
     public void testCheckReuseAfterParseErrorWithFollowingAntlrErrorInTwoFiles(
             @SysErr Capturable systemErr) throws Exception {
-        systemErr.capture();
         final DefaultConfiguration checkConfig = createModuleConfig(TempCheck.class);
         final Map<String, List<String>> expectedMessages = new LinkedHashMap<>(2);
         expectedMessages.put(getPath("InputAbstractJavadocParsingErrors.java"), asList(