Skip to content

Commit 32406b6

Browse files
[MERGE #3258 @digitalinfinity] Add missing project dependency to ChakraCore.vcxproj
Merge pull request #3258 from digitalinfinity:wabt_break wabt was not listed as a dependency in ChakraCore.vcxproj. In VS2017 with lightweight solution loading enabled, this was consistently reproing as a link failure. Adding an explicit project dependency to wabt appears to fix the problem.
2 parents d51a2bc + 9baab5a commit 32406b6

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

bin/ChakraCore/ChakraCore.vcxproj

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -162,6 +162,9 @@
162162
<ProjectReference Include="..\..\lib\WasmReader\Chakra.WasmReader.vcxproj">
163163
<Project>{53D52B0B-86D9-4D31-AD09-0D6B3C063ADD}</Project>
164164
</ProjectReference>
165+
<ProjectReference Condition="'$(BuildWabt)'=='true'" Include="..\..\lib\wabt\wabt.vcxproj">
166+
<Project>{F48B3491-81DF-4F49-B35F-3308CBE6A379}</Project>
167+
</ProjectReference>
165168
<ProjectReference Include="..\..\lib\Runtime\Types\Chakra.Runtime.Types.vcxproj">
166169
<Project>{706083f7-6aa4-4558-a153-6352ef9110f6}</Project>
167170
</ProjectReference>

0 commit comments

Comments
 (0)