chore: remove some dangling todos (#1790)

Resolves some unnecessary todos

#### PR checklist

- [ ] Tests written/updated
- [ ] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [ ] Updated relevant documentation (`docs/` or `spec/`) and code
comments

Author: rach-id

consensus/propagation/catchup.go

@@ -12,9 +12,6 @@ import (
 )
 
 // retryWants ensure that all data for all unpruned compact blocks is requested.
-//
-// todo: add a request limit for each part to avoid downloading the block too
-// many times. atm, this code will request the same part from every peer.
 func (blockProp *Reactor) retryWants(currentHeight int64) {
 	if !blockProp.started.Load() {
 		return

consensus/propagation/commitment.go

@@ -107,11 +107,10 @@ func extractProofs(blocks ...*types.PartSet) []*merkle.Proof {
 
 func chunkToPartMetaData(chunk *bits.BitArray, partSet *proptypes.CombinedPartSet) []*propagation.PartMetaData {
 	partMetaData := make([]*propagation.PartMetaData, 0)
-	// TODO rename indice to a correct name
-	for _, indice := range chunk.GetTrueIndices() {
-		part, _ := partSet.GetPart(uint32(indice))
+	for _, partIndex := range chunk.GetTrueIndices() {
+		part, _ := partSet.GetPart(uint32(partIndex))
 		partMetaData = append(partMetaData, &propagation.PartMetaData{
-			Index: uint32(indice),
+			Index: uint32(partIndex),
 			Hash:  part.Proof.LeafHash,
 		})
 	}

consensus/propagation/have_wants.go

@@ -435,8 +435,6 @@ func (blockProp *Reactor) handleRecoveryPart(peer p2p.ID, part *proptypes.Recove
 		proof = part.Proof
 	}
 
-	// TODO: to verify, compare the hash with that of the have that was sent for
-	// this part and verified.
 	added, err := parts.AddPart(part, *proof)
 	if err != nil {
 		blockProp.Logger.Error("failed to add part to part set", "peer", peer, "height", part.Height, "round", part.Round, "part", part.Index, "error", err)

consensus/propagation/reactor.go

@@ -121,7 +121,6 @@ func (blockProp *Reactor) SetLogger(logger log.Logger) {
 }
 
 func (blockProp *Reactor) OnStart() error {
-	// TODO: implement
 	return nil
 }
 

consensus/propagation/reactor_test.go

@@ -352,7 +352,6 @@ func TestChunkParts(t *testing.T) {
 			peerCount:  9,
 			redundancy: 1,
 			expected: []*bits.BitArray{
-				// TODO verify if this is the right result
 				createBitArray(4, []int{0}),
 				createBitArray(4, []int{1}),
 				createBitArray(4, []int{2}),

consensus/propagation/types/types.go

@@ -341,7 +341,6 @@ func (h *HaveParts) IsEmpty() bool {
 }
 
 func (h *HaveParts) GetIndex(i uint32) bool {
-	// TODO set the parts in an ordered way and support getting them faster and also get the proof and verify it
 	for _, part := range h.Parts {
 		if part.Index == i {
 			return true