bring the ffi module to 3.2.x (#852)

Signed-off-by: Craig Disselkoen <[email protected]>

Author: cdisselkoen

.github/workflows/build_and_test.yml

@@ -14,15 +14,15 @@ jobs:
     # Set `RUSTFLAGS` once for all cargo commands so that changing these flags
     # doesn't trigger a fresh build.
     env:
-      RUSTFLAGS: '-D warnings -F unsafe-code'
+      RUSTFLAGS: '-D warnings -F unsafe-code --force-warn deprecated'
 
     steps:
       - uses: actions/checkout@v4
       - run: rustup update ${{ matrix.toolchain }} && rustup default ${{ matrix.toolchain }}
       - run: ./panic_safety.sh
       - run: cargo doc --all-features --no-deps
 
-      # All targets are run with the same `RUSTFLAGS
+      # All targets are run with the same `RUSTFLAGS`
       - run: cargo build --verbose
       - run: cargo test --verbose
       - run: cargo bench --no-run --profile=dev
@@ -37,7 +37,7 @@ jobs:
       cedar_policy_ref: ${{ github.ref }}
 
   # Clippy in its own job so that the `RUSTFLAGS` set for `build_and_test`
-  # don't effect it. As a side effect, this will run in parallel, saving some
+  # don't affect it. As a side effect, this will run in parallel, saving some
   # time.
   clippy:
     runs-on: ubuntu-latest

.github/workflows/run_integration_tests_reusable.yml

@@ -24,7 +24,7 @@ jobs:
     # Set `RUSTFLAGS` once for all cargo commands so that changing these flags
     # doesn't trigger a fresh build.
     env:
-      RUSTFLAGS: '-D warnings -F unsafe-code'
+      RUSTFLAGS: '-D warnings -F unsafe-code --force-warn deprecated'
 
     steps:
       - name: Checkout cedar
@@ -53,4 +53,3 @@ jobs:
       - name: Run corpus tests
         working-directory: ./cedar
         run: cargo test --verbose --features "integration-testing" -- --ignored
-      

cedar-policy/CHANGELOG.md

@@ -13,6 +13,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
    and `RestrictedExpression::new_decimal` (#661, resolving #659)
 - `Entities::into_iter` (#713, resolving #680)
 - `Entity::into_inner` (#685, resolving #636)
+- New `ffi` module with an improved FFI interface. This will replace the
+  `frontend` module in the 4.0 release, but is available now for early adopters;
+  the `frontend` module is now deprecated. (#852)
 
 ### Changed
 

cedar-policy/src/api.rs

@@ -844,9 +844,9 @@ impl From<authorizer::AuthorizationError> for AuthorizationError {
 #[derive(Debug, PartialEq, Eq, Clone)]
 pub struct Response {
     /// Authorization decision
-    decision: Decision,
+    pub(crate) decision: Decision,
     /// Diagnostics providing more information on how this decision was reached
-    diagnostics: Diagnostics,
+    pub(crate) diagnostics: Diagnostics,
 }
 
 /// A partially evaluated authorization response.
@@ -1109,6 +1109,16 @@ impl Diagnostics {
     pub fn errors(&self) -> impl Iterator<Item = &AuthorizationError> + '_ {
         self.errors.iter()
     }
+
+    /// Consume the `Diagnostics`, producing owned versions of `reason()` and `errors()`
+    pub(crate) fn into_components(
+        self,
+    ) -> (
+        impl Iterator<Item = PolicyId>,
+        impl Iterator<Item = AuthorizationError>,
+    ) {
+        (self.reason.into_iter(), self.errors.into_iter())
+    }
 }
 
 impl Response {
@@ -1711,6 +1721,18 @@ impl<'a> ValidationResult<'a> {
                     .map(|w| w as &dyn Diagnostic)
             })
     }
+
+    pub(crate) fn into_errors_and_warnings(
+        self,
+    ) -> (
+        impl Iterator<Item = ValidationError<'static>>,
+        impl Iterator<Item = ValidationWarning<'static>>,
+    ) {
+        (
+            self.validation_errors.into_iter(),
+            self.validation_warnings.into_iter(),
+        )
+    }
 }
 
 impl<'a> From<cedar_policy_validator::ValidationResult<'a>> for ValidationResult<'static> {