Handle relative symlink paths

Author: sebastianfeldmann

src/Runner/Installer.php

@@ -268,7 +268,11 @@ private function getHookSourceCode(string $hook): string
     protected function checkForBrokenSymlink(File $file): void
     {
         if ($file->isLink()) {
-            if (!is_dir(dirname($file->linkTarget()))) {
+            $target = $file->linkTarget();
+            if (!Check::isAbsolutePath($target)) {
+                $target = dirname($file->getPath()) . DIRECTORY_SEPARATOR . $target;
+            }
+            if (!is_dir(dirname($target))) {
                 throw new RuntimeException(
                     'The hook at \'' . $file->getPath() . '\' is a broken symbolic link. ' . PHP_EOL .
                     'Please remove the symbolic link and try again.'

tests/unit/Runner/InstallerTest.php

@@ -198,7 +198,7 @@ public function testBrokenSymlinkDetectionOnExistingFile(): void
     /**
      * Tests Installer::checkForBrokenSymlinks
      */
-    public function testBrokenSymlinkDetectionOnBrokenSymlink(): void
+    public function testBrokenSymlinkDetectionOnBrokenAbsoluteSymlink(): void
     {
         $this->expectException(Exception::class);
 
@@ -213,7 +213,30 @@ public function testBrokenSymlinkDetectionOnBrokenSymlink(): void
 
         $runner = new FakeInstaller($io, $config, $repo, $template);
         $file->method('isLink')->willReturn(true);
-        $file->method('linkTarget')->willReturn('./foo/bar/baz');
+        $file->method('linkTarget')->willReturn('/foo/bar/baz');
+
+        $runner->checkSymlink($file);
+    }
+
+    /**
+     * Tests Installer::checkForBrokenSymlinks
+     */
+    public function testBrokenSymlinkDetectionOnBrokenRelativeSymlink(): void
+    {
+        $this->expectException(Exception::class);
+
+        $io       = $this->createIOMock();
+        $config   = $this->createConfigMock();
+        $repo     = $this->createRepositoryMock();
+        $template = $this->createTemplateMock();
+
+        $file = $this->getMockBuilder(File::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+
+        $runner = new FakeInstaller($io, $config, $repo, $template);
+        $file->method('isLink')->willReturn(true);
+        $file->method('linkTarget')->willReturn('../../foo/bar/baz');
 
         $runner->checkSymlink($file);
     }