Skip to content

🐛 incorrect source branch for chore workflow #202

@candoumbe

Description

@candoumbe

Usage Information

Package version : 1.2.0

Relevant Code / Invocations

Starting the chore workflow using ./build.cmd chore --name {branch-name} runs the following command

git checkout -b {chore-branch-profix}/{branch-name} {chore-branch-source-name}

which fails because of following code in IDoChoreWorkflow component

    string ChoreBranchSourceName => TryGetValue(() => ChoreBranchPrefix) ?? FeatureBranchSourceName;

The component use the value of ChoreBranchPrefix property as the name of the source branch instead of ChoreBranchSourceName parameter

Expected Behavior

The chore branch should be created without any error

Stacktrace / Exception

   fatal : 'chore' n'est pas un commit et une branche 'chore/add-tests-for-search-appointment-endpoint' ne peut pas en être créée depuis

   at Nuke.Common.Tooling.ProcessExtensions.AssertZeroExitCode(IProcess process) in /_/source/Nuke.Tooling/ProcessExtensions.cs:line 38
   at Nuke.Common.Tooling.ToolTasks.<>c.<GetExitHandler>b__4_0(ToolOptions _, IProcess p) in /_/source/Nuke.Tooling/ToolTasks.ExitHandler.cs:line 27
   at Nuke.Common.Tooling.ToolTasks.<>c__DisplayClass8_0.<GetExitHandlerInternal>b__3(ToolOptions o, IProcess p) in /_/source/Nuke.Tooling/ToolTasks.ExitHandler.cs:line 22
   at Nuke.Common.Tooling.ToolTasks.Run(ArgumentStringHandler arguments, String workingDirectory, IReadOnlyDictionary`2 environmentVariables, Nullable`1 timeout, Nullable`1 logOutput, Nullable`1 logInvocation, Action`2 logger, Func`2 exitHandler) in /_/source/Nuke.Tooling/ToolTasks.Run.cs:line 80                                                                                                                                                   
   at Nuke.Common.Tools.Git.GitTasks.Git(ArgumentStringHandler arguments, String workingDirectory, IReadOnlyDictionary`2 environmentVariables, Nullable`1 timeout, Nullable`1 logOutput, Nullable`1 logInvocation, Action`2 logger, Func`2 exitHandler) in /_/source/Nuke.Common/Tools/Git/Git.Generated.cs:line 29                                                                                                                                         
   at Candoumbe.Pipelines.Components.Workflows.IWorkflow.Checkout(String branch, String start) in /_/src/Candoumbe.Pipelines/Components/Workflows/IWorkflow.cs:line 158
   at Candoumbe.Pipelines.Components.Workflows.IWorkflow.<AskBranchNameAndSwitchToIt>g__CheckoutBranch|4_0(String& branchName, String& startBranch) in /_/src/Candoumbe.Pipelines/Components/Workflows/IWorkflow.cs:line 134
   at Candoumbe.Pipelines.Components.Workflows.IWorkflow.AskBranchNameAndSwitchToIt(String branchNamePrefix, String sourceBranch) in /_/src/Candoumbe.Pipelines/Components/Workflows/IWorkflow.cs:line 91
   at Candoumbe.Pipelines.Components.Workflows.IDoChoreWorkflow.<get_Chore>b__6_3() in /_/src/Candoumbe.Pipelines/Components/Workflows/IDoChoreWorkflow.cs:line 55
   at Nuke.Common.Execution.TargetDefinition.<>c__DisplayClass80_0.<Executes>b__0() in /_/source/Nuke.Build/Execution/TargetDefinition.cs:line 73
   at Nuke.Common.Execution.BuildExecutor.<>c.<Execute>b__4_2(Action x) in /_/source/Nuke.Build/Execution/BuildExecutor.cs:line 120
   at System.Collections.Generic.List`1.ForEach(Action`1 action)
   at Nuke.Common.Execution.BuildExecutor.Execute(NukeBuild build, ExecutableTarget target, IReadOnlyCollection`1 previouslyExecutedTargets, Boolean failureMode) in /_/source/Nuke.Build/Execution/BuildExecutor.cs:line 120
​

Metadata

Metadata

Assignees

Labels

area:workflowRelated to git branching strategybug 🐛Something isn't working

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions