fix(IPullRequest): update property accessors to use TryGetValue

- Update `DeleteLocalOnSuccess` property to use `TryGetValue<bool?>(() => DeleteLocalOnSuccess) ?? false`
- Update `Draft` property to use `TryGetValue<bool?>(() => Draft) ?? false`
- Update `Title` property to use `TryGetValue(() => Title)` and switch expression for branch type
- Update `Description` property to use `TryGetValue(() => Description)`
- Add `FinishChore` method to implement `IDoChoreWorkflow` interface

Author: candoumbe

CHANGELOG.md

@@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ## [Unreleased]
 ### 🛠️ Fixes
 - Fixed incorrect source branch name when creating a `chore` branch ([#202](https://github.com/candoumbe/pipelines/issues/202))
+- Fixed the behavior of `chore` command when running from a `chore/*` branch : the command will now properly end the `chore` workflow.
 
 ### 🚀 New features
 - Added `IDoChoreWorkflow` to `IGitFlow` and `IGitHubFlow`: this enable the `chore` target on those workflows

src/Candoumbe.Pipelines/Components/GitHub/IGitFlowWithPullRequest.cs

@@ -143,4 +143,7 @@ static void OpenUrl(string url)
                 }
             }
         }
+
+    /// <inheritdoc />
+    async ValueTask IDoChoreWorkflow.FinishChore() => await FinishFeature();
 }

src/Candoumbe.Pipelines/Components/GitHub/IGitHubFlowWithPullRequest.cs

@@ -18,13 +18,13 @@ namespace Candoumbe.Pipelines.Components.GitHub
     /// <summary>
     /// This interface adds a target to open a pull request
     /// </summary>
-    public interface IGitHubFlowWithPullRequest : IGitHubFlow, IHaveGitHubRepository
+    public interface IGitHubFlowWithPullRequest : IGitHubFlow, IPullRequest
     {
         /// <summary>
         /// The title of the PR that will be created
         /// </summary>
         [Parameter("Title that will be used when creating a PR")]
-        string Title => TryGetValue(() => Title) ?? ((GitRepository.IsOnFeatureBranch(), GitRepository.IsOnReleaseBranch(), GitRepository.IsOnHotfixBranch()) switch
+        string IPullRequest.Title => TryGetValue(() => Title) ?? ((GitRepository.IsOnFeatureBranch(), GitRepository.IsOnReleaseBranch(), GitRepository.IsOnHotfixBranch()) switch
         {
             (true, _, _) => $"✨ {GitRepository.Branch?.Replace($"{FeatureBranchPrefix}/", string.Empty).ToTitleCase()}",
             (_, _, true) => $"🛠️ {GitRepository.Branch?.Replace($"{HotfixBranchPrefix}/", string.Empty).ToTitleCase()}",
@@ -42,25 +42,7 @@ public interface IGitHubFlowWithPullRequest : IGitHubFlow, IHaveGitHubRepository
         /// Description of the pull request
         /// </summary>
         [Parameter("Description of the pull request")]
-        string Description => TryGetValue(() => Description) ?? this.As<IHaveChangeLog>()?.ReleaseNotes;
-
-        /// <summary>
-        /// Should the local branch be deleted after the pull request was created successfully ?
-        /// </summary>
-        [Parameter("Should the local branch be deleted after the pull request was created successfully ?")]
-        public bool DeleteLocalOnSuccess { get; }
-
-        /// <summary>
-        /// Defines, when set to <see langword="true"/>, to open the pull request as draft.
-        /// </summary>
-        [Parameter("Indicates to open the pull request as 'draft'")]
-        public bool Draft { get; }
-
-        /// <summary>
-        /// The issue ID for witch pull request will be created.
-        /// </summary>
-        [Parameter("Issues that will be closed once the pull request is merged.")]
-        uint[] Issues => TryGetValue(() => Issues) ?? [];
+        string IPullRequest.Description => TryGetValue(() => Description) ?? this.As<IHaveChangeLog>()?.ReleaseNotes;
 
         ///<inheritdoc/>
         async ValueTask IDoFeatureWorkflow.FinishFeature()
@@ -183,5 +165,8 @@ static void OpenUrl(string url)
                 }
             }
         }
+
+        /// <inheritdoc />
+        async ValueTask IDoChoreWorkflow.FinishChore() => await FinishFeature();
     }
 }

src/Candoumbe.Pipelines/Components/GitHub/IPullRequest.cs

@@ -24,18 +24,18 @@ public interface IPullRequest : IHaveGitHubRepository
         /// Should the local branch be deleted after the pull request was created successfully ?
         /// </summary>
         [Parameter("Should the local branch be deleted after the pull request was created successfully ?")]
-        bool DeleteLocalOnSuccess => false;
+        bool DeleteLocalOnSuccess => TryGetValue<bool?>(() => DeleteLocalOnSuccess) ?? false;
 
         /// <summary>
         /// Defines, when set to <see langword="true"/>, to open the pull request as draft.
         /// </summary>
         [Parameter("Indicates to open the pull request as 'draft'")]
-        bool Draft => false;
+        bool Draft => TryGetValue<bool?>(() => Draft) ?? false;
 
         /// <summary>
         /// The issue ID for witch pull request will be created.
         /// </summary>
         [Parameter("Issues that will be closed once the pull request is completed.")]
         uint[] Issues => TryGetValue(() => Issues) ?? [];
     }
-}
+}