Allow Alpenglow accounts in StakesCache (anza-xyz#87)

Author: wen-coding

Cargo.lock

@@ -174,7 +174,7 @@ used_underscore_binding = "deny"
 
 [workspace.dependencies]
 Inflector = "0.11.4"
-alpenglow-vote = { git = "ssh://[email protected]/solana-program/alpenglow-vote.git", rev = "80318d3" }
+alpenglow-vote = { git = "ssh://[email protected]/solana-program/alpenglow-vote.git", rev = "b3d25ff" }
 # alpenglow-vote = { path = "../alpenglow-vote/program" }
 aes-gcm-siv = "0.11.1"
 agave-banking-stage-ingress-types = { path = "banking-stage-ingress-types", version = "=3.0.0" }

Cargo.toml

@@ -52,6 +52,7 @@ agave-precompiles = { workspace = true }
 agave-reserved-account-keys = { workspace = true }
 agave-syscalls = { workspace = true }
 ahash = { workspace = true }
+alpenglow-vote = { workspace = true }
 aquamarine = { workspace = true }
 arrayref = { workspace = true }
 assert_matches = { workspace = true }

programs/sbf/Cargo.lock

@@ -578,12 +578,20 @@ pub(in crate::bank) fn new_from_parent_next_epoch(
     new_bank_from_parent_with_bank_forks(bank_forks, parent, &Pubkey::default(), slot)
 }
 
-#[test]
-fn test_bank_update_vote_stake_rewards() {
+fn test_bank_update_vote_stake_rewards(is_alpenglow: bool) {
     let thread_pool = ThreadPoolBuilder::new().num_threads(1).build().unwrap();
-    check_bank_update_vote_stake_rewards(|bank: &Bank| {
-        bank._load_vote_and_stake_accounts(&thread_pool, null_tracer())
-    });
+    check_bank_update_vote_stake_rewards(
+        |bank: &Bank| bank._load_vote_and_stake_accounts(&thread_pool, null_tracer()),
+        is_alpenglow,
+    );
+}
+
+#[test]
+fn test_bank_update_vote_stake_rewards_tests() {
+    test_bank_update_vote_stake_rewards(false);
+    //TODO(wen): rewards to Alpenglow vote accounts don't work until epoch_stakes calculation
+    // is updated.
+    //    test_bank_update_vote_stake_rewards(true);
 }
 
 impl Bank {
@@ -683,7 +691,7 @@ type StakeDelegations = Vec<(Pubkey, StakeAccount<Delegation>)>;
 type StakeDelegationsMap = DashMap<Pubkey, StakeDelegations>;
 
 #[cfg(test)]
-fn check_bank_update_vote_stake_rewards<F>(load_vote_and_stake_accounts: F)
+fn check_bank_update_vote_stake_rewards<F>(load_vote_and_stake_accounts: F, is_alpenglow: bool)
 where
     F: Fn(&Bank) -> StakeDelegationsMap,
 {
@@ -718,27 +726,39 @@ where
     );
 
     let ((vote_id, mut vote_account), (stake_id, stake_account)) =
-        crate::stakes::tests::create_staked_node_accounts(10_000);
+        crate::stakes::tests::create_staked_node_accounts(10_000, is_alpenglow);
     let starting_vote_and_stake_balance = 10_000 + 1;
 
     // set up accounts
     bank0.store_account_and_update_capitalization(&stake_id, &stake_account);
 
     // generate some rewards
-    let mut vote_state = Some(vote_state::from(&vote_account).unwrap());
-    for i in 0..MAX_LOCKOUT_HISTORY + 42 {
-        if let Some(v) = vote_state.as_mut() {
-            vote_state::process_slot_vote_unchecked(v, i as u64)
+    if is_alpenglow {
+        let mut vote_state =
+            *alpenglow_vote::state::VoteState::deserialize(vote_account.data()).unwrap();
+        for _ in 0..MAX_LOCKOUT_HISTORY + 42 {
+            let mut epoch_credits = *vote_state.epoch_credits();
+            epoch_credits.set_credits(epoch_credits.credits() + 16);
+            vote_state.set_epoch_credits(epoch_credits);
+            vote_state.serialize_into(vote_account.data_as_mut_slice());
+            bank0.store_account_and_update_capitalization(&vote_id, &vote_account);
         }
-        let versioned = VoteStateVersions::Current(Box::new(vote_state.take().unwrap()));
-        vote_state::to(&versioned, &mut vote_account).unwrap();
-        bank0.store_account_and_update_capitalization(&vote_id, &vote_account);
-        match versioned {
-            VoteStateVersions::Current(v) => {
-                vote_state = Some(*v);
+    } else {
+        let mut vote_state = Some(vote_state::from(&vote_account).unwrap());
+        for i in 0..MAX_LOCKOUT_HISTORY + 42 {
+            if let Some(v) = vote_state.as_mut() {
+                vote_state::process_slot_vote_unchecked(v, i as u64)
             }
-            _ => panic!("Has to be of type Current"),
-        };
+            let versioned = VoteStateVersions::Current(Box::new(vote_state.take().unwrap()));
+            vote_state::to(&versioned, &mut vote_account).unwrap();
+            bank0.store_account_and_update_capitalization(&vote_id, &vote_account);
+            match versioned {
+                VoteStateVersions::Current(v) => {
+                    vote_state = Some(*v);
+                }
+                _ => panic!("Has to be of type Current"),
+            };
+        }
     }
     bank0.store_account_and_update_capitalization(&vote_id, &vote_account);
     bank0.freeze();
@@ -3512,8 +3532,7 @@ fn test_add_duplicate_static_program() {
     );
 }
 
-#[test]
-fn test_add_instruction_processor_for_existing_unrelated_accounts() {
+fn test_add_instruction_processor_for_existing_unrelated_accounts(is_alpenglow: bool) {
     for pass in 0..5 {
         let mut bank = create_simple_test_bank(500);
 
@@ -3537,7 +3556,7 @@ fn test_add_instruction_processor_for_existing_unrelated_accounts() {
         }
 
         let ((vote_id, vote_account), (stake_id, stake_account)) =
-            crate::stakes::tests::create_staked_node_accounts(1_0000);
+            crate::stakes::tests::create_staked_node_accounts(1_0000, is_alpenglow);
         bank.capitalization
             .fetch_add(vote_account.lamports() + stake_account.lamports(), Relaxed);
         bank.store_account(&vote_id, &vote_account);
@@ -3617,6 +3636,12 @@ fn test_add_instruction_processor_for_existing_unrelated_accounts() {
     }
 }
 
+#[test]
+fn test_add_instruction_processor_for_existing_unrelated_accounts_tests() {
+    test_add_instruction_processor_for_existing_unrelated_accounts(false);
+    test_add_instruction_processor_for_existing_unrelated_accounts(true);
+}
+
 #[allow(deprecated)]
 #[test]
 fn test_recent_blockhashes_sysvar() {