Update code to use handle error event

Author: brianc

packages/pg/lib/client.js

@@ -383,7 +383,8 @@ class Client extends EventEmitter {
 
   _handleParseComplete() {
     if (this.activeQuery == null) {
-      this.emit('error', new Error('Received parseComplete when not in parsing state'))
+      const error =new Error('Received parseComplete when not in parsing state') 
+      this._handleErrorEvent(error)
       return
     }
     // if a prepared statement has a name and properly parses

packages/pg/test/integration/gh-issues/3174-tests.js

@@ -95,15 +95,13 @@ suite.testAsync('Out of order parseComplete on simple query is catchable', async
     errorHit = true
   })
 
-  await client.query('SELECT NOW')
+  await client.query('SELECT NOW()')
   await delay(50)
-  await client.query('SELECT NOW')
-  await delay(50)
-  await client.query('SELECT NOW')
-  await delay(50)
-  await client.end()
   assert(cli.native || errorHit)
 
+  // further queries on the client should fail since its in an invalid state
+  await assert.rejects(() => client.query('SELECTR NOW()'), 'Further queries on the client should reject')
+
   await closeServer()
 })
 
@@ -122,6 +120,10 @@ suite.testAsync('Out of order parseComplete on extended query is catchable', asy
   await client.query('SELECT $1', ['foo'])
   await delay(40)
   assert(cli.native || errorHit)
+
+  // further queries on the client should fail since its in an invalid state
+  await assert.rejects(() => client.query('SELECTR NOW()'), 'Further queries on the client should reject')
+
   await client.end()
 
   await closeServer()
@@ -142,6 +144,9 @@ suite.testAsync('Out of order parseComplete on pool is catchable', async () => {
   await delay(100)
   assert(cli.native || errorHit)
 
+  assert.strictEqual(pool.idleCount, 0, 'Pool should have no idle clients')
+  assert.strictEqual(pool.totalCount, 0, 'Pool should have no connected clients')
+
   await pool.end()
   await closeServer()
 })