Skip to content

Commit 61a4281

Browse files
committed
feat(metadata-view): resolve comments
1 parent 7a1372d commit 61a4281

File tree

2 files changed

+6
-14
lines changed

2 files changed

+6
-14
lines changed

src/elements/content-explorer/__tests__/ContentExplorer.test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import React from 'react';
22
import userEvent from '@testing-library/user-event';
3-
import { MetadataFieldType } from '@box/metadata-view';
3+
import type { MetadataFieldType } from '@box/metadata-view';
44

55
import { render, screen, waitFor, within } from '../../../test-utils/testing-library';
66
import { ContentExplorerComponent as ContentExplorer, ContentExplorerProps } from '../ContentExplorer';

src/elements/content-explorer/utils.ts

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { useMemo } from 'react';
22
import { useIntl } from 'react-intl';
33

4-
import { MetadataTemplate } from '@box/metadata-editor';
4+
import type { MetadataTemplate } from '@box/metadata-editor';
55
import type { Selection } from 'react-aria-components';
66
import type { BoxItem, Collection } from '../../common/types/core';
77

@@ -32,16 +32,8 @@ export function useSelectedItemText(currentCollection: Collection, selectedItemI
3232
export function getTemplateInstance(metadataTemplate: MetadataTemplate, selectedItems: BoxItem[]) {
3333
const { displayName, fields, hidden, id, scope, templateKey, type } = metadataTemplate;
3434

35-
const selectedItemsFields = fields.map(field => {
36-
const {
37-
displayName: fieldDisplayName,
38-
hidden: fieldHidden,
39-
id: fieldId,
40-
key,
41-
options,
42-
type: fieldType,
43-
} = field;
44-
return {
35+
const selectedItemsFields = fields.map(
36+
({ displayName: fieldDisplayName, hidden: fieldHidden, id: fieldId, key, options, type: fieldType }) => ({
4537
displayName: fieldDisplayName,
4638
hidden: fieldHidden,
4739
id: fieldId,
@@ -50,8 +42,8 @@ export function getTemplateInstance(metadataTemplate: MetadataTemplate, selected
5042
type: fieldType,
5143
// TODO: Add support for multiple selected items
5244
value: selectedItems[0].metadata[scope][templateKey][key],
53-
};
54-
});
45+
}),
46+
);
5547

5648
return {
5749
canEdit: true,

0 commit comments

Comments
 (0)