fix: validate id of box resource when constructed

Author: dp3000

src/classes/BoxFolderTests.cls

@@ -101,14 +101,14 @@ public class BoxFolderTests {
 
     public static testMethod void testGetObjectType() {
         BoxApiConnection api = new BoxApiConnection('accesstoken');
-        BoxFolder folder = new BoxFolder(api, 'folderid');
+        BoxFolder folder = new BoxFolder(api, '11446498');
         System.assertEquals('folder', folder.getObjectType());
     }
 
     public static testMethod void testSetInfo() {
         String mockResponseBody = '{"type":"folder","id":"11446498","sequence_id":"1","etag":"1","name":"Pictures","created_at":"2012-12-12T10:53:43-08:00","modified_at":"2012-12-12T11:15:04-08:00","description":"Some pictures I took","size":629644,"path_collection":{"total_count":1,"entries":[{"type":"folder","id":"0","sequence_id":null,"etag":null,"name":"All Files"}]},"created_by":{"type":"user","id":"17738362","name":"sean rose","login":"[email protected]"},"modified_by":{"type":"user","id":"17738362","name":"sean rose","login":"[email protected]"},"owned_by":{"type":"user","id":"17738362","name":"sean rose","login":"[email protected]"},"shared_link":{"url":"https://www.box.com/s/vspke7y05sb214wjokpk","download_url":null,"vanity_url":null,"is_password_enabled":false,"unshared_at":null,"download_count":0,"preview_count":0,"access":"open","permissions":{"can_download":true,"can_preview":true}},"folder_upload_email":{"access":"open","email":"[email protected]"},"parent":{"type":"folder","id":"0","sequence_id":null,"etag":null,"name":"All Files"},"item_status":"active","item_collection":{"total_count":1,"entries":[{"type":"file","id":"5000948880","sequence_id":"3","etag":"3","sha1":"134b65991ed521fcfe4724b7d814ab8ded5185dc","name":"tigers.jpeg"}],"offset":0,"limit":100}}';
         BoxApiConnection api = new BoxApiConnection('accesstoken');
-        BoxFolder folder = new BoxFolder(api, 'All Files');
+        BoxFolder folder = new BoxFolder(api, '11446498');
         BoxFolder.Info subfolderInfo = new BoxFolder.Info(mockResponseBody);
         BoxFolder.Info parentFolderInfo = new BoxFolder.Info(
             subfolderInfo.getValue('parent')

src/classes/BoxResource.cls

@@ -21,6 +21,7 @@ public abstract class BoxResource {
      */
     public BoxResource(BoxApiConnection api, String id) {
         this.api = api;
+        validateId(id);
         this.id = id;
     }
 
@@ -96,6 +97,20 @@ public abstract class BoxResource {
         return (BoxResource.Info) information;
     }
 
+    /**
+     * Validates the ID of this resource.
+     *
+     * @return void
+     */
+    private void validateId(String id) {
+        if (String.isNotEmpty(id)) {
+            System.assert(
+                id.isNumeric(),
+                'Expect resource to be constructed with a numeric ID'
+            );
+        }
+    }
+
     public abstract void setInfo(BoxJsonObject jsonObject);
 
     public abstract String getObjectType();

src/classes/BoxWebLinkTests.cls

@@ -8,7 +8,7 @@ public class BoxWebLinkTests {
 
         Test.startTest();
         BoxApiConnection api = new BoxApiConnection('accesstoken');
-        BoxWebLink webLink = new BoxWebLink(api, 'web-link-id');
+        BoxWebLink webLink = new BoxWebLink(api, '12398550180');
         BoxWebLink.Info info = webLink.getWebLinkInfo();
         Test.stopTest();
 
@@ -44,7 +44,7 @@ public class BoxWebLinkTests {
 
         Test.startTest();
         BoxApiConnection api = new BoxApiConnection('accesstoken');
-        BoxWebLink webLink = new BoxWebLink(api, 'web-link-id');
+        BoxWebLink webLink = new BoxWebLink(api, '12398550180');
         BoxWebLink.Info info = webLink.getWebLinkInfo();
         info.addValue('description', 'Example page');
         BoxWebLink.Info updated = webLink.updateWebLinkInfo(info);
@@ -62,7 +62,7 @@ public class BoxWebLinkTests {
 
         Test.startTest();
         BoxApiConnection api = new BoxApiConnection('accesstoken');
-        BoxWebLink webLink = new BoxWebLink(api, 'web-link-id');
+        BoxWebLink webLink = new BoxWebLink(api, '12398550180');
         Boolean deleteWebLinkResult = webLink.deleteWebLink();
         Test.stopTest();
 
@@ -77,7 +77,7 @@ public class BoxWebLinkTests {
 
         Test.startTest();
         BoxApiConnection api = new BoxApiConnection('accesstoken');
-        BoxWebLink webLink = new BoxWebLink(api, 'web-link-id');
+        BoxWebLink webLink = new BoxWebLink(api, '12398550180');
         BoxWebLink.Info info = webLink.getTrashedWebLinkInfo();
         Test.stopTest();
 
@@ -93,23 +93,23 @@ public class BoxWebLinkTests {
 
         Test.startTest();
         BoxApiConnection api = new BoxApiConnection('accesstoken');
-        BoxWebLink webLink = new BoxWebLink(api, 'web-link-id');
+        BoxWebLink webLink = new BoxWebLink(api, '12398550180');
         BoxWebLink.Info info = webLink.restoreTrashedWebLink();
         Test.stopTest();
 
         System.assertEquals('active', info.getValue('item_status'));
     }
 
     @isTest
-    static void permanentlyDeleteWebLinkTEst() {
+    static void permanentlyDeleteWebLinkTest() {
         Test.setMock(
             HttpCalloutMock.class,
             new BoxTestMockCallout('', 'No Content', 204)
         );
 
         Test.startTest();
         BoxApiConnection api = new BoxApiConnection('accesstoken');
-        BoxWebLink webLink = new BoxWebLink(api, 'web-link-id');
+        BoxWebLink webLink = new BoxWebLink(api, '12398550180');
         Boolean permanentlyDeleteWebLinkResult = webLink.permanentlyDeleteWebLink();
         Test.stopTest();