Skip to content

Commit 1af0a6a

Browse files
fix: Do not retry HTTP request when TaskCanceledException is thrown (box/box-codegen#665) (#406)
1 parent a59e1d3 commit 1af0a6a

File tree

3 files changed

+9
-1
lines changed

3 files changed

+9
-1
lines changed

.codegen.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
{ "engineHash": "2c730de", "specHash": "59747aa", "version": "1.6.0" }
1+
{ "engineHash": "c1e6fc8", "specHash": "59747aa", "version": "1.6.0" }

Box.Sdk.Gen/Networking/BoxNetworkClient/BoxNetworkClient.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -327,6 +327,10 @@ private static async Task<Result<HttpResponseMessage>> ExecuteRequest(HttpClient
327327
var response = await client.SendAsync(httpRequestMessage, completionOption, cancellationToken).ConfigureAwait(false);
328328
return Result<HttpResponseMessage>.Ok(response);
329329
}
330+
catch (TaskCanceledException ex)
331+
{
332+
return Result<HttpResponseMessage>.Fail(ex, isRetryable: false);
333+
}
330334
catch (HttpRequestException ex)
331335
{
332336
string pattern = @"status code\s*'(\d+)'";

Box.Sdk.Gen/Networking/DefaultNetworkClient/DefaultNetworkClient.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -328,6 +328,10 @@ private static async Task<Result<HttpResponseMessage>> ExecuteRequest(HttpClient
328328
var response = await client.SendAsync(httpRequestMessage, completionOption, cancellationToken).ConfigureAwait(false);
329329
return Result<HttpResponseMessage>.Ok(response);
330330
}
331+
catch (TaskCanceledException ex)
332+
{
333+
return Result<HttpResponseMessage>.Fail(ex, isRetryable: false);
334+
}
331335
catch (HttpRequestException ex)
332336
{
333337
string pattern = @"status code\s*'(\d+)'";

0 commit comments

Comments
 (0)