core: utils: helper_functions: Fix convertGitDescribeToUrl

patrickelectric · patrickelectric · commit f419d03d2933 · 2022-01-31T11:05:48.000-03:00
Add check for undefined string

Signed-off-by: Patrick José Pereira &lt;patrickelectric@gmail.com&gt;
diff --git a/core/frontend/src/utils/helper_functions.ts b/core/frontend/src/utils/helper_functions.ts
@@ -46,7 +46,7 @@ export function convertGitDescribeToUrl(git_describe: string): string {
   const project_url = `https://github.com/${user}/${repository}`
 
   // Local development version, pointing to root page
-  if (git_describe.endsWith('-dirty') || git_describe.length === 0) {
+  if (!git_describe || git_describe.endsWith('-dirty') || git_describe.length === 0) {
     return project_url
   }
 

Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ export function convertGitDescribeToUrl(git_describe: string): string {`
`46`	`46`	const project_url = `https://github.com/${user}/${repository}`
`47`	`47`
`48`	`48`	`// Local development version, pointing to root page`
`49`		`- if (git_describe.endsWith('-dirty') \|\| git_describe.length === 0) {`
	`49`	`+ if (!git_describe \|\| git_describe.endsWith('-dirty') \|\| git_describe.length === 0) {`
`50`	`50`	`return project_url`
`51`	`51`	`}`
`52`	`52`