Skip to content

Commit 4baff56

Browse files
Apply suggestions from code review
Co-authored-by: ES-Alexander <[email protected]>
1 parent 37bd996 commit 4baff56

File tree

1 file changed

+27
-25
lines changed
  • core/frontend/src/components/vehiclesetup/configuration/failsafes

1 file changed

+27
-25
lines changed

core/frontend/src/components/vehiclesetup/configuration/failsafes/Failsafes.vue

Lines changed: 27 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,9 @@ export default {
4242
async get_failsafes(): Promise<FailsafeDefinition[]> {
4343
const failsafes: FailsafeDefinition[] = [
4444
{
45-
name: 'Ground Station Heartbeat Loss',
46-
generalDescription: 'The heartbeat failsafe is triggered when the vehicle does not receive '
47-
+ 'a heartbeat from the GCS within 3 seconds.',
45+
name: 'Control Station Heartbeat Loss',
46+
generalDescription: 'Triggers when the vehicle does not receive a heartbeat from the GCS '
47+
+ 'within the timeout (default 3 seconds).',
4848
image: (await import('@/assets/img/configuration/failsafes/heartbeat.svg')).default as string,
4949
5050
params: [
@@ -64,25 +64,25 @@ export default {
6464
},
6565
{
6666
name: 'Pilot Input Loss',
67-
generalDescription: 'The pilot input failsafe is triggered when the vehicle does not receive '
68-
+ 'any pilot input for a given amount of time.',
67+
generalDescription: 'Triggers when the vehicle does not receive any pilot input for a given '
68+
+ 'amount of time.',
6969
image: (await import('@/assets/img/configuration/failsafes/pilot-input.svg')).default as string,
7070
params: [
71-
{
72-
replacementTitle: 'Action',
73-
icon: 'mdi-lightning-bolt',
74-
name: 'FS_PILOT_INPUT',
75-
},
7671
{
7772
replacementTitle: 'Timeout',
7873
icon: 'mdi-timer-outline',
7974
name: 'FS_PILOT_TIMEOUT',
8075
},
76+
{
77+
replacementTitle: 'Action',
78+
icon: 'mdi-lightning-bolt',
79+
name: 'FS_PILOT_INPUT',
80+
},
8181
],
8282
},
8383
{
84-
name: 'Leak detection',
85-
generalDescription: 'Triggered when a leak is detected. We recoomend keeping control electronics dry.',
84+
name: 'Leak Detection',
85+
generalDescription: 'Triggers when a leak is detected. We recommend keeping control electronics dry.',
8686
image: (await import('@/assets/img/configuration/failsafes/leak.svg')).default as string,
8787
params: [
8888
{
@@ -105,14 +105,15 @@ export default {
105105
],
106106
},
107107
{
108-
name: 'Internal Pressure',
109-
generalDescription: 'Triggered when the internal pressure is too high. this could help in detecting a leak'
110-
+ ' and in avoiding rapid unplanned disassembly.',
108+
name: 'Excess Internal Pressure',
109+
generalDescription: 'Triggers when the internal pressure is too high. This may help to detect a leak, '
110+
+ 'and to avoid rapid unplanned disassembly.',
111111
image: (await import('@/assets/img/configuration/failsafes/pressure.svg')).default as string,
112112
params: [
113113
114114
{
115115
replacementTitle: 'Maximum internal pressure',
116+
icon: 'mdi-gauge-full',
116117
name: 'FS_PRESS_MAX',
117118
},
118119
{
@@ -123,20 +124,20 @@ export default {
123124
],
124125
},
125126
{
126-
name: 'Battery Level',
127-
generalDescription: 'Triggered when the battery reaches given thresholds.\n This can help in avoiding '
127+
name: 'Low Battery',
128+
generalDescription: 'Triggers when the voltage goes below specified thresholds.\n This can help to avoid '
128129
+ 'damage to the battery and potentially loss of the vehicle.',
129130
image: (await import('@/assets/img/configuration/failsafes/battery.svg')).default as string,
130131
params: [
131132
// TODO: add support for the MAH params and coloumb counting
132133
{
133-
replacementTitle: 'Voltage Measurement Source',
134+
replacementTitle: 'Voltage measurement source',
134135
icon: 'mdi-source-branch',
135136
name: 'BATT_FS_VOLTSRC',
136137
},
137138
{
138139
replacementTitle: 'Low voltage threshold',
139-
icon: 'mdi-gauge-empty',
140+
icon: 'mdi-battery-30',
140141
name: 'BATT_LOW_VOLT',
141142
},
142143
{
@@ -146,7 +147,7 @@ export default {
146147
},
147148
{
148149
replacementTitle: 'Critical voltage threshold',
149-
icon: 'mdi-gauge-empty',
150+
icon: 'mdi-battery-alert-variant-outline',
150151
name: 'BATT_CRT_VOLT',
151152
},
152153
{
@@ -157,13 +158,14 @@ export default {
157158
],
158159
},
159160
{
160-
name: 'EKF tolerance',
161-
generalDescription: 'Triggered when the EKF variances surpass a given threshold.',
161+
name: 'Sensor Fusion Uncertainty',
162+
generalDescription: 'Triggers when the EKF variances surpass a given threshold, '
163+
+ 'so it loses trust in its state estimates.',
162164
image: (await import('@/assets/img/configuration/failsafes/ekf.svg')).default as string,
163165
params: [
164166
{
165-
replacementTitle: 'Variance Threshold',
166-
icon: 'mdi-gauge-empty',
167+
replacementTitle: 'Variance threshold',
168+
icon: 'mdi-chart-bell-curve',
167169
name: 'FS_EKF_THRESH',
168170
},
169171
{
@@ -175,7 +177,7 @@ export default {
175177
},
176178
{
177179
name: 'Crash Detection',
178-
generalDescription: 'Triggered when a crash is detected.',
180+
generalDescription: 'Triggers when a crash has occurred.',
179181
image: (await import('@/assets/img/configuration/failsafes/crash.svg')).default as string,
180182
params: [
181183
{

0 commit comments

Comments
 (0)