Skip to content

Commit f146d41

Browse files
[deps]: Update electron to v34 (#713)
* [deps]: Update electron to v34 * fix: remove event parameter from minimize handler for Electron 34 compatibility The minimize event in Electron 34 no longer provides an event object, requiring removal of the e.preventDefault() call. * feat(deps): add [email protected] as devDependency for Electron 34 rebuild Required for electron-rebuild to work correctly with Electron 34. Previous transitive dependency version (3.68.0) was too old to support Electron 34. * Bump Electron to v34.1.1 --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Rui Tome <[email protected]>
1 parent b35cf8e commit f146d41

File tree

3 files changed

+13
-14
lines changed

3 files changed

+13
-14
lines changed

jslib/electron/src/tray.main.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,9 +60,8 @@ export class TrayMain {
6060
}
6161

6262
setupWindowListeners(win: BrowserWindow) {
63-
win.on("minimize", async (e: Event) => {
63+
win.on("minimize", async () => {
6464
if (await this.stateService.getEnableMinimizeToTray()) {
65-
e.preventDefault();
6665
this.hideToTray();
6766
}
6867
});

package-lock.json

Lines changed: 8 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@
9898
"cross-env": "7.0.3",
9999
"css-loader": "7.1.2",
100100
"dotenv": "16.4.7",
101-
"electron": "32.1.1",
101+
"electron": "34.1.1",
102102
"electron-builder": "24.13.3",
103103
"electron-log": "5.2.4",
104104
"electron-reload": "2.0.0-alpha.1",
@@ -120,6 +120,7 @@
120120
"jest-preset-angular": "14.5.0",
121121
"lint-staged": "15.4.1",
122122
"mini-css-extract-plugin": "2.9.2",
123+
"node-abi": "3.74.0",
123124
"node-forge": "1.3.1",
124125
"node-loader": "2.1.0",
125126
"pkg": "5.8.1",
@@ -137,8 +138,8 @@
137138
"webpack": "5.97.1",
138139
"webpack-cli": "6.0.1",
139140
"webpack-merge": "6.0.1",
140-
"zone.js": "0.14.10",
141-
"webpack-node-externals": "3.0.0"
141+
"webpack-node-externals": "3.0.0",
142+
"zone.js": "0.14.10"
142143
},
143144
"dependencies": {
144145
"@angular/animations": "17.3.12",

0 commit comments

Comments
 (0)