perf(linter): speed up noPrivateImports (#7461)

Author: arendjr

.changeset/private-parties-parade.md

@@ -0,0 +1,7 @@
+---
+"@biomejs/biome": patch
+---
+
+Improved performance of `noPrivateImports` by eliminating allocations.
+
+In one repository, the total runtime of Biome with only `noPrivateImports` enabled went from ~3.2s down to ~1.4s.

crates/biome_js_analyze/src/lint/correctness/no_private_imports.rs

@@ -151,7 +151,7 @@ pub struct NoPrivateImportsState {
     range: TextRange,
 
     /// The path where the visibility of the imported symbol is defined.
-    path: Box<str>,
+    path: String,
 
     /// The visibility of the offending symbol.
     visibility: Visibility,
@@ -271,15 +271,13 @@ fn get_restricted_imports_from_module_source(
     node: &JsModuleSource,
     options: &GetRestrictedImportOptions,
 ) -> SyntaxResult<Vec<NoPrivateImportsState>> {
-    let path: Box<str> = options.target_path.as_str().into();
-
     let results = match node.syntax().parent().and_then(AnyJsImportClause::cast) {
         Some(AnyJsImportClause::JsImportCombinedClause(node)) => {
             let range = node.default_specifier()?.range();
             get_restricted_import_visibility(&Text::new_static("default"), options)
                 .map(|visibility| NoPrivateImportsState {
                     range,
-                    path: path.clone(),
+                    path: options.target_path.to_string(),
                     visibility,
                 })
                 .into_iter()
@@ -298,7 +296,7 @@ fn get_restricted_imports_from_module_source(
                             )
                             .map(|visibility| NoPrivateImportsState {
                                 range: name.text_trimmed_range(),
-                                path: path.clone(),
+                                path: options.target_path.to_string(),
                                 visibility,
                             })
                         }),
@@ -310,7 +308,7 @@ fn get_restricted_imports_from_module_source(
             get_restricted_import_visibility(&Text::new_static("default"), options)
                 .map(|visibility| NoPrivateImportsState {
                     range,
-                    path,
+                    path: options.target_path.to_string(),
                     visibility,
                 })
                 .into_iter()
@@ -326,7 +324,7 @@ fn get_restricted_imports_from_module_source(
                 get_restricted_import_visibility(&Text::from(name.token_text_trimmed()), options)
                     .map(|visibility| NoPrivateImportsState {
                         range: name.text_trimmed_range(),
-                        path: path.clone(),
+                        path: options.target_path.to_string(),
                         visibility,
                     })
             })