add more test cases

Author: ematipico

.changeset/nine-turkeys-dig.md

@@ -2,7 +2,7 @@
 "@biomejs/biome": patch
 ---
 
-Added the new nursery lint rule `noJsxLiterals`, which disallow the use of string literals inside JSX.
+Added the new nursery lint rule `noJsxLiterals`, which disallows the use of string literals inside JSX.
 
 The rule catches these cases:
 

crates/biome_js_analyze/src/lint/nursery/no_jsx_literals.rs

@@ -75,6 +75,11 @@ declare_lint_rule! {
     ///   {'Please enter your name'}
     /// </span>
     /// ```
+    /// ```jsx,expect_diagnostic,use_options
+    /// <Component title="Hello!" />
+    /// ```
+    ///
+    ///
     ///
     /// ### `allowedStrings`
     ///

crates/biome_js_analyze/tests/specs/nursery/noJsxLiterals/invalidAllowedStrings.jsx

@@ -1,6 +1,7 @@
 // should generate diagnostics
 <>
 	<div>allowed</div>
+	<div>allowed   </div>
 	<>test</>
 </>
 

crates/biome_js_analyze/tests/specs/nursery/noJsxLiterals/invalidAllowedStrings.jsx.snap

@@ -7,6 +7,7 @@ expression: invalidAllowedStrings.jsx
 // should generate diagnostics
 <>
 	<div>allowed</div>
+	<div>allowed   </div>
 	<>test</>
 </>
 
@@ -22,16 +23,35 @@ class Comp1 extends Component {
 
 # Diagnostics
 ```
-invalidAllowedStrings.jsx:4:4 lint/nursery/noJsxLiterals ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+invalidAllowedStrings.jsx:4:7 lint/nursery/noJsxLiterals ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
   i Incorrect use of string literal detected.
   
     2 │ <>
     3 │ 	<div>allowed</div>
-  > 4 │ 	<>test</>
+  > 4 │ 	<div>allowed   </div>
+      │ 	     ^^^^^^^^^^
+    5 │ 	<>test</>
+    6 │ </>
+  
+  i String literals in JSX can make code harder to maintain and internationalize.
+  
+  i Consider avoiding hardcoded strings entirely.
+  
+
+```
+
+```
+invalidAllowedStrings.jsx:5:4 lint/nursery/noJsxLiterals ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+
+  i Incorrect use of string literal detected.
+  
+    3 │ 	<div>allowed</div>
+    4 │ 	<div>allowed   </div>
+  > 5 │ 	<>test</>
       │ 	  ^^^^
-    5 │ </>
-    6 │ 
+    6 │ </>
+    7 │ 
   
   i String literals in JSX can make code harder to maintain and internationalize.
   
@@ -41,16 +61,16 @@ invalidAllowedStrings.jsx:4:4 lint/nursery/noJsxLiterals ━━━━━━━
 ```
 
 ```
-invalidAllowedStrings.jsx:10:43 lint/nursery/noJsxLiterals ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+invalidAllowedStrings.jsx:11:43 lint/nursery/noJsxLiterals ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
   i Incorrect use of string literal detected.
   
-     8 │ class Comp1 extends Component {
-     9 │ 	render() {
-  > 10 │ 		const varObjectTest = { testKey : (<div>test</div>) };
+     9 │ class Comp1 extends Component {
+    10 │ 	render() {
+  > 11 │ 		const varObjectTest = { testKey : (<div>test</div>) };
        │ 		                                        ^^^^
-    11 │ 		return varObjectTest.testKey;
-    12 │ 	}
+    12 │ 		return varObjectTest.testKey;
+    13 │ 	}
   
   i String literals in JSX can make code harder to maintain and internationalize.
   

crates/biome_js_analyze/tests/specs/nursery/noJsxLiterals/invalidNoStringsAllowedStrings.jsx

@@ -0,0 +1,15 @@
+// should generate diagnostics
+<>
+	<div>allowed</div>
+	<div>allowed   </div>
+	<div>{"allowed   "}</div>
+	<>test</>
+</>
+
+
+class Comp1 extends Component {
+	render() {
+		const varObjectTest = { testKey : (<div>test</div>) };
+		return varObjectTest.testKey;
+	}
+}

crates/biome_js_analyze/tests/specs/nursery/noJsxLiterals/invalidNoStringsAllowedStrings.jsx.snap

@@ -0,0 +1,100 @@
+---
+source: crates/biome_js_analyze/tests/spec_tests.rs
+expression: invalidNoStringsAllowedStrings.jsx
+---
+# Input
+```jsx
+// should generate diagnostics
+<>
+	<div>allowed</div>
+	<div>allowed   </div>
+	<div>{"allowed   "}</div>
+	<>test</>
+</>
+
+
+class Comp1 extends Component {
+	render() {
+		const varObjectTest = { testKey : (<div>test</div>) };
+		return varObjectTest.testKey;
+	}
+}
+
+```
+
+# Diagnostics
+```
+invalidNoStringsAllowedStrings.jsx:4:7 lint/nursery/noJsxLiterals ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+
+  i Incorrect use of string literal detected.
+  
+    2 │ <>
+    3 │ 	<div>allowed</div>
+  > 4 │ 	<div>allowed   </div>
+      │ 	     ^^^^^^^^^^
+    5 │ 	<div>{"allowed   "}</div>
+    6 │ 	<>test</>
+  
+  i String literals in JSX can make code harder to maintain and internationalize.
+  
+  i Consider avoiding hardcoded strings entirely.
+  
+
+```
+
+```
+invalidNoStringsAllowedStrings.jsx:5:8 lint/nursery/noJsxLiterals ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+
+  i Incorrect use of string literal detected.
+  
+    3 │ 	<div>allowed</div>
+    4 │ 	<div>allowed   </div>
+  > 5 │ 	<div>{"allowed   "}</div>
+      │ 	      ^^^^^^^^^^^^
+    6 │ 	<>test</>
+    7 │ </>
+  
+  i String literals in JSX can make code harder to maintain and internationalize.
+  
+  i Consider avoiding hardcoded strings entirely.
+  
+
+```
+
+```
+invalidNoStringsAllowedStrings.jsx:6:4 lint/nursery/noJsxLiterals ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+
+  i Incorrect use of string literal detected.
+  
+    4 │ 	<div>allowed   </div>
+    5 │ 	<div>{"allowed   "}</div>
+  > 6 │ 	<>test</>
+      │ 	  ^^^^
+    7 │ </>
+    8 │ 
+  
+  i String literals in JSX can make code harder to maintain and internationalize.
+  
+  i Consider avoiding hardcoded strings entirely.
+  
+
+```
+
+```
+invalidNoStringsAllowedStrings.jsx:12:43 lint/nursery/noJsxLiterals ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+
+  i Incorrect use of string literal detected.
+  
+    10 │ class Comp1 extends Component {
+    11 │ 	render() {
+  > 12 │ 		const varObjectTest = { testKey : (<div>test</div>) };
+       │ 		                                        ^^^^
+    13 │ 		return varObjectTest.testKey;
+    14 │ 	}
+  
+  i String literals in JSX can make code harder to maintain and internationalize.
+  
+  i Consider avoiding hardcoded strings entirely.
+  
+
+```

crates/biome_js_analyze/tests/specs/nursery/noJsxLiterals/invalidNoStringsAllowedStrings.options.json

@@ -0,0 +1,16 @@
+{
+  "$schema": "../../../../../../packages/@biomejs/biome/configuration_schema.json",
+  "linter": {
+    "rules": {
+      "nursery": {
+        "noJsxLiterals": {
+          "level": "on",
+          "options": {
+            "noStrings": true,
+            "allowedStrings": ["allowed"]
+          }
+        }
+      }
+    }
+  }
+}

crates/biome_js_analyze/tests/specs/nursery/noJsxLiterals/validIgnoreProps.jsx

@@ -2,4 +2,7 @@
 <>
 	<Foo bar={"allowed"} />
 	<Foo bar="allowed"></Foo>
+	<Foo data-testid="allowed" />
+	<Foo className={'allowed'} />
+	<Foo bar={`allowed`} />
 </>

crates/biome_js_analyze/tests/specs/nursery/noJsxLiterals/validIgnoreProps.jsx.snap

@@ -8,6 +8,9 @@ expression: validIgnoreProps.jsx
 <>
 	<Foo bar={"allowed"} />
 	<Foo bar="allowed"></Foo>
+	<Foo data-testid="allowed" />
+	<Foo className={'allowed'} />
+	<Foo bar={`allowed`} />
 </>
 
 ```

crates/biome_rule_options/src/no_jsx_literals.rs

@@ -4,12 +4,11 @@ use serde::{Deserialize, Serialize};
 #[cfg_attr(feature = "schema", derive(schemars::JsonSchema))]
 #[serde(rename_all = "camelCase", deny_unknown_fields, default)]
 pub struct NoJsxLiteralsOptions {
-    /// When enabled, no strings are allowed inside JSX children
+    /// When enabled, also flag string literals inside JSX expressions and attributes
     #[serde(default)]
     pub no_strings: bool,
 
     /// An array of strings that won't trigger the rule. Whitespaces are taken into consideration
-    #[serde(default)]
     pub allowed_strings: Box<[Box<str>]>,
 
     /// When enabled, strings inside props are always ignored