fix(cli): logging color (#7441)

Co-authored-by: siketyan <[email protected]>
Co-authored-by: mdevils <[email protected]>

Author: 3 people

.changeset/shy-ants-buy.md

@@ -0,0 +1,5 @@
+---
+"@biomejs/biome": patch
+---
+
+Fixed [#3824](https://github.com/biomejs/biome/issues/3824). Now the option CLI `--color` is correctly applied to logging too.

crates/biome_cli/src/cli_options.rs

@@ -118,6 +118,15 @@ pub enum ColorsArg {
     Force,
 }
 
+impl ColorsArg {
+    pub fn is_enabled(&self) -> bool {
+        matches!(self, Self::Force)
+    }
+    pub fn is_disabled(&self) -> bool {
+        matches!(self, Self::Off)
+    }
+}
+
 impl FromStr for ColorsArg {
     type Err = String;
 

crates/biome_cli/src/commands/mod.rs

@@ -850,6 +850,7 @@ pub(crate) trait CommandRunner: Sized {
             cli_options.log_file.as_deref(),
             cli_options.log_level,
             cli_options.log_kind,
+            cli_options.colors.as_ref(),
         );
         let console = &mut *session.app.console;
         let workspace = &*session.app.workspace;

crates/biome_cli/src/logging.rs

@@ -2,6 +2,7 @@ use std::fmt::{Display, Formatter};
 use std::fs::File;
 use std::str::FromStr;
 
+use crate::cli_options::ColorsArg;
 use tracing::Metadata;
 use tracing::subscriber::Interest;
 use tracing_subscriber::filter::LevelFilter;
@@ -10,7 +11,12 @@ use tracing_subscriber::layer::{Context, Filter, SubscriberExt};
 use tracing_subscriber::util::SubscriberInitExt;
 use tracing_subscriber::{Layer as _, registry};
 
-pub fn setup_cli_subscriber(file: Option<&str>, level: LoggingLevel, kind: LoggingKind) {
+pub fn setup_cli_subscriber(
+    file: Option<&str>,
+    level: LoggingLevel,
+    kind: LoggingKind,
+    colors: Option<&ColorsArg>,
+) {
     if level == LoggingLevel::None {
         return;
     }
@@ -20,7 +26,7 @@ pub fn setup_cli_subscriber(file: Option<&str>, level: LoggingLevel, kind: Loggi
         .with_target(false)
         .with_thread_names(true)
         .with_file(true)
-        .with_ansi(true);
+        .with_ansi(colors.is_none_or(|c| c.is_enabled()));
 
     if level == LoggingLevel::Tracing {
         format = format.with_span_events(FmtSpan::CLOSE);