fix(linter): fix aliased paths in useImportExtensions (#7597)

Author: arendjr

.changeset/aliased-angels-ascend.md

@@ -0,0 +1,5 @@
+---
+"@biomejs/biome": patch
+---
+
+Fixed [#6432](https://github.com/biomejs/biome/issues/6432): [`useImportExtensions`](https://biomejs.dev/linter/rules/use-import-extensions/) now works correctly with aliased paths.

.changeset/packaged-parcels-ponder.md

@@ -0,0 +1,6 @@
+---
+"@biomejs/biome": patch
+---
+
+Fixed an issue where `package.json` manifests would not be correctly discovered
+when evaluating files in the same directory.

crates/biome_js_analyze/src/lint/correctness/use_import_extensions.rs

@@ -147,7 +147,7 @@ impl Rule for UseImportExtensions {
             .get_import_path_by_js_node(node)
             .and_then(JsImportPath::as_path)?;
 
-        get_extensionless_import(node, resolved_path, force_js_extensions)
+        get_extensionless_import(node, resolved_path, ctx, force_js_extensions)
     }
 
     fn diagnostic(_: &RuleContext<Self>, state: &Self::State) -> Option<RuleDiagnostic> {
@@ -200,6 +200,7 @@ pub struct UseImportExtensionsState {
 fn get_extensionless_import(
     node: &AnyJsImportLike,
     resolved_path: &Utf8Path,
+    ctx: &RuleContext<UseImportExtensions>,
     force_js_extensions: bool,
 ) -> Option<UseImportExtensionsState> {
     let module_name_token = node.module_name_token()?;
@@ -212,7 +213,17 @@ fn get_extensionless_import(
         first_component,
         Utf8Component::CurDir | Utf8Component::ParentDir
     ) {
-        return None;
+        // TypeScript path aliases should still be considered.
+        // The same does *not* apply for `package.json` aliases, because
+        // extensions are not automatically applied to those.
+        let matches_path_alias = ctx
+            .project_layout()
+            .query_tsconfig_for_path(ctx.file_path(), |tsconfig| {
+                tsconfig.matches_path_alias(path.as_str())
+            })?;
+        if !matches_path_alias {
+            return None;
+        }
     }
 
     let resolved_stem = resolved_path.file_stem();
@@ -291,7 +302,7 @@ fn get_extensionless_import(
         };
 
         if let Some(sub_ext) = sub_extension {
-            new_path.set_extension(format!("{sub_ext}.{extension}",));
+            new_path.set_extension(format!("{sub_ext}.{extension}"));
         } else {
             new_path.set_extension(extension);
         }

crates/biome_js_analyze/src/services/module_graph.rs

@@ -3,12 +3,13 @@ use biome_analyze::{
     RuleMetadata, ServiceBag, ServicesDiagnostic, SyntaxVisitor,
 };
 use biome_module_graph::{JsModuleInfo, ModuleGraph};
+use biome_project_layout::ProjectLayout;
 use biome_rowan::{AstNode, Language, SyntaxNode, TextRange};
 use camino::Utf8Path;
 use std::sync::Arc;
 
 #[derive(Debug, Clone)]
-pub struct ModuleGraphService(Arc<ModuleGraph>);
+pub struct ModuleGraphService(Arc<ModuleGraph>, Arc<ProjectLayout>);
 
 impl ModuleGraphService {
     pub fn module_graph(&self) -> &ModuleGraph {
@@ -18,6 +19,10 @@ impl ModuleGraphService {
     pub fn module_info_for_path(&self, path: &Utf8Path) -> Option<JsModuleInfo> {
         self.0.module_info_for_path(path)
     }
+
+    pub fn project_layout(&self) -> &ProjectLayout {
+        self.1.as_ref()
+    }
 }
 
 impl FromServices for ModuleGraphService {
@@ -41,7 +46,11 @@ impl FromServices for ModuleGraphService {
             .get_service()
             .ok_or_else(|| ServicesDiagnostic::new(rule_key.rule_name(), &["ModuleGraph"]))?;
 
-        Ok(Self(module_graph.clone()))
+        let project_layout: &Arc<ProjectLayout> = services
+            .get_service()
+            .ok_or_else(|| ServicesDiagnostic::new(rule_key.rule_name(), &["ProjectLayout"]))?;
+
+        Ok(Self(module_graph.clone(), project_layout.clone()))
     }
 }
 

crates/biome_js_analyze/tests/spec_tests.rs

@@ -15,7 +15,7 @@ use biome_test_utils::{
     CheckActionType, assert_diagnostics_expectation_comment, assert_errors_are_absent,
     code_fix_to_string, create_analyzer_options, diagnostic_to_string,
     has_bogus_nodes_or_empty_slots, module_graph_for_test_file, parse_test_path,
-    project_layout_with_node_manifest, register_leak_checker, scripts_from_json,
+    project_layout_for_test_file, register_leak_checker, scripts_from_json,
     write_analyzer_snapshot,
 };
 use camino::Utf8Path;
@@ -167,7 +167,7 @@ pub(crate) fn analyze_and_snap(
 ) {
     let mut diagnostics = Vec::new();
     let mut code_fixes = Vec::new();
-    let project_layout = project_layout_with_node_manifest(input_file, &mut diagnostics);
+    let project_layout = project_layout_for_test_file(input_file, &mut diagnostics);
 
     if let Some((_, manifest)) = project_layout.find_node_manifest_for_path(input_file)
         && manifest.r#type == Some(PackageType::CommonJs) &&

crates/biome_js_analyze/tests/specs/correctness/useImportExtensions/.gitignore

@@ -0,0 +1 @@
+!node_modules

crates/biome_js_analyze/tests/specs/correctness/useImportExtensions/invalidWithPathAlias.package.json

@@ -0,0 +1 @@
+{}

crates/biome_js_analyze/tests/specs/correctness/useImportExtensions/invalidWithPathAlias.ts

@@ -0,0 +1,5 @@
+/* should generate diagnostics */
+
+import foo from "libs/foo";
+
+import bar from "libs/bar";

crates/biome_js_analyze/tests/specs/correctness/useImportExtensions/invalidWithPathAlias.ts.snap

@@ -0,0 +1,60 @@
+---
+source: crates/biome_js_analyze/tests/spec_tests.rs
+expression: invalidWithPathAlias.ts
+---
+# Input
+```ts
+/* should generate diagnostics */
+
+import foo from "libs/foo";
+
+import bar from "libs/bar";
+
+```
+
+# Diagnostics
+```
+invalidWithPathAlias.ts:3:17 lint/correctness/useImportExtensions  FIXABLE  ━━━━━━━━━━━━━━━━━━━━━━━━
+
+  ! Add a file extension for relative imports.
+  
+    1 │ /* should generate diagnostics */
+    2 │ 
+  > 3 │ import foo from "libs/foo";
+      │                 ^^^^^^^^^^
+    4 │ 
+    5 │ import bar from "libs/bar";
+  
+  i Explicit import improves compatibility with browsers and makes file resolution in tooling faster.
+  
+  i Safe fix: Add import extension .ts.
+  
+    1 1 │   /* should generate diagnostics */
+    2 2 │   
+    3   │ - import·foo·from·"libs/foo";
+      3 │ + import·foo·from·"libs/foo.ts";
+    4 4 │   
+    5 5 │   import bar from "libs/bar";
+  
+
+```
+
+```
+invalidWithPathAlias.ts:5:17 lint/correctness/useImportExtensions  FIXABLE  ━━━━━━━━━━━━━━━━━━━━━━━━
+
+  ! Add a file extension for relative imports.
+  
+    3 │ import foo from "libs/foo";
+    4 │ 
+  > 5 │ import bar from "libs/bar";
+      │                 ^^^^^^^^^^
+    6 │ 
+  
+  i Explicit import improves compatibility with browsers and makes file resolution in tooling faster.
+  
+  i Safe fix: Add import extension .ts.
+  
+    5 │ import·bar·from·"libs/bar/index.ts";
+      │                          +++++++++  
+
+```

crates/biome_js_analyze/tests/specs/correctness/useImportExtensions/invalidWithPathAlias.tsconfig.json

@@ -0,0 +1,7 @@
+{
+	"compilerOptions": {
+		"paths": {
+			"libs/*": ["./sub/*"]
+		}
+	}
+}