feat(analyse/json): add noDuplicateDependencies rule (#7142)

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Emanuele Stoppa <[email protected]>

Author: 3 people

.changeset/seven-bats-write.md

@@ -0,0 +1,40 @@
+---
+"@biomejs/biome": patch
+---
+
+Added the new nursery rule [`noDuplicateDependencies`](https://next.biomejs.dev/linter/rules/no-duplicate-dependencies/), which verifies that no dependencies are duplicated between the `bundledDependencies`, `bundleDependencies`, `dependencies`, `devDependencies`, `overrides`, `optionalDependencies`, and `peerDependencies` sections.
+
+For example, the following snippets will trigger the rule:
+
+```json
+{
+  "dependencies": {
+    "foo": ""
+  },
+  "devDependencies": {
+    "foo": ""
+  }
+}
+```
+
+```json
+{
+  "dependencies": {
+    "foo": ""
+  },
+  "optionalDependencies": {
+    "foo": ""
+  }
+}
+```
+
+```json
+{
+  "dependencies": {
+    "foo": ""
+  },
+  "peerDependencies": {
+    "foo": ""
+  }
+}
+```

crates/biome_analyze/src/rule.rs

@@ -157,6 +157,10 @@ pub enum RuleSource {
     EslintVitest(&'static str),
     /// Rules from [Eslint Plugin Vue.js](https://eslint.vuejs.org/)
     EslintVueJs(&'static str),
+    /// Rules from [Eslint Plugin Package.json](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json)
+    EslintPackageJson(&'static str),
+    /// Rules from [Eslint Plugin Package.json Dependencies](https://github.com/idan-at/eslint-plugin-package-json-dependencies)
+    EslintPackageJsonDependencies(&'static str),
 }
 
 impl PartialEq for RuleSource {
@@ -202,6 +206,10 @@ impl std::fmt::Display for RuleSource {
             Self::DenoLint(_) => write!(f, "deno-lint"),
             Self::EslintVitest(_) => write!(f, "@vitest/eslint-plugin"),
             Self::EslintVueJs(_) => write!(f, "eslint-plugin-vue"),
+            Self::EslintPackageJson(_) => write!(f, "eslint-plugin-package-json"),
+            Self::EslintPackageJsonDependencies(_) => {
+                write!(f, "eslint-plugin-package-json-dependencies")
+            }
         }
     }
 }
@@ -278,7 +286,9 @@ impl RuleSource {
             | Self::Stylelint(rule_name)
             | Self::DenoLint(rule_name)
             | Self::EslintVitest(rule_name)
-            | Self::EslintVueJs(rule_name) => rule_name,
+            | Self::EslintVueJs(rule_name)
+            | Self::EslintPackageJson(rule_name)
+            | Self::EslintPackageJsonDependencies(rule_name) => rule_name,
         }
     }
 
@@ -317,6 +327,10 @@ impl RuleSource {
             Self::DenoLint(rule_name) => format!("deno-lint/{rule_name}"),
             Self::EslintVitest(rule_name) => format!("vitest/{rule_name}"),
             Self::EslintVueJs(rule_name) => format!("vue/{rule_name}"),
+            Self::EslintPackageJson(rule_name) => format!("package-json/{rule_name}"),
+            Self::EslintPackageJsonDependencies(rule_name) => {
+                format!("package-json-dependencies/{rule_name}")
+            }
         }
     }
 
@@ -354,6 +368,8 @@ impl RuleSource {
             Self::DenoLint(rule_name) => format!("https://lint.deno.land/rules/{rule_name}"),
             Self::EslintVitest(rule_name) => format!("https://github.com/vitest-dev/eslint-plugin-vitest/blob/main/docs/rules/{rule_name}.md"),
             Self::EslintVueJs(rule_name) => format!("https://eslint.vuejs.org/rules/{rule_name}"),
+            Self::EslintPackageJson(rule_name) => format!("https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/blob/main/docs/rules/{rule_name}.md"),
+            Self::EslintPackageJsonDependencies(rule_name) => format!("https://github.com/idan-at/eslint-plugin-package-json-dependencies/blob/master/docs/rules/{rule_name}.md"),
         }
     }
 

crates/biome_cli/src/execute/migrate/eslint_any_rule_to_biome.rs

@@ -311,6 +311,7 @@ define_categories! {
     "lint/suspicious/noDuplicateCase": "https://biomejs.dev/linter/rules/no-duplicate-case",
     "lint/suspicious/noDuplicateClassMembers": "https://biomejs.dev/linter/rules/no-duplicate-class-members",
     "lint/suspicious/noDuplicateCustomProperties": "https://biomejs.dev/linter/rules/no-duplicate-custom-properties",
+    "lint/nursery/noDuplicateDependencies": "https://biomejs.dev/linter/rules/no-duplicate-dependencies",
     "lint/suspicious/noDuplicateElseIf": "https://biomejs.dev/linter/rules/no-duplicate-else-if",
     "lint/suspicious/noDuplicateFields": "https://biomejs.dev/linter/rules/no-duplicate-fields",
     "lint/suspicious/noDuplicateFontNames": "https://biomejs.dev/linter/rules/no-font-family-duplicate-names",

crates/biome_configuration/src/analyzer/linter/rules.rs

@@ -2,5 +2,6 @@
 
 //! Generated file, do not edit by hand, see `xtask/codegen`
 
+pub mod nursery;
 pub mod suspicious;
-::biome_analyze::declare_category! { pub Lint { kind : Lint , groups : [self :: suspicious :: Suspicious ,] } }
+::biome_analyze::declare_category! { pub Lint { kind : Lint , groups : [self :: nursery :: Nursery , self :: suspicious :: Suspicious ,] } }

crates/biome_diagnostics_categories/src/categories.rs

@@ -0,0 +1,7 @@
+//! Generated file, do not edit by hand, see `xtask/codegen`
+
+//! Generated file, do not edit by hand, see `xtask/codegen`
+
+use biome_analyze::declare_lint_group;
+pub mod no_duplicate_dependencies;
+declare_lint_group! { pub Nursery { name : "nursery" , rules : [self :: no_duplicate_dependencies :: NoDuplicateDependencies ,] } }