Skip to content

Commit f7e1403

Browse files
committed
switch to cljs-oops
1 parent 7003aa8 commit f7e1403

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

58 files changed

+122
-128
lines changed

project.clj

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
[org.clojure/tools.logging "0.3.1"]
1414
[org.clojure/tools.cli "0.3.5"]
1515
[org.clojure/tools.nrepl "0.2.12"]
16+
[binaryage/oops "0.2.0"]
1617
[http-kit "2.2.0"]
1718
[clj-logging-config "1.9.12"]
1819
[version-clj "0.1.2"]
@@ -22,7 +23,7 @@
2223

2324
; we cannot use :dependencies under individual profiles because Cursive recognizes only root level
2425
; thus we mark extra deps with :scope "test" and filter them later when producing jar library
25-
[binaryage/chromex "0.4.2" :scope "test"]
26+
[binaryage/chromex "0.5.0" :scope "test"]
2627
[binaryage/devtools "0.8.2" :scope "test"]
2728
[cljs-http "0.1.41" :scope "test"]
2829
[figwheel "0.5.7" :scope "test"]

src/automation/dirac/automation.cljs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"
1111
(:require-macros [cljs.core.async.macros :refer [go go-loop]])
1212
(:require [cljs.core.async :refer [put! <! chan timeout alts! close!]]
13-
[chromex.support :refer-macros [oget oset ocall oapply]]
13+
[oops.core :refer [oget oset! ocall oapply]]
1414
[chromex.logging :refer-macros [log error]]
1515
[dirac.automation.machinery :as machinery]
1616
[dirac.automation.helpers :as helpers]

src/automation/dirac/automation/devtools.cljs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
(ns dirac.automation.devtools
22
(:require-macros [cljs.core.async.macros :refer [go go-loop]])
33
(:require [cljs.core.async :refer [put! <! chan timeout alts! close!]]
4-
[chromex.support :refer-macros [oget oset ocall oapply]]
4+
[oops.core :refer [oget oset! ocall oapply]]
55
[chromex.logging :refer-macros [log warn error info]]
66
[devtools.core :as devtools]
77
[devtools.prefs :as devtools-prefs]))

src/automation/dirac/automation/feedback.cljs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
(ns dirac.automation.feedback
22
(:require-macros [cljs.core.async.macros :refer [go go-loop]])
33
(:require [cljs.core.async :refer [put! <! chan timeout alts! close!]]
4-
[chromex.support :refer-macros [oget oset ocall oapply]]
4+
[oops.core :refer [oget oset! ocall oapply]]
55
[chromex.logging :refer-macros [log warn]]
66
[dirac.automation.messages :as messages]
77
[dirac.automation.transcript-host :as transcript-host]))
@@ -30,11 +30,11 @@
3030
; -- message processing -----------------------------------------------------------------------------------------------------
3131

3232
(defn process-event! [event]
33-
(if-let [data (oget event "data")]
34-
(case (oget data "type")
33+
(if-let [data (oget event "?data")]
34+
(case (oget data "?type")
3535
"feedback-from-devtools" (append-to-transcript! "devtools" (oget data "transcript") (oget data "devtools"))
3636
"feedback-from-extension" (append-to-transcript! "extension" (oget data "transcript"))
37-
"feedback-from-scenario" (append-to-transcript! (or (oget data "label") "scenario") (oget data "transcript"))
37+
"feedback-from-scenario" (append-to-transcript! (or (oget data "?label") "scenario") (oget data "transcript"))
3838
nil)))
3939

4040
(defn start-processing-messages! []

src/automation/dirac/automation/helpers.cljs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
(ns dirac.automation.helpers
22
(:require-macros [cljs.core.async.macros :refer [go go-loop]])
33
(:require [cljs.core.async :refer [put! <! chan timeout alts! close!]]
4-
[chromex.support :refer-macros [oget oset ocall oapply]]
4+
[oops.core :refer [oget oset! ocall oapply]]
55
[cuerdas.core :as cuerdas])
66
(:import goog.Uri))
77

src/automation/dirac/automation/launcher.cljs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,16 @@
22
(:require-macros [cljs.core.async.macros :refer [go go-loop]])
33
(:require [cljs.core.async :refer [put! <! chan timeout alts! close!]]
44
[goog.string :as string]
5-
[chromex.support :refer-macros [oget oset ocall oapply]]
5+
[oops.core :refer [oget oset! oset!+ ocall ocall+ oapply]]
66
[chromex.logging :refer-macros [log warn error info]]
77
[dirac.settings :refer-macros [get-launch-task-key get-launch-task-message]]))
88

99
(defn register-task! [task-fn]
10-
(oset js/window [(get-launch-task-key)] task-fn))
10+
(oset!+ js/window (str "!" (get-launch-task-key)) task-fn))
1111

1212
(defn launch-task! []
1313
(log "launching task...")
14-
(ocall js/window (get-launch-task-key))) ; see go-task
14+
(ocall+ js/window (get-launch-task-key))) ; see go-task
1515

1616
(defn launch-task-after-delay! [delay-ms]
1717
(log "scheduled task launch after " delay-ms "ms...")
@@ -21,9 +21,9 @@
2121
(launch-task!)))
2222

2323
(defn process-event! [event]
24-
(if-let [data (oget event "data")]
25-
(if (= (oget data "type") (get-launch-task-message))
26-
(launch-task-after-delay! (string/parseInt (oget data "delay"))))))
24+
(if-let [data (oget event "?data")]
25+
(if (= (oget data "?type") (get-launch-task-message))
26+
(launch-task-after-delay! (string/parseInt (oget data "?delay"))))))
2727

2828
(defn init! []
2929
(.addEventListener js/window "message" process-event!))

src/automation/dirac/automation/machinery.cljs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
(ns dirac.automation.machinery
22
(:require-macros [cljs.core.async.macros :refer [go go-loop]])
33
(:require [cljs.core.async :refer [put! <! chan timeout alts! close!]]
4-
[chromex.support :refer-macros [oget oset ocall oapply]]
4+
[oops.core :refer [oget oset! ocall oapply]]
55
[chromex.logging :refer-macros [log error]]
66
[dirac.automation.task :as task]
77
[dirac.automation.transcript-host :as transcript]

src/automation/dirac/automation/messages.cljs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
(:require [cljs.core.async :refer [put! <! chan timeout alts! close!]]
44
[cljs.reader :as reader]
55
[clojure.string :as str]
6-
[chromex.support :refer-macros [oget oset ocall oapply]]
6+
[oops.core :refer [oget oset! ocall oapply]]
77
[chromex.logging :refer-macros [log info warn error]]
88
[dirac.settings :refer-macros [get-marion-message-reply-timeout]]
99
[dirac.utils :as utils]))
@@ -98,7 +98,7 @@
9898
; see https://developer.chrome.com/extensions/content_scripts#host-page-communication
9999
(defn post-message-with-timeout! [js-message reply-timeout]
100100
(let [message-id (get-next-message-id!)]
101-
(oset js-message ["id"] message-id)
101+
(oset! js-message "!id" message-id)
102102
(let [post-message! #(.postMessage js/window js-message "*")]
103103
(if (or (nil? reply-timeout) (= :no-timeout reply-timeout))
104104
(go
@@ -176,8 +176,8 @@
176176
; -- message processing -----------------------------------------------------------------------------------------------------
177177

178178
(defn process-event! [event]
179-
(if-let [data (oget event "data")]
180-
(case (oget data "type")
179+
(if-let [data (oget event "?data")]
180+
(case (oget data "?type")
181181
"reply" (process-reply! data)
182182
nil)))
183183

src/automation/dirac/automation/notifications.cljs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
(ns dirac.automation.notifications
22
(:require-macros [cljs.core.async.macros :refer [go go-loop]])
33
(:require [cljs.core.async :refer [put! <! chan timeout alts! close!]]
4-
[chromex.support :refer-macros [oget oset ocall oapply]]
4+
[oops.core :refer [oget oset! ocall oapply]]
55
[chromex.logging :refer-macros [log warn]]
66
[dirac.automation.messages :as messages]
77
[cljs.reader :as reader]))

src/automation/dirac/automation/runner.cljs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
(ns dirac.automation.runner
22
(:require-macros [cljs.core.async.macros :refer [go go-loop]])
33
(:require [cljs.core.async :refer [put! <! chan timeout alts! close!]]
4-
[chromex.support :refer-macros [oget oset ocall oapply]]
4+
[oops.core :refer [oget oset! ocall oapply]]
55
[chromex.logging :refer-macros [log warn error info]]
66
[devtools.preload]
77
[dirac.automation.helpers :as helpers]
@@ -16,10 +16,10 @@
1616
(helpers/get-el-by-id "resume-button"))
1717

1818
(defn enable-resume! []
19-
(oset (get-resume-button-el) ["disabled"] false))
19+
(oset! (get-resume-button-el) "disabled" false))
2020

2121
(defn disable-resume! []
22-
(oset (get-resume-button-el) ["disabled"] true))
22+
(oset! (get-resume-button-el) "disabled" true))
2323

2424
(defn wait-for-resume! []
2525
(go

0 commit comments

Comments
 (0)