Merge pull request #505 from bilal-fazlani/nullable-class-constraint

breaK with ExitCodes Async rename. change to `T:class?` constraint for nulls

Author: drewburlingame

CommandDotNet.DataAnnotations/DataAnnotationsMiddleware.cs

@@ -62,7 +62,7 @@ private static Task<int> DataAnnotationsValidation(CommandContext ctx, Execution
                     console.Error.WriteLine();
                 }
 
-                return ExitCodes.ValidationError;
+                return ExitCodes.ValidationErrorAsync;
             }
 
             return next(ctx);

CommandDotNet.DocExamples/Diagnostics/Exceptions.cs

@@ -34,7 +34,7 @@ private static int ErrorHandler(CommandContext? ctx, Exception exception)
                     // if the exception occurred before a command could be parsed
                     ctx?.PrintHelp();
 
-                    return ExitCodes.Error.Result;
+                    return ExitCodes.ErrorAsync.Result;
                 }
 
                 public void Throw(string message)
@@ -64,7 +64,7 @@ static int Main(string[] args)
                         .UseErrorHandler((ctx, ex) =>
                         {
                             (ctx?.Console.Error ?? Console.Error).WriteLine(ex.Message);
-                            return ExitCodes.Error.Result;
+                            return ExitCodes.ErrorAsync.Result;
                         })
                         .Run(args);
                 }
@@ -97,7 +97,7 @@ static int Main(string[] args)
                     catch (Exception ex)
                     {
                         Console.Error.WriteLine(ex.Message);
-                        return ExitCodes.Error.Result;
+                        return ExitCodes.ErrorAsync.Result;
                     }
                 }
                 // end-snippet
@@ -146,7 +146,7 @@ private static int ErrorHandler(CommandContext? ctx, Exception exception)
                     // if the exception occurred before a command could be parsed
                     ctx?.PrintHelp();
 
-                    return ExitCodes.Error.Result;
+                    return ExitCodes.ErrorAsync.Result;
                 }
 
                 public void Throw(string message)

CommandDotNet.Example/Commands/Prompts.cs

@@ -27,14 +27,14 @@ public Task<int> Intercept(InterceptorExecutionDelegate next,
                 if (username == null)
                 {
                     console.Out.WriteLine("username not provided");
-                    return ExitCodes.Error;
+                    return ExitCodes.ErrorAsync;
                 }
 
                 var pwd = password?.GetPassword();
                 if (string.IsNullOrWhiteSpace(pwd))
                 {
                     console.Out.WriteLine("password not provided");
-                    return ExitCodes.Error;
+                    return ExitCodes.ErrorAsync;
                 }
 
                 console.Out.WriteLine($"authenticated as user:{username} with password:{password}  (actual password:{pwd})");

CommandDotNet.FluentValidation/FluentValidationMiddleware.cs

@@ -99,13 +99,13 @@ private static Task<int> FluentValidationForModels(CommandContext ctx, Execution
                         console.Error.WriteLine();
                     }
 
-                    return ExitCodes.ValidationError;
+                    return ExitCodes.ValidationErrorAsync;
                 }
             }
             catch (InvalidValidatorException e)
             {
                 ctx.Console.Error.WriteLine(e.ToString());
-                return ExitCodes.Error;
+                return ExitCodes.ErrorAsync;
             }
 
             return next(ctx);

CommandDotNet.NewerReleasesAlerts/AlertOnNewerReleaseMiddleware.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Diagnostics.CodeAnalysis;
 using System.Net.Http;
 using System.Threading.Tasks;
 using CommandDotNet.Builders;
@@ -99,10 +100,8 @@ private static Task<int> AlertOnNewVersion(CommandContext context, ExecutionDele
             return next(context);
         }
 
-        private static bool TryGetCurrentVersion(out SemVersion semVersion)
-        {
-            return SemVersion.TryParse(AppInfo.Instance.Version, out semVersion);
-        }
+        private static bool TryGetCurrentVersion([NotNullWhen(true)] out SemVersion? semVersion) => 
+            SemVersion.TryParse(AppInfo.Instance.Version, out semVersion);
 
         private static bool TryGetLatestReleaseVersion(CommandContext context, NewerReleaseConfig config, out SemVersion? semVersion)
         {

CommandDotNet.TestTools/AppRunnerTestExtensions.cs

@@ -25,7 +25,7 @@ public static AppRunner CaptureState(this AppRunner runner, Action<CommandContex
             {
                 capture(context);
                 return exitAfterCapture 
-                    ? ExitCodes.Success
+                    ? ExitCodes.SuccessAsync
                     : next(context);
             }, middlewareStage, orderWithinStage));
         }

CommandDotNet.TestTools/AssertFailedException.cs

@@ -4,16 +4,5 @@
 namespace CommandDotNet.TestTools
 {
     [Serializable]
-    public class AssertFailedException : Exception
-    {
-        public AssertFailedException(string message)
-            : base(message)
-        {
-        }
-
-        protected AssertFailedException(SerializationInfo info, StreamingContext context)
-            : base(info, context)
-        {
-        }
-    }
+    public class AssertFailedException(string message) : Exception(message);
 }

CommandDotNet.TestTools/InvocationInfo.cs

@@ -6,14 +6,11 @@
 
 namespace CommandDotNet.TestTools
 {
-    public class InvocationInfo<T> : InvocationInfo where T: class
+    public class InvocationInfo<T>(CommandContext commandContext, InvocationStep invocationStep)
+        : InvocationInfo(commandContext, invocationStep)
+        where T : class
     {
         public new T? Instance => (T?)base.Instance;
-
-        public InvocationInfo(CommandContext commandContext, InvocationStep invocationStep)
-            : base(commandContext, invocationStep)
-        {
-        }
     }
 
     public class InvocationInfo

CommandDotNet.TestTools/TestDependencyResolver.cs

@@ -33,12 +33,12 @@ public void Add(object service)
             _services.Add(service.GetType(), service);
         }
 
-        public void Add<T>(T? service) where T: class
+        public void Add<T>(T? service) where T: class?
         {
             _services.Add(typeof(T), service);
         }
 
-        public void AddOrUpdate<T>(T? service) where T : class
+        public void AddOrUpdate<T>(T? service) where T : class?
         {
             _services[typeof(T)] = service;
         }

CommandDotNet.TestTools/TrackingInvocation.cs

@@ -5,26 +5,21 @@
 
 namespace CommandDotNet.TestTools
 {
-    internal class TrackingInvocation : IInvocation
+    internal class TrackingInvocation(IInvocation backingInvocation) : IInvocation
     {
-        private readonly IInvocation _backingInvocation;
+        private readonly IInvocation _backingInvocation = backingInvocation ?? throw new ArgumentNullException(nameof(backingInvocation));
 
         public bool WasInvoked { get; private set; }
         public bool Errored => InvocationError != null;
         public Exception? InvocationError { get; private set; }
 
         public IReadOnlyCollection<IArgument> Arguments => _backingInvocation.Arguments;
         public IReadOnlyCollection<ParameterInfo> Parameters => _backingInvocation.Parameters;
-        public object[] ParameterValues => _backingInvocation.ParameterValues;
+        public object?[] ParameterValues => _backingInvocation.ParameterValues;
         public MethodInfo MethodInfo => _backingInvocation.MethodInfo;
         public bool IsInterceptor => _backingInvocation.IsInterceptor;
         public IReadOnlyCollection<IArgumentModel> FlattenedArgumentModels => _backingInvocation.FlattenedArgumentModels;
 
-        public TrackingInvocation(IInvocation backingInvocation)
-        {
-            _backingInvocation = backingInvocation ?? throw new ArgumentNullException(nameof(backingInvocation));
-        }
-
         public object? Invoke(CommandContext commandContext, object instance, ExecutionDelegate next)
         {
             WasInvoked = true;