lints

Author: epompeii

Cargo.lock

@@ -1,13 +1,12 @@
 use bencher_endpoint::{CorsResponse, Endpoint, Get, Post, ResponseAccepted};
-use bencher_json::{system::auth::JsonAccept, JsonAuthAck};
+use bencher_json::{JsonAuthAck, system::auth::JsonAccept};
 use bencher_schema::{
     conn_lock,
     context::ApiContext,
     model::user::auth::{AuthUser, BearerToken},
 };
-use dropshot::{endpoint, HttpError, RequestContext, TypedBody};
+use dropshot::{HttpError, RequestContext, TypedBody, endpoint};
 
-#[expect(clippy::no_effect_underscore_binding, clippy::unused_async)]
 #[endpoint {
     method = OPTIONS,
     path =  "/v0/auth/accept",

lib/api_auth/src/accept.rs

@@ -1,16 +1,15 @@
 use bencher_endpoint::{CorsResponse, Endpoint, Post, ResponseOk};
-use bencher_json::{system::auth::JsonAuthUser, JsonConfirm};
+use bencher_json::{JsonConfirm, system::auth::JsonAuthUser};
 use bencher_schema::{
     conn_lock,
     context::ApiContext,
     error::{issue_error, unauthorized_error},
     model::user::QueryUser,
 };
-use dropshot::{endpoint, HttpError, RequestContext, TypedBody};
+use dropshot::{HttpError, RequestContext, TypedBody, endpoint};
 
 use super::CLIENT_TOKEN_TTL;
 
-#[expect(clippy::no_effect_underscore_binding, clippy::unused_async)]
 #[endpoint {
     method = OPTIONS,
     path =  "/v0/auth/confirm",

lib/api_auth/src/confirm.rs

@@ -1,24 +1,23 @@
 #![cfg(feature = "plus")]
 
 use bencher_endpoint::{CorsResponse, Endpoint, Get, Post, ResponseAccepted};
-use bencher_json::{system::auth::JsonOAuth, JsonAuthUser, JsonSignup, PlanLevel};
+use bencher_json::{JsonAuthUser, JsonSignup, PlanLevel, system::auth::JsonOAuth};
 use bencher_schema::{
     conn_lock,
     context::ApiContext,
     error::{issue_error, payment_required_error, unauthorized_error},
     model::{
-        organization::{plan::LicenseUsage, QueryOrganization},
+        organization::{QueryOrganization, plan::LicenseUsage},
         user::{InsertUser, QueryUser},
     },
 };
-use dropshot::{endpoint, HttpError, RequestContext, TypedBody};
+use dropshot::{HttpError, RequestContext, TypedBody, endpoint};
 use slog::Logger;
 
 use super::CLIENT_TOKEN_TTL;
 
 pub const GITHUB_OAUTH2: &str = "GitHub OAuth2";
 
-#[expect(clippy::no_effect_underscore_binding, clippy::unused_async)]
 #[endpoint {
     method = OPTIONS,
     path =  "/v0/auth/github",
@@ -64,8 +63,8 @@ async fn post_inner(
         .is_empty()
     {
         return Err(payment_required_error(
-                "You must have a valid Bencher Plus Enterprise license for at least one organization on the server to use GitHub OAuth2",
-            ));
+            "You must have a valid Bencher Plus Enterprise license for at least one organization on the server to use GitHub OAuth2",
+        ));
     }
 
     let (name, email) = github

lib/api_auth/src/github.rs

@@ -6,13 +6,12 @@ use bencher_schema::{
     error::issue_error,
     model::user::QueryUser,
 };
-use dropshot::{endpoint, HttpError, RequestContext, TypedBody};
+use dropshot::{HttpError, RequestContext, TypedBody, endpoint};
 use slog::Logger;
 
 use super::AUTH_TOKEN_TTL;
 use super::TOKEN_ARG;
 
-#[expect(clippy::no_effect_underscore_binding, clippy::unused_async)]
 #[endpoint {
     method = OPTIONS,
     path =  "/v0/auth/login",

lib/api_auth/src/login.rs

@@ -1,18 +1,17 @@
 use bencher_endpoint::{CorsResponse, Endpoint, Post, ResponseAccepted};
-use bencher_json::{system::auth::JsonAuthAck, JsonSignup};
+use bencher_json::{JsonSignup, system::auth::JsonAuthAck};
 use bencher_schema::{
     conn_lock,
     context::{ApiContext, Body, ButtonBody, Message},
     error::{forbidden_error, issue_error},
     model::user::InsertUser,
 };
-use dropshot::{endpoint, HttpError, RequestContext, TypedBody};
+use dropshot::{HttpError, RequestContext, TypedBody, endpoint};
 use slog::Logger;
 
 use super::AUTH_TOKEN_TTL;
 use super::TOKEN_ARG;
 
-#[expect(clippy::no_effect_underscore_binding, clippy::unused_async)]
 #[endpoint {
     method = OPTIONS,
     path =  "/v0/auth/signup",

lib/api_auth/src/signup.rs

@@ -15,9 +15,8 @@ use bencher_schema::{
         user::auth::{AuthUser, BearerToken},
     },
 };
-use dropshot::{endpoint, HttpError, RequestContext, TypedBody};
+use dropshot::{HttpError, RequestContext, TypedBody, endpoint};
 
-#[expect(clippy::no_effect_underscore_binding, clippy::unused_async)]
 #[endpoint {
     method = OPTIONS,
     path =  "/v0/checkout",

lib/api_checkout/src/checkout.rs

@@ -1,14 +1,14 @@
 use bencher_endpoint::{CorsResponse, Endpoint, Get, ResponseOk};
-use bencher_json::{organization::OrganizationPermission, JsonAllowed, ResourceId};
+use bencher_json::{JsonAllowed, ResourceId, organization::OrganizationPermission};
 use bencher_schema::{
     conn_lock,
     context::ApiContext,
     model::{
-        organization::{organization_role::Permission, QueryOrganization},
+        organization::{QueryOrganization, organization_role::Permission},
         user::auth::{AuthUser, BearerToken},
     },
 };
-use dropshot::{endpoint, HttpError, Path, RequestContext};
+use dropshot::{HttpError, Path, RequestContext, endpoint};
 use schemars::JsonSchema;
 use serde::Deserialize;
 
@@ -20,7 +20,6 @@ pub struct OrgAllowedParams {
     pub permission: OrganizationPermission,
 }
 
-#[expect(clippy::no_effect_underscore_binding, clippy::unused_async)]
 #[endpoint {
     method = OPTIONS,
     path =  "/v0/organizations/{organization}/allowed/{permission}",

lib/api_organizations/src/allowed.rs

@@ -8,7 +8,7 @@ use bencher_schema::{
         user::auth::{AuthUser, BearerToken},
     },
 };
-use dropshot::{endpoint, HttpError, Path, RequestContext, TypedBody};
+use dropshot::{HttpError, Path, RequestContext, TypedBody, endpoint};
 use schemars::JsonSchema;
 use serde::Deserialize;
 
@@ -18,7 +18,6 @@ pub struct OrgClaimParams {
     pub organization: ResourceId,
 }
 
-#[expect(clippy::no_effect_underscore_binding, clippy::unused_async)]
 #[endpoint {
     method = OPTIONS,
     path =  "/v0/organizations/{organization}/claim",

lib/api_organizations/src/claim.rs

@@ -3,28 +3,29 @@ use bencher_endpoint::{
     ResponseOk, TotalCount,
 };
 use bencher_json::{
-    organization::member::{JsonNewMember, JsonUpdateMember},
     JsonAuthAck, JsonDirection, JsonMember, JsonMembers, JsonPagination, ResourceId, Search,
     UserName,
+    organization::member::{JsonNewMember, JsonUpdateMember},
 };
 use bencher_rbac::organization::Permission;
 use bencher_schema::{
-    conn_lock,
+    INVITE_TOKEN_TTL, conn_lock,
     context::{ApiContext, Body, ButtonBody, DbConnection, Message},
     error::{forbidden_error, issue_error, resource_conflict_err, resource_not_found_err},
     model::{
-        organization::{member::QueryMember, OrganizationId, QueryOrganization},
+        organization::{OrganizationId, QueryOrganization, member::QueryMember},
         user::{
-            auth::{AuthUser, BearerToken},
             QueryUser, UserId,
+            auth::{AuthUser, BearerToken},
         },
     },
-    schema, INVITE_TOKEN_TTL,
+    schema,
 };
 use diesel::{
-    BoolExpressionMethods as _, ExpressionMethods as _, QueryDsl as _, RunQueryDsl as _, TextExpressionMethods as _,
+    BoolExpressionMethods as _, ExpressionMethods as _, QueryDsl as _, RunQueryDsl as _,
+    TextExpressionMethods as _,
 };
-use dropshot::{endpoint, HttpError, Path, Query, RequestContext, TypedBody};
+use dropshot::{HttpError, Path, Query, RequestContext, TypedBody, endpoint};
 use schemars::JsonSchema;
 use serde::Deserialize;
 use slog::Logger;
@@ -53,7 +54,6 @@ pub struct OrgMembersQuery {
     pub search: Option<Search>,
 }
 
-#[expect(clippy::no_effect_underscore_binding, clippy::unused_async)]
 #[endpoint {
     method = OPTIONS,
     path =  "/v0/organizations/{organization}/members",
@@ -280,7 +280,10 @@ async fn post_inner(
         title: format!("Invitation to join {org_name}"),
         preheader: "Click the provided link to join.".into(),
         greeting: if let Some(name) = name {
-            format!("Ahoy {name}!") } else { "Ahoy!".into() },
+            format!("Ahoy {name}!")
+        } else {
+            "Ahoy!".into()
+        },
         pre_body: format!(
             "Please, click the button below or use the provided token to accept the invitation from {user_name} ({user_email}) to join {org_name} as a {org_role} on Bencher.",
             user_name = auth_user.user.name,
@@ -327,7 +330,6 @@ pub struct OrgMemberParams {
     pub user: ResourceId,
 }
 
-#[expect(clippy::no_effect_underscore_binding, clippy::unused_async)]
 #[endpoint {
     method = OPTIONS,
     path =  "/v0/organizations/{organization}/members/{user}",