Skip to content

Fix CI and flaky tests #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arkgil merged 7 commits into from
Aug 24, 2023
Merged

Fix CI and flaky tests #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a1a294e
use setup-beams instead of setup-elixir
mopp Aug 15, 2023
8536349
run GitHub Actions on old ubuntu image to work
mopp Aug 15, 2023
7d37691
fix strategy.matrix
mopp Aug 15, 2023
db8eb0b
set strategy.fail-fast: true
mopp Aug 15, 2023
89ab955
fix flaky tests
mopp Aug 15, 2023
f6d6271
Revert "fix flaky tests"
mopp Aug 24, 2023
ad7e105
set pool_size: 1 to fix the flaky tests
mopp Aug 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 19 additions & 10 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ on:
jobs:
format:
name: Check formatting
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v2
- uses: erlef/setup-elixir@v1
- uses: erlef/setup-beam@v1
with:
otp-version: "24.0"
elixir-version: "1.12.0"
Expand All @@ -29,16 +29,21 @@ jobs:
deps-
- run: mix deps.get
- run: mix format --check-formatted

test:
name: Test on Elixir ${{ matrix.elixir }} (OTP ${{ matrix.otp }})
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
strategy:
fail-fast: false
matrix:
otp: ["22.3", "24.0"]
elixir: ["1.10.4", "1.12.0"]
include:
- otp: 22.3
elixir: 1.10.4
- otp: 24.0
elixir: 1.12.0
Comment on lines +39 to +43
Copy link
Contributor Author

@mopp mopp Aug 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to define pair to avoid the error below.

Error: Requested Elixir / Erlang/OTP version (1.10.4 / 24.0) not found in version list (did you check Compatibility between Elixir and Erlang/OTP?).Elixir and Erlang/OTP compatibility can be found at: https://hexdocs.pm/elixir/compatibility-and-deprecations.html

steps:
- uses: actions/checkout@v2
- uses: erlef/setup-elixir@v1
- uses: erlef/setup-beam@v1
with:
otp-version: ${{ matrix.otp }}
elixir-version: ${{ matrix.elixir }}
Expand All @@ -65,14 +70,18 @@ jobs:

dialyze:
name: Dialyze on Elixir ${{ matrix.elixir }} (OTP ${{ matrix.otp }})
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
strategy:
fail-fast: false
matrix:
otp: ["22.3", "24.0"]
elixir: ["1.10.4", "1.12.0"]
include:
- otp: 22.3
elixir: 1.10.4
- otp: 24.0
elixir: 1.12.0
steps:
- uses: actions/checkout@v2
- uses: erlef/setup-elixir@v1
- uses: erlef/setup-beam@v1
with:
otp-version: ${{ matrix.otp }}
elixir-version: ${{ matrix.elixir }}
Expand Down
4 changes: 2 additions & 2 deletions test/telemetry_metrics_statsd_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ defmodule TelemetryMetricsStatsdTest do

describe "UDP error handling" do
test "reporting a UDP error logs an error" do
reporter = start_reporter(metrics: [])
reporter = start_reporter(metrics: [], pool_size: 1)
pool_id = TelemetryMetricsStatsd.get_pool_id(reporter)
{:ok, udp} = TelemetryMetricsStatsd.get_udp(pool_id)

Expand All @@ -343,7 +343,7 @@ defmodule TelemetryMetricsStatsdTest do
end

test "reporting a UDP error for the same socket multiple times generates only one log" do
reporter = start_reporter(metrics: [])
reporter = start_reporter(metrics: [], pool_size: 1)
pool_id = TelemetryMetricsStatsd.get_pool_id(reporter)
{:ok, udp} = TelemetryMetricsStatsd.get_udp(pool_id)

Expand Down