get rid of solarized-theme.el from theme path

[thomasf]

It is detected as a theme by the custom theme system even if it isn't.

The solution is maybe move the actual themes into their own subdirectory?

[thomasf]

The only reason that that file is there seems to be to have a file with the same name as the melpa package (?).

So if we just remove this file the code below would probable stop working correctly.

(use-package solarized-theme
  :ensure t
  :defer)

[bbatsov]

The only reason that that file is there seems to be to have a file with the same name as the melpa package (?).

I think this can also be replaced with some package manifest file, but I never tried it. See https://www.gnu.org/software/emacs/manual/html_node/elisp/Multi_002dfile-Packages.html

For example, if we distribute version 1.3 of the superfrobnicator as a multi-file package, the tar file would be superfrobnicator-1.3.tar. Its contents would extract into the directory superfrobnicator-1.3, and one of these would be the file superfrobnicator-pkg.el.

Seems like a trivial change.

[jbromley]

It wasn't quite trivial, but it wasn't too bad. Here's what I did.

1. Renamed solarized.el to solarized-themes.el.
2. Moved headers from solarized-theme.el to solarized-themes.el.
3. Deleted solarized-theme.el.
4. Fixed all (require 'solarized) to (require 'solarized-themes)
5. Created a basic solarized-themes-pkg.el.

This allows the package solarized-themes to be loaded (note the package name change) without causing a solarized-theme theme to appear in theme lists. I initially tried keeping solarized.el in place of solarized-themes.el so the package name wouldn't have to change, but I couldn't get that version to load properly.

Anyway, if this sounds interesting to you I can make a pull request.