SolibSymlinkAction does not need exec platform or properties #14827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glukasiknuro
force-pushed
the
glukasik/solibsymlink-change-key
branch
from
f31157d to
9f6e52e
Compare
comius
requested review from
oquenchil
and removed request for
comius and
lberki
|
I'd like to suggest this should be a blocker for the 5.x series. It is a regression from 4.2, appears to have a viable fix ready, and the underlying issue doesn't seem to have a workaround. |
|
@bazel-io flag |
1 similar comment
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
|
@bazel-io fork 5.2.0 |
bazel-io
removed
the
potential release blocker
sgowroji
added
awaiting-review
meteorcloudy
added
the
awaiting-PR-merge
sgowroji
removed
the
awaiting-PR-merge
ckolli5
added a commit
that referenced
this pull request
May 12, 2022
#14826 Closes #14827. PiperOrigin-RevId: 447948011 Co-authored-by: Grzegorz Lukasik <[email protected]>
copybara-service bot
pushed a commit
that referenced
this pull request
Feb 9, 2023
Similar to #14827 When C++ toolchain is built for toolchains, exec platform is set and when it's built for `_cc_toolchain` implicit dependency it's not set. With this and in specific configuration `cc_toolchain` rule causes an action conflict. PiperOrigin-RevId: 508270931 Change-Id: I316f401f454fabc4e5e3d8d295e1bf633141e1af
hvadehra
pushed a commit
that referenced
this pull request
Feb 14, 2023
Similar to #14827 When C++ toolchain is built for toolchains, exec platform is set and when it's built for `_cc_toolchain` implicit dependency it's not set. With this and in specific configuration `cc_toolchain` rule causes an action conflict. PiperOrigin-RevId: 508270931 Change-Id: I316f401f454fabc4e5e3d8d295e1bf633141e1af
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#14826