Skip to content

Commit c7a406c

Browse files
aignasrickeylev
authored andcommitted
revert(pypi): revert the default for pipstar (#3373)
A user mentioned that flipping the pipstar default caused a regression in their setup in [this comment]. Until we have a better understanding and a regression test for that, we should revert the flip. Adjusted the CHANGELOG notes for this. Related to #2949 [this comment]: #2949 (comment) (cherry picked from commit 3c3e0be)
1 parent c2b7463 commit c7a406c

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

CHANGELOG.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,10 +74,10 @@ END_UNRELEASED_TEMPLATE
7474
* (toolchains) `py_runtime` and `PyRuntimeInfo` reject Python 2 settings.
7575
Setting `py_runtime.python_version = "PY2"` or non-None
7676
`PyRuntimeInfo.py2_runtime` is an error.
77-
* (pypi) `pipstar` flag has been flipped to be enabled by default, to turn it
78-
off use `RULES_PYTHON_ENABLE_PIPSTAR=0` environment variable. If you do, please
77+
* (pypi) `pipstar` flag has been implemented for `WORKSPACE` and can be flipped to be enabled using `RULES_PYTHON_ENABLE_PIPSTAR=1` environment variable. If you do, please
7978
add a comment to
80-
[#2949](https://github.com/bazel-contrib/rules_python/issues/2949).
79+
[#2949](https://github.com/bazel-contrib/rules_python/issues/2949) if you run into any
80+
problems.
8181
With this release we are deprecating {obj}`pip.parse.experimental_target_platforms` and
8282
{obj}`pip_repository.experimental_target_platforms`. For users using `WORKSPACE` and
8383
vendoring the `requirements.bzl` file, please re-vendor so that downstream is unaffected

python/private/internal_config_repo.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ load("//python/private:text_util.bzl", "render")
2222
load(":repo_utils.bzl", "repo_utils")
2323

2424
_ENABLE_PIPSTAR_ENVVAR_NAME = "RULES_PYTHON_ENABLE_PIPSTAR"
25-
_ENABLE_PIPSTAR_DEFAULT = "1"
25+
_ENABLE_PIPSTAR_DEFAULT = "0"
2626
_ENABLE_DEPRECATION_WARNINGS_ENVVAR_NAME = "RULES_PYTHON_DEPRECATION_WARNINGS"
2727
_ENABLE_DEPRECATION_WARNINGS_DEFAULT = "0"
2828

0 commit comments

Comments
 (0)