Skip to content

Commit 0b5d9da

Browse files
authored
Update protobuf to 29.3 (bzlmod only) (#1314)
Co-authored-by: João Guerra <[email protected]>
1 parent 851676d commit 0b5d9da

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

MODULE.bazel

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -149,12 +149,15 @@ http_file(
149149

150150
bazel_dep(
151151
name = "protobuf",
152-
# Note: we use 27.2 in MODULE.bazel to avoid the warning:
153-
# The maven repository 'maven' is used in two different bazel modules, originally in 'rules_jvm_external' and now in 'protobuf'
154-
# But we use 21.7 in WORKSPACE because protobuf 27.2 doesn't work with Bazel 5.x
152+
# Note: In MODULE.bazel, we use a version >= 29.1 to avoid polluting the
153+
# default maven repo name with protobuf's dependencies.
154+
# https://github.com/protocolbuffers/protobuf/pull/19477
155+
# However, in WORKSPACE, we use version 21.7 since version 27.2 doesn't work
156+
# with Bazel 5.x.
155157
# https://github.com/protocolbuffers/protobuf/commit/a80daa2a2caaaac9ebe9ae6bb1b639c2771c5c55
156-
# This should be ok because we only use the protobuf dep to pull in the google/protobuf/wrappers.proto for testing
157-
version = "27.2",
158+
# This should be ok because we only use protobuf to pull in the google/protobuf/wrappers.proto
159+
# for testing.
160+
version = "29.3",
158161
dev_dependency = True,
159162
)
160163
bazel_dep(

0 commit comments

Comments
 (0)