Set memory baseline on MemoryCollector #1467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 28, 2023
|
hi @barryvdh, could you check this?, thanks |
|
Why is this not being merged? |
|
I'm not really sure on the use case here, but okay. |
barryvdh
approved these changes
Feb 8, 2024
|
@barryvdh sorry for the misunderstanding, I didn't mean to rush you but... this is not related to php-debugbar/php-debugbar#559 ? |
|
Yeah I understand that, but I'm not really sure if this is the best way. It feels a bit weird that it's excluding the bootstrap. But for Octane etc I do understand why you would need to reset the usage. But not really sure why the memory is so different. I'd rather just 'have it work' correctly without config, but not sure. If Linux or windows reservers more memory, it would be sufficient to use the 'real' usage instead of the allocated usage? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1434
Complements of php-debugbar/php-debugbar#559