Bal 4370 flaky plugin rerun during submission in edit (#3428)

* fix: fixed issue where edit status was updated to in progress (#3427)

* feat: reworked final submission & added plugins output cleanup

* fix: fixed types

Author: chesterkmr

services/workflows-service/src/collection-flow/controllers/collection-flow.controller.ts

@@ -19,6 +19,7 @@ import {
   AnyRecord,
   CollectionFlowStatusesEnum,
   CollectionFlowStepStatesEnum,
+  DefaultContextSchema,
   TCollectionFlowState,
   TCollectionFlowStep,
 } from '@ballerine/common';
@@ -157,38 +158,53 @@ export class CollectionFlowController {
   @common.Post('/final-submission')
   async finalSubmission(@TokenScope() tokenScope: ITokenScope, @common.Body() body: FinishFlowDto) {
     try {
-      await this.collectionFlowStateService.updateCollectionFlowState(
+      const { eventName, context } = body;
+
+      const collectionFlowState = (context.collectionFlow as AnyRecord)
+        .state as TCollectionFlowState;
+
+      if (collectionFlowState?.status === CollectionFlowStatusesEnum.edit) {
+        const pluginsOutput = this.collectionFlowService.removePluginsOutput({
+          context: context as DefaultContextSchema,
+          plugins: [
+            'businessInformation',
+            'companySanctions',
+            'merchantScreening',
+            'merchantMonitoring',
+            'riskEvaluation',
+          ],
+        });
+
+        context.pluginsOutput = pluginsOutput;
+      }
+
+      await this.workflowService.updateWorkflowRuntimeData(
         tokenScope.workflowRuntimeDataId,
         {
-          ...((body.context.collectionFlow as AnyRecord).state as TCollectionFlowState),
-          steps: (
-            (body.context.collectionFlow as AnyRecord).state as TCollectionFlowState
-          ).steps.map((step: TCollectionFlowStep) => ({
-            ...step,
-            state: CollectionFlowStepStatesEnum.completed,
-          })),
-          status: CollectionFlowStatusesEnum.completed,
+          context,
         },
-        [tokenScope.projectId],
+        tokenScope.projectId,
       );
 
-      await this.workflowService.event(
+      await this.collectionFlowStateService.updateCollectionFlowState(
+        tokenScope.workflowRuntimeDataId,
         {
-          id: tokenScope.workflowRuntimeDataId,
-          name: body.eventName,
+          ...((context.collectionFlow as AnyRecord).state as TCollectionFlowState),
+          steps: ((context.collectionFlow as AnyRecord).state as TCollectionFlowState).steps.map(
+            (step: TCollectionFlowStep) => ({
+              ...step,
+              state: CollectionFlowStepStatesEnum.completed,
+            }),
+          ),
+          status: CollectionFlowStatusesEnum.completed,
         },
         [tokenScope.projectId],
-        tokenScope.projectId,
       );
 
       return this.workflowService.event(
         {
           id: tokenScope.workflowRuntimeDataId,
-          name: BUILT_IN_EVENT.DEEP_MERGE_CONTEXT,
-          payload: {
-            newContext: body.context,
-            arrayMergeOption: ARRAY_MERGE_OPTION.REPLACE,
-          },
+          name: eventName,
         },
         [tokenScope.projectId],
         tokenScope.projectId,

services/workflows-service/src/collection-flow/services/collection-flow.service.ts

@@ -227,4 +227,14 @@ export class CollectionFlowService {
       { shouldDownloadFromSource: false },
     );
   }
+
+  removePluginsOutput({ context, plugins }: { context: DefaultContextSchema; plugins: string[] }) {
+    const pluginsOutput = structuredClone(context.pluginsOutput || {});
+
+    plugins.forEach(pluginName => {
+      delete pluginsOutput[pluginName as keyof typeof pluginsOutput];
+    });
+
+    return pluginsOutput;
+  }
 }