Remove invalid validation (#3)

Author: TharmiganK

README.md

@@ -76,9 +76,10 @@ public type StoreListenerConfiguration record {|
     # The interval in seconds between retries for processing a message
     decimal retryInterval = 1;
     # If true, the message will be acknowledged with a failure after the maximum number of retries.
-    boolean ackWithFailureAfterMaxRetries = false;
+    # Else the message will be acknowledged with success
+    boolean ackWithFailureAfterMaxRetries = true;
     # An optional message store to store messages that could not be processed after the maximum 
-    # number of retries. When set, `ackWithFailureAfterMaxRetries` will be ignored
+    # number of retries. On successful storage, the message will be acknowledged with success
     Store deadLetterStore?;
 |};
 ```

ballerina/README.md

@@ -74,9 +74,10 @@ public type StoreListenerConfiguration record {|
     # The interval in seconds between retries for processing a message
     decimal retryInterval = 1;
     # If true, the message will be acknowledged as failed after the maximum number of retries.
-    boolean ackWithFailureAfterMaxRetries = false;
+    # Else the message will be acknowledged with success
+    boolean ackWithFailureAfterMaxRetries = true;
     # An optional message store to store messages that could not be processed after the maximum 
-    # number of retries. When set, `ackWithFailureAfterMaxRetries` will be ignored
+    # number of retries. On successful storage, the message will be acknowledged with success
     Store deadLetterStore?;
 |};
 ```

ballerina/msg_listener.bal

@@ -30,10 +30,11 @@ public type StoreListenerConfiguration record {|
     int maxRetries = 3;
     # The interval in seconds between retries for processing a message
     decimal retryInterval = 1;
-    # If true, the message will be acknowledged with failure after the maximum number of retries is reached
-    boolean ackWithFailureAfterMaxRetries = false;
+    # If true, the message will be acknowledged with failure after the maximum number of retries is reached.
+    # Else the message will be acknowledged with success.
+    boolean ackWithFailureAfterMaxRetries = true;
     # An optional message store to store messages that could not be processed after the maximum 
-    # number of retries. When set, `ackWithFailureAfterMaxRetries` will be ignored
+    # number of retries. On successful storage, the message will be acknowledged with success
     Store deadLetterStore?;
 |};
 
@@ -61,9 +62,6 @@ public isolated class StoreListener {
         if config.retryInterval <= 0d {
             return error Error("retryInterval must be greater than zero");
         }
-        if config.deadLetterStore !is () && config.ackWithFailureAfterMaxRetries {
-            return error Error("ackWithFailureAfterMaxRetries cannot be true when deadLetterStore is set");
-        }
         StoreListenerConfiguration {deadLetterStore, ...otherConfig} = config;
         self.config = {
             ...otherConfig.clone(),
@@ -237,10 +235,9 @@ isolated class PollAndProcessMessages {
 
         if self.config.ackWithFailureAfterMaxRetries {
             log:printDebug("max retries reached, acknowledging message with failure", msgId = id);
+        } else {
+            log:printDebug("max retries reached, acknowledging message with success", msgId = id);
         }
-        else {
-            log:printDebug("max retries reached, message is kept in the store", msgId = id);
-        }
-        self.ackMessage(id, self.config.ackWithFailureAfterMaxRetries);
+        self.ackMessage(id, !self.config.ackWithFailureAfterMaxRetries);
     }
 }

ballerina/tests/msg_store_listener_tests.bal

@@ -307,7 +307,7 @@ listener StoreListener customDeadLetterStoreListenerWithDrop = new (
     maxRetries = 1,
     retryInterval = 2,
     deadLetterStore = customDeadLetterStore,
-    ackWithFailureAfterMaxRetries = true
+    ackWithFailureAfterMaxRetries = false
 );
 
 listener StoreListener customDeadLetterStoreListenerWithoutDrop = new (
@@ -316,7 +316,7 @@ listener StoreListener customDeadLetterStoreListenerWithoutDrop = new (
     maxRetries = 1,
     retryInterval = 2,
     deadLetterStore = customDeadLetterStore,
-    ackWithFailureAfterMaxRetries = false
+    ackWithFailureAfterMaxRetries = true
 );
 
 service on customDeadLetterStoreListenerWithDrop, customDeadLetterStoreListenerWithoutDrop {

docs/spec/spec.md

@@ -86,12 +86,13 @@ type StoreListenerConfiguration record {|
     decimal pollingInterval = 1;
     int maxRetries = 3;
     decimal retryInterval = 1;
-    boolean ackWithFailureAfterMaxRetries = false;
+    boolean ackWithFailureAfterMaxRetries = true;
     Store deadLetterStore?;
 |};
 ```
 
 **Key Features:**
+
 - Configurable polling, retry, and DLQ behavior
 - Attachable service for message processing
 - Graceful and immediate stop operations