Skip to content

Commit 7613557

Browse files
authored
feat: Change Service port name from hardcoded to a value (#63)
1 parent bfec87b commit 7613557

File tree

4 files changed

+8
-4
lines changed

4 files changed

+8
-4
lines changed

charts/backstage/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ type: application
1515
# This is the chart version. This version number should be incremented each time you make changes
1616
# to the chart and its templates, including the app version.
1717
# Versions are expected to follow Semantic Versioning (https://semver.org/)
18-
version: 0.17.1
18+
version: 0.18.0
1919

2020
dependencies:
2121
- name: common

charts/backstage/README.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11

22
# Backstage Helm Chart
33

4-
![Version: 0.17.1](https://img.shields.io/badge/Version-0.17.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square)
4+
![Version: 0.18.0](https://img.shields.io/badge/Version-0.18.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square)
55

66
A Helm chart for deploying a Backstage application
77

@@ -161,7 +161,8 @@ The command removes all the Kubernetes components associated with the chart and
161161
| service.loadBalancerIP | Backstage service Load Balancer IP <br /> Ref: https://kubernetes.io/docs/user-guide/services/#type-loadbalancer | string | `""` |
162162
| service.loadBalancerSourceRanges | Load Balancer sources <br /> Ref: https://kubernetes.io/docs/tasks/access-application-cluster/cnfigure-cloud-provider-firewall/#restrict-access-for-loadbalancer-service <br /> E.g `loadBalancerSourceRanges: [10.10.10.0/24]` | list | `[]` |
163163
| service.nodePorts | Node port for the Backstage client connections Choose port between `30000-32767` | object | `{"backend":""}` |
164-
| service.ports | Backstage svc port for client connections | object | `{"backend":7007,"targetPort":"backend"}` |
164+
| service.ports | Backstage svc port for client connections | object | `{"backend":7007,"name":"http-backend","targetPort":"backend"}` |
165+
| service.ports.name | Backstage svc port name | string | `"http-backend"` |
165166
| service.ports.targetPort | Backstage svc target port referencing receiving pod container port | string | `"backend"` |
166167
| service.sessionAffinity | Control where client requests go, to the same pod or round-robin (values: `ClientIP` or `None`) <br /> Ref: https://kubernetes.io/docs/user-guide/services/ | string | `"None"` |
167168
| service.type | Kubernetes Service type | string | `"ClusterIP"` |

charts/backstage/templates/service.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ spec:
3535
sessionAffinity: {{ .Values.service.sessionAffinity }}
3636
{{- end }}
3737
ports:
38-
- name: http-backend
38+
- name: {{ .Values.service.ports.name }}
3939
port: {{ .Values.service.ports.backend }}
4040
targetPort: {{ .Values.service.ports.targetPort }}
4141
protocol: TCP

charts/backstage/values.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -195,6 +195,9 @@ service:
195195
ports:
196196
backend: 7007
197197

198+
# -- Backstage svc port name
199+
name: http-backend
200+
198201
# -- Backstage svc target port referencing receiving pod container port
199202
targetPort: backend
200203

0 commit comments

Comments
 (0)