Use multiple TypeScript projects (#16430)

Co-authored-by: Babel Bot <[email protected]>

Author: nicolo-ribaudo

.github/workflows/ci.yml

@@ -194,10 +194,10 @@ jobs:
       - name: Extract artifacts
         run: tar -xf babel-artifact.tar; rm babel-artifact.tar
       - name: Lint
-        run: make -j prepublish-prepare-dts lint-ci
+        run: make -j lint-ci check-compat-data
       - name: Ensure cwd does not contain uncommitted changes
         run: |
-          node ./scripts/assert-dir-git-clean.js "prepublish-prepare-dts lint-ci"
+          node ./scripts/assert-dir-git-clean.js "lint-ci check-compat-data"
 
   test:
     name: Test on Node.js # GitHub will add ${{ matrix.node-version }} to this title
@@ -287,7 +287,7 @@ jobs:
           BABEL_8_BREAKING: true
           STRIP_BABEL_8_FLAG: true
       - name: Lint
-        run: make -j tscheck lint-ci
+        run: make -j lint-ci check-compat-data
         env:
           BABEL_ENV: test
           BABEL_8_BREAKING: true

Gulpfile.mjs

@@ -154,10 +154,10 @@ async function generateTypeHelpers(helperKind, filename = "index.ts") {
  * @typedef {("asserts" | "validators")} TraverseHelperKind
  * @param {TraverseHelperKind} helperKind
  */
-function generateTraverseHelpers(helperKind) {
+function generateTraverseHelpers(helperKind, outBase = "") {
   return generateHelpers(
     `./packages/babel-traverse/scripts/generators/${helperKind}.js`,
-    `./packages/babel-traverse/src/path/generated/`,
+    `./packages/babel-traverse/src/${outBase}/generated/`,
     `${helperKind}.d.ts`,
     `@babel/traverse -> ${helperKind}`
   );
@@ -757,8 +757,9 @@ gulp.task("generate-type-helpers", () => {
     generateTypeHelpers("constants"),
     generateTypeHelpers("validators"),
     generateTypeHelpers("ast-types"),
-    generateTraverseHelpers("asserts"),
-    generateTraverseHelpers("validators"),
+    generateTraverseHelpers("asserts", "path"),
+    generateTraverseHelpers("validators", "path"),
+    generateTraverseHelpers("visitor-types"),
   ]);
 });
 

Makefile

@@ -55,12 +55,16 @@ build-plugin-transform-runtime-dist:
 watch:
 	$(MAKEJS) watch
 
-code-quality: tscheck lint
+code-quality: lint
 
 tscheck:
 	$(MAKEJS) tscheck
 
-lint-ci: lint check-compat-data
+clean-ts:
+	$(MAKEJS) clean-ts
+
+lint-ci:
+	$(MAKEJS) lint-ci
 
 generate-readme:
 	$(NODE) scripts/generators/readmes.js
@@ -87,7 +91,7 @@ test: lint test-only
 clone-license:
 	$(MAKEJS) clone-license
 
-prepublish-prepare-dts:
+prepublish-prepare-dts: tscheck
 	$(MAKEJS) prepublish-prepare-dts
 
 prepublish-build:

Makefile.js

@@ -21,16 +21,6 @@ const target = new Proxy(global.target, {
 });
 const SOURCES = ["packages", "codemods", "eslint"];
 
-const EslintArgs = [
-  "eslint",
-  "scripts",
-  "benchmark",
-  ...SOURCES,
-  "*.{js,cjs,mjs,ts}",
-  "--format",
-  "codeframe",
-];
-
 const YARN_PATH = shell.which("yarn").stdout;
 const NODE_PATH = process.execPath; // `yarn node` is so slow on Windows
 
@@ -295,20 +285,26 @@ target["prepublish-build-standalone"] = function () {
 };
 
 target["prepublish-prepare-dts"] = function () {
+  target["clean-ts"]();
   target["tscheck"]();
+  target["prepublish-prepare-dts-no-clean"]();
+};
 
+target["prepublish-prepare-dts-no-clean"] = function () {
   yarn(["gulp", "bundle-dts"]);
-
   target["build-typescript-legacy-typings"]();
 };
 
 target["tscheck"] = function () {
   target["generate-tsconfig"]();
+  node(["scripts/parallel-tsc/tsc.js", "."]);
+};
 
-  // ts doesn't generate declaration files after we remove the output directory by manually when incremental==true
+target["clean-ts"] = function () {
+  // ts doesn't generate declaration files after we remove the output directory manually when incremental==true
   shell.rm("-rf", "tsconfig.tsbuildinfo");
+  shell.rm("-rf", "*/*/tsconfig.tsbuildinfo");
   shell.rm("-rf", "dts");
-  yarn(["tsc", "-b", "."]);
 };
 
 target["generate-tsconfig"] = function () {
@@ -339,15 +335,49 @@ target["clone-license"] = function () {
  * DEV
  */
 
-target["lint"] = function () {
-  env(
-    () => {
-      yarn(EslintArgs);
-    },
-    {
-      BABEL_ENV: "test",
-    }
+function eslint(...extraArgs) {
+  const eslintEnv = { BABEL_ENV: "test" };
+  const eslintArgs = ["--format", "codeframe", ...extraArgs.filter(Boolean)];
+
+  const packagesPackages = readdirSync("packages").filter(n =>
+    existsSync(`packages/${n}/package.json`)
   );
+  const chunks = [];
+  // Linting everything at the same time needs too much memory and crashes
+  // Do it in batches packages
+  for (let i = 0, chunkSize = 40; i < packagesPackages.length; i += chunkSize) {
+    chunks.push([
+      `packages/{${packagesPackages.slice(i, i + chunkSize)}}/**/*`,
+    ]);
+  }
+  const rest = [
+    "eslint",
+    "codemods",
+    "scripts",
+    "benchmark",
+    "*.{js,cjs,mjs,ts}",
+  ];
+  chunks.push(rest);
+
+  if (process.env.ESLINT_GO_BRRRR) {
+    // Run as a single process. Needs a lot of memory (12GB).
+    env(() => yarn(["eslint", "packages", ...rest, ...eslintArgs]), eslintEnv);
+  } else {
+    for (const chunk of chunks) {
+      env(() => yarn(["eslint", ...chunk, ...eslintArgs]), eslintEnv);
+    }
+  }
+}
+
+target["lint"] = function () {
+  env(() => target["tscheck"](), { TSCHECK_SILENT: "true" });
+  eslint();
+};
+
+target["lint-ci"] = function () {
+  target["tscheck"]();
+  eslint();
+  target["prepublish-prepare-dts-no-clean"]();
 };
 
 target["fix"] = function () {
@@ -356,7 +386,8 @@ target["fix"] = function () {
 };
 
 target["fix-js"] = function () {
-  yarn([...EslintArgs, "--fix"]);
+  env(() => target["tscheck"](), { TSCHECK_SILENT: "true" });
+  eslint("--fix");
 };
 
 target["fix-json"] = function () {

Makefile.source.mjs

@@ -0,0 +1,17 @@
+/* This file is automatically generated by scripts/generators/tsconfig.js */
+{
+  "extends": [
+    "../../tsconfig.base.json",
+    "../../tsconfig.paths.json"
+  ],
+  "include": [
+    "../../codemods/babel-plugin-codemod-object-assign-to-object-spread/src/**/*.ts",
+    "../../lib/globals.d.ts",
+    "../../scripts/repo-utils/*.d.ts"
+  ],
+  "references": [
+    {
+      "path": "../../packages/babel-helper-plugin-utils"
+    }
+  ]
+}

codemods/babel-plugin-codemod-object-assign-to-object-spread/tsconfig.json

@@ -0,0 +1,17 @@
+/* This file is automatically generated by scripts/generators/tsconfig.js */
+{
+  "extends": [
+    "../../tsconfig.base.json",
+    "../../tsconfig.paths.json"
+  ],
+  "include": [
+    "../../codemods/babel-plugin-codemod-optional-catch-binding/src/**/*.ts",
+    "../../lib/globals.d.ts",
+    "../../scripts/repo-utils/*.d.ts"
+  ],
+  "references": [
+    {
+      "path": "../../packages/babel-helper-plugin-utils"
+    }
+  ]
+}

codemods/babel-plugin-codemod-optional-catch-binding/tsconfig.json

@@ -0,0 +1,17 @@
+/* This file is automatically generated by scripts/generators/tsconfig.js */
+{
+  "extends": [
+    "../../tsconfig.base.json",
+    "../../tsconfig.paths.json"
+  ],
+  "include": [
+    "../../eslint/babel-eslint-parser/src/**/*.cts",
+    "../../lib/globals.d.ts",
+    "../../scripts/repo-utils/*.d.ts"
+  ],
+  "references": [
+    {
+      "path": "../../packages/babel-helper-plugin-utils"
+    }
+  ]
+}

eslint/babel-eslint-parser/tsconfig.json

@@ -69,6 +69,7 @@
     "jest": "^30.0.0-alpha.2",
     "jest-light-runner": "^0.6.0",
     "jest-worker": "^30.0.0-alpha.2",
+    "json5": "^2.2.3",
     "lint-staged": "^15.2.0",
     "mergeiterator": "^1.4.4",
     "picocolors": "^1.0.0",

package.json

@@ -0,0 +1,17 @@
+/* This file is automatically generated by scripts/generators/tsconfig.js */
+{
+  "extends": [
+    "../../tsconfig.base.json",
+    "../../tsconfig.paths.json"
+  ],
+  "include": [
+    "../../packages/babel-cli/src/**/*.ts",
+    "../../lib/globals.d.ts",
+    "../../scripts/repo-utils/*.d.ts"
+  ],
+  "references": [
+    {
+      "path": "../../packages/babel-helper-plugin-utils"
+    }
+  ]
+}