Mark class prototype as read-only (#12115)

* initial code 2 fix the issue #2025

* Mark class prototype as read-only

* Update fixtures

* Fix failure

* Update Babel 8 fixtures

* Disable in loose mode

* Update fixtures

Co-authored-by: Nicolò Ribaudo <[email protected]>

Author: wentout

packages/babel-cli/test/fixtures/babel-external-helpers/--whitelist/stdout.txt

@@ -14,6 +14,9 @@
   function _createClass(Constructor, protoProps, staticProps) {
     if (protoProps) _defineProperties(Constructor.prototype, protoProps);
     if (staticProps) _defineProperties(Constructor, staticProps);
+    Object.defineProperty(Constructor, "prototype", {
+      writable: false
+    });
     return Constructor;
   }
 

packages/babel-core/test/fixtures/transformation/misc/regression-1155/output.js

@@ -16,5 +16,5 @@ var Foo = /*#__PURE__*/function (_Bar) {
     return _super.call(this, parentOptions);
   }
 
-  return Foo;
+  return babelHelpers.createClass(Foo);
 }(Bar);

packages/babel-helpers/src/helpers.ts

@@ -223,6 +223,7 @@ helpers.createClass = helper("7.0.0-beta.0")`
   export default function _createClass(Constructor, protoProps, staticProps) {
     if (protoProps) _defineProperties(Constructor.prototype, protoProps);
     if (staticProps) _defineProperties(Constructor, staticProps);
+    Object.defineProperty(Constructor, "prototype", { writable: false });
     return Constructor;
   }
 `;
@@ -334,12 +335,15 @@ helpers.inherits = helper("7.0.0-beta.0")`
     if (typeof superClass !== "function" && superClass !== null) {
       throw new TypeError("Super expression must either be null or a function");
     }
-    subClass.prototype = Object.create(superClass && superClass.prototype, {
-      constructor: {
-        value: subClass,
-        writable: true,
-        configurable: true
-      }
+    Object.defineProperty(subClass, "prototype", {
+      value: Object.create(superClass && superClass.prototype, {
+        constructor: {
+          value: subClass,
+          writable: true,
+          configurable: true
+        }
+      }),
+      writable: false,
     });
     if (superClass) setPrototypeOf(subClass, superClass);
   }

packages/babel-plugin-proposal-class-properties/test/fixtures/assumption-setPublicClassFields/foobar/output.js

@@ -18,5 +18,5 @@ var Child = /*#__PURE__*/function (_Parent) {
     return _this;
   }
 
-  return Child;
+  return babelHelpers.createClass(Child);
 }(Parent);

packages/babel-plugin-proposal-class-properties/test/fixtures/decorators-legacy-interop/local-define-property/output.js

@@ -5,14 +5,14 @@ function dec() {} // Create a local function binding so babel has to change the
 
 function _defineProperty() {}
 
-let A = (_class = function A() {
+let A = (_class = /*#__PURE__*/babelHelpers.createClass(function A() {
   "use strict";
 
   babelHelpers.classCallCheck(this, A);
   babelHelpers.initializerDefineProperty(this, "a", _descriptor, this);
   babelHelpers.initializerDefineProperty(this, "b", _descriptor2, this);
   babelHelpers.defineProperty(this, "c", 456);
-}, (_descriptor = babelHelpers.applyDecoratedDescriptor(_class.prototype, "a", [dec], {
+}), (_descriptor = babelHelpers.applyDecoratedDescriptor(_class.prototype, "a", [dec], {
   configurable: true,
   enumerable: true,
   writable: true,

packages/babel-plugin-proposal-class-properties/test/fixtures/decorators-legacy-interop/loose/output.js

@@ -2,14 +2,14 @@ var _class, _descriptor, _descriptor2;
 
 function dec() {}
 
-let A = (_class = function A() {
+let A = (_class = /*#__PURE__*/babelHelpers.createClass(function A() {
   "use strict";
 
   babelHelpers.classCallCheck(this, A);
   babelHelpers.initializerDefineProperty(this, "a", _descriptor, this);
   babelHelpers.initializerDefineProperty(this, "b", _descriptor2, this);
   this.c = 456;
-}, (_descriptor = babelHelpers.applyDecoratedDescriptor(_class.prototype, "a", [dec], {
+}), (_descriptor = babelHelpers.applyDecoratedDescriptor(_class.prototype, "a", [dec], {
   configurable: true,
   enumerable: true,
   writable: true,

packages/babel-plugin-proposal-class-properties/test/fixtures/decorators-legacy-interop/strict/output.js

@@ -2,14 +2,14 @@ var _class, _descriptor, _descriptor2;
 
 function dec() {}
 
-let A = (_class = function A() {
+let A = (_class = /*#__PURE__*/babelHelpers.createClass(function A() {
   "use strict";
 
   babelHelpers.classCallCheck(this, A);
   babelHelpers.initializerDefineProperty(this, "a", _descriptor, this);
   babelHelpers.initializerDefineProperty(this, "b", _descriptor2, this);
   babelHelpers.defineProperty(this, "c", 456);
-}, (_descriptor = babelHelpers.applyDecoratedDescriptor(_class.prototype, "a", [dec], {
+}), (_descriptor = babelHelpers.applyDecoratedDescriptor(_class.prototype, "a", [dec], {
   configurable: true,
   enumerable: true,
   writable: true,

packages/babel-plugin-proposal-class-properties/test/fixtures/nested-class/super-call-in-key/output.js

@@ -1,14 +1,14 @@
 "use strict";
 
-let Hello = function Hello() {
+let Hello = /*#__PURE__*/babelHelpers.createClass(function Hello() {
   babelHelpers.classCallCheck(this, Hello);
   return {
     toString() {
       return 'hello';
     }
 
   };
-};
+});
 
 let Outer = /*#__PURE__*/function (_Hello) {
   babelHelpers.inherits(Outer, _Hello);
@@ -22,16 +22,14 @@ let Outer = /*#__PURE__*/function (_Hello) {
 
     babelHelpers.classCallCheck(this, Outer);
     _this2 = _this = _super.call(this);
-
-    let Inner = function Inner() {
+    let Inner = /*#__PURE__*/babelHelpers.createClass(function Inner() {
       babelHelpers.classCallCheck(this, Inner);
       babelHelpers.defineProperty(this, _this2, "hello");
-    };
-
+    });
     return babelHelpers.possibleConstructorReturn(_this, new Inner());
   }
 
-  return Outer;
+  return babelHelpers.createClass(Outer);
 }(Hello);
 
 expect(new Outer().hello).toBe('hello');

packages/babel-plugin-proposal-class-properties/test/fixtures/nested-class/super-property-in-key/output.js

@@ -27,16 +27,14 @@ let Outer = /*#__PURE__*/function (_Hello) {
     babelHelpers.classCallCheck(this, Outer);
     _this = _super.call(this);
     _babelHelpers$get$cal = babelHelpers.get((_thisSuper = babelHelpers.assertThisInitialized(_this), babelHelpers.getPrototypeOf(Outer.prototype)), "toString", _thisSuper).call(_thisSuper);
-
-    let Inner = function Inner() {
+    let Inner = /*#__PURE__*/babelHelpers.createClass(function Inner() {
       babelHelpers.classCallCheck(this, Inner);
       babelHelpers.defineProperty(this, _babelHelpers$get$cal, 'hello');
-    };
-
+    });
     return babelHelpers.possibleConstructorReturn(_this, new Inner());
   }
 
-  return Outer;
+  return babelHelpers.createClass(Outer);
 }(Hello);
 
 expect(new Outer().hello).toBe('hello');

packages/babel-plugin-proposal-class-properties/test/fixtures/private-loose/constructor-collision/output.js

@@ -2,7 +2,7 @@ var foo = "bar";
 
 var _bar = /*#__PURE__*/babelHelpers.classPrivateFieldLooseKey("bar");
 
-var Foo = function Foo() {
+var Foo = /*#__PURE__*/babelHelpers.createClass(function Foo() {
   "use strict";
 
   babelHelpers.classCallCheck(this, Foo);
@@ -11,4 +11,4 @@ var Foo = function Foo() {
     value: foo
   });
   var _foo = "foo";
-};
+});