Skip to content

Commit 3b3c17d

Browse files
committed
fix(tests): resolve e2e test import errors after adding __init__ files
- Fix relative imports in e2e test files to use proper package paths - Add type ignore comment for spy function in dcp optimized tests Resolves import errors introduced when adding __init__.py files to make test directories Python packages (for READER_TYPE_STRING_TO_CLASS) changes).
1 parent b2256d5 commit 3b3c17d

7 files changed

+9
-9
lines changed

s3torchconnector/tst/e2e/dcp/test_e2e_s3_file_system.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
from typing import Optional
3030

3131
from s3torchconnector.dcp.s3_prefix_strategy import RoundRobinPrefixStrategy
32-
from test_common import _list_folders_in_bucket
32+
from ..test_common import _list_folders_in_bucket
3333

3434

3535
def generate_random_port():

s3torchconnector/tst/e2e/test_distributed_training.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
from .conftest import BucketPrefixFixture, BucketPrefixData
2121

2222

23-
from test_common import _get_fork_methods, _read_data, _set_start_method
23+
from .test_common import _get_fork_methods, _read_data, _set_start_method
2424

2525

2626
start_methods = _get_fork_methods()

s3torchconnector/tst/e2e/test_e2e_s3_lightning_checkpoint.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@
1919
from s3torchconnector.lightning import S3LightningCheckpoint
2020
from s3torchconnectorclient import S3Exception, __version__
2121

22-
from models.net import Net
23-
from models.lightning_transformer import LightningTransformer, L
22+
from .models.net import Net
23+
from .models.lightning_transformer import LightningTransformer, L
2424

2525

2626
LIGHTNING_ACCELERATOR = "cpu"

s3torchconnector/tst/e2e/test_e2e_s3checkpoint.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
import pytest
66

77
from s3torchconnector import S3Checkpoint
8-
from models.net import Net
8+
from .models.net import Net
99

1010

1111
@pytest.mark.parametrize(

s3torchconnector/tst/e2e/test_mountpoint_client_parallel_access.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
from s3torchconnector._s3client import S3Client
66
from s3torchconnectorclient._mountpoint_s3_client import MountpointS3Client
77

8-
from test_common import _get_fork_methods
9-
from conftest import getenv
8+
from .test_common import _get_fork_methods
9+
from .conftest import getenv
1010

1111

1212
NATIVE_S3_CLIENT = None

s3torchconnector/tst/e2e/test_multiprocess_dataloading.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
if TYPE_CHECKING:
2323
from .conftest import BucketPrefixFixture
2424

25-
from test_common import _get_fork_methods, _read_data, _set_start_method
25+
from .test_common import _get_fork_methods, _read_data, _set_start_method
2626

2727

2828
start_methods = _get_fork_methods()

s3torchconnector/tst/unit/test_s3reader_dcp_optimized.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -524,7 +524,7 @@ def spy_get_stream(start=None, end=None):
524524
TEST_KEY,
525525
ranges,
526526
create_object_info_getter(test_data),
527-
spy_get_stream,
527+
spy_get_stream, # type: ignore
528528
max_gap_size=10,
529529
)
530530

0 commit comments

Comments
 (0)