chore: Clippy stuff (#2879)

Co-authored-by: boquan-fang <[email protected]>
Co-authored-by: Boquan Fang <[email protected]>

Author: maddeleine

quic/s2n-quic-core/src/event/generated.rs

@@ -6921,20 +6921,16 @@ pub mod supervisor {
         event::{builder::SocketAddress, IntoEvent},
     };
     #[non_exhaustive]
-    #[derive(Clone, Debug, Eq, PartialEq)]
+    #[derive(Clone, Debug, Default, Eq, PartialEq)]
     pub enum Outcome {
         #[doc = r" Allow the connection to remain open"]
+        #[default]
         Continue,
         #[doc = r" Close the connection and notify the peer"]
         Close { error_code: application::Error },
         #[doc = r" Close the connection without notifying the peer"]
         ImmediateClose { reason: &'static str },
     }
-    impl Default for Outcome {
-        fn default() -> Self {
-            Self::Continue
-        }
-    }
     #[non_exhaustive]
     #[derive(Debug)]
     pub struct Context<'a> {

quic/s2n-quic-core/src/frame/ack_elicitation.rs

@@ -11,19 +11,14 @@ use core::ops::{BitOr, BitOrAssign};
 //#    delay and are called ack-eliciting packets.
 
 /// Describes if a frame or packet requires an ACK from the peer
-#[derive(Clone, Copy, Debug, PartialEq, Eq, Hash)]
+#[derive(Clone, Copy, Debug, Default, PartialEq, Eq, Hash)]
 #[cfg_attr(any(test, feature = "generator"), derive(TypeGenerator))]
 pub enum AckElicitation {
+    #[default]
     NonEliciting,
     Eliciting,
 }
 
-impl Default for AckElicitation {
-    fn default() -> Self {
-        Self::NonEliciting
-    }
-}
-
 impl AckElicitation {
     /// Returns true if the `AckElicitation` is set to `Eliciting`
     pub fn is_ack_eliciting(self) -> bool {

quic/s2n-quic-core/src/packet/short.rs

@@ -57,18 +57,13 @@ const SPIN_BIT_MASK: u8 = 0x20;
 
 const RESERVED_BITS_MASK: u8 = 0x18;
 
-#[derive(Clone, Copy, Debug, PartialEq)]
+#[derive(Clone, Copy, Debug, PartialEq, Default)]
 pub enum SpinBit {
+    #[default]
     Zero,
     One,
 }
 
-impl Default for SpinBit {
-    fn default() -> Self {
-        Self::Zero
-    }
-}
-
 impl SpinBit {
     fn from_tag(tag: Tag) -> Self {
         if tag & SPIN_BIT_MASK == SPIN_BIT_MASK {

quic/s2n-quic-rustls/src/session.rs

@@ -391,8 +391,9 @@ impl tls::Session for Session {
     }
 }
 
-#[derive(Clone, Copy, Debug, PartialEq, PartialOrd)]
+#[derive(Clone, Copy, Debug, PartialEq, PartialOrd, Default)]
 enum HandshakePhase {
+    #[default]
     Initial,
     Handshake,
     Application,
@@ -406,9 +407,3 @@ impl HandshakePhase {
         };
     }
 }
-
-impl Default for HandshakePhase {
-    fn default() -> Self {
-        Self::Initial
-    }
-}

quic/s2n-quic-tls/src/callback.rs

@@ -398,8 +398,9 @@ impl State {
     }
 }
 
-#[derive(Clone, Copy, Debug, PartialEq, PartialOrd)]
+#[derive(Clone, Copy, Debug, PartialEq, PartialOrd, Default)]
 enum HandshakePhase {
+    #[default]
     Initial,
     Handshake,
     Application,
@@ -414,27 +415,16 @@ impl HandshakePhase {
     }
 }
 
-impl Default for HandshakePhase {
-    fn default() -> Self {
-        Self::Initial
-    }
-}
-
-#[derive(Debug)]
+#[derive(Debug, Default)]
 enum Secrets {
+    #[default]
     Waiting,
     Half {
         secret: Prk,
         id: s2n_secret_type_t::Type,
     },
 }
 
-impl Default for Secrets {
-    fn default() -> Self {
-        Self::Waiting
-    }
-}
-
 fn get_algo_type(
     connection: *mut s2n_connection,
 ) -> Option<(hkdf::Algorithm, &'static aead::Algorithm, CipherSuite)> {

quic/s2n-quic-transport/src/connection/close_sender.rs

@@ -190,8 +190,9 @@ impl<Config: endpoint::Config, Pub: event::ConnectionPublisher> tx::Message
     }
 }
 
-#[derive(Debug)]
+#[derive(Debug, Default)]
 enum State {
+    #[default]
     Idle,
     Closing {
         packet: Bytes,
@@ -202,12 +203,6 @@ enum State {
     Closed,
 }
 
-impl Default for State {
-    fn default() -> Self {
-        Self::Idle
-    }
-}
-
 impl State {
     pub fn on_timeout(&mut self, now: Timestamp) -> Poll<()> {
         match self {

quic/s2n-quic-transport/src/sync/flag.rs

@@ -26,9 +26,10 @@ pub trait Writer: Default {
     fn write_frame<W: WriteContext>(&mut self, context: &mut W) -> Option<PacketNumber>;
 }
 
-#[derive(Debug, PartialEq)]
+#[derive(Debug, PartialEq, Default)]
 enum DeliveryState {
     /// The flag has not been requested
+    #[default]
     Idle,
 
     /// The flag needs to be transmitted
@@ -60,12 +61,6 @@ enum DeliveryState {
     Delivered,
 }
 
-impl Default for DeliveryState {
-    fn default() -> Self {
-        Self::Idle
-    }
-}
-
 impl<W: Writer> Flag<W> {
     /// Constructs a flag with the given `writer`
     pub fn new(writer: W) -> Self {

tools/s2n-events/src/generate_config.rs

@@ -173,9 +173,10 @@ impl GenerateConfig {
                     };
 
                     #[non_exhaustive]
-                    #[derive(Clone, Debug, Eq, PartialEq)]
+                    #[derive(Clone, Debug, Default, Eq, PartialEq)]
                     pub enum Outcome {
                         /// Allow the connection to remain open
+                        #[default]
                         Continue,
 
                         /// Close the connection and notify the peer
@@ -185,12 +186,6 @@ impl GenerateConfig {
                         ImmediateClose { reason: &'static str },
                     }
 
-                    impl Default for Outcome {
-                        fn default() -> Self {
-                            Self::Continue
-                        }
-                    }
-
                     #[non_exhaustive]
                     #[derive(Debug)]
                     pub struct Context<'a> {