ci: Pin to older docker version (#2639)

Author: maddeleine

.github/workflows/qns.yml

@@ -127,6 +127,10 @@ jobs:
           name: s2n-quic-qns-release
           path: s2n-quic-qns/
 
+      - uses: docker/setup-docker-action@v4
+        with: 
+          version: version=v26.1.3
+
       - name: Setup dockerfile
         working-directory: s2n-quic-qns
         run: |

dc/s2n-quic-dc/src/path/secret/receiver/tests.rs

@@ -206,22 +206,13 @@ fn check_delayed_inner(seed: u64, delay: u16) {
     }
 }
 
+#[derive(Default)]
 struct Model {
     insert_order: Vec<u64>,
     oracle: HashSet<u64>,
     subject: State,
 }
 
-impl Default for Model {
-    fn default() -> Self {
-        Self {
-            oracle: Default::default(),
-            insert_order: Vec::new(),
-            subject: State::new(),
-        }
-    }
-}
-
 impl Model {
     fn insert(&mut self, op: u64) {
         let pid = Id::from([0; 16]);

dc/s2n-quic-dc/src/stream/client/rpc.rs

@@ -44,7 +44,7 @@ where
             let storage = response.provide_storage().await?;
 
             if !storage.has_remaining_capacity() {
-                return Err(io::Error::new(io::ErrorKind::Other, "the provided response buffer failed to provide enough capacity for the peer's response"));
+                return Err(io::Error::other( "the provided response buffer failed to provide enough capacity for the peer's response"));
             }
 
             let len = reader.read_into(storage).await?;

dc/s2n-quic-dc/src/stream/environment/udp.rs

@@ -119,10 +119,7 @@ where
                 remote_addr = v4.to_ipv6_mapped().with_port(remote_addr.port()).into();
             }
             (IpAddress::Ipv6(_), IpAddress::Ipv4(_)) => {
-                return Err(std::io::Error::new(
-                    std::io::ErrorKind::Other,
-                    "IPv6 not supported on a IPv4 socket",
-                ))
+                return Err(std::io::Error::other("IPv6 not supported on a IPv4 socket"))
             }
             (IpAddress::Ipv6(_), IpAddress::Ipv6(_)) => {}
         }

dc/s2n-quic-dc/src/stream/pacer.rs

@@ -25,10 +25,9 @@ impl Naive {
 
         // record the time that we yielded
         let now = clock.get_time();
-        let prev_yield_window = core::mem::replace(
-            &mut self.yield_window,
-            Some(now + core::time::Duration::from_millis(1)),
-        );
+        let prev_yield_window = self
+            .yield_window
+            .replace(now + core::time::Duration::from_millis(1));
 
         // if the current time falls outside of the previous window then don't actually yield - the
         // application isn't sending at that rate

dc/s2n-quic-dc/src/stream/recv/shared.rs

@@ -143,9 +143,10 @@ impl State {
         // increment the epoch at which we acquired the guard
         self.application_epoch.fetch_add(1, Ordering::AcqRel);
 
-        let inner = self.inner.lock().map_err(|_| {
-            io::Error::new(io::ErrorKind::Other, "shared recv state has been poisoned")
-        })?;
+        let inner = self
+            .inner
+            .lock()
+            .map_err(|_| io::Error::other("shared recv state has been poisoned"))?;
 
         let initial_state = inner.receiver.state().clone();
 
@@ -197,10 +198,7 @@ impl State {
         match self.inner.try_lock() {
             Ok(lock) => Ok(Some(lock)),
             Err(std::sync::TryLockError::WouldBlock) => Ok(None),
-            Err(_) => Err(io::Error::new(
-                io::ErrorKind::Other,
-                "shared recv state has been poisoned",
-            )),
+            Err(_) => Err(io::Error::other("shared recv state has been poisoned")),
         }
     }
 }

dc/s2n-quic-dc/src/stream/server/tokio/tcp/manager.rs

@@ -191,7 +191,7 @@ where
             .push_back(&mut self.inner.workers, idx);
 
         // kick off the initial poll to register wakers with the socket
-        self.inner.poll_worker(idx, cx, publisher, clock);
+        let _ = self.inner.poll_worker(idx, cx, publisher, clock);
 
         true
     }

dc/s2n-quic-dc/src/stream/server/tokio/tcp/manager/tests.rs

@@ -150,7 +150,7 @@ impl Default for Harness {
 
 impl Harness {
     pub fn poll(&mut self) {
-        self.manager.poll(
+        let _ = self.manager.poll(
             &mut (),
             &publisher(&self.subscriber, &self.clock),
             &self.clock,

dc/s2n-quic-dc/src/stream/server/tokio/tcp/worker.rs

@@ -116,8 +116,8 @@ where
 
         let prev_queue_time = core::mem::replace(&mut self.queue_time, now);
         let prev_state = core::mem::replace(&mut self.state, WorkerState::Init);
-        let prev_stream = core::mem::replace(&mut self.stream, Some((stream, remote_address)));
-        let prev_ctx = core::mem::replace(&mut self.subscriber_ctx, Some(subscriber_ctx));
+        let prev_stream = self.stream.replace((stream, remote_address));
+        let prev_ctx = self.subscriber_ctx.replace(subscriber_ctx);
 
         if let Some(remote_address) = prev_stream.map(|(socket, remote_address)| {
             // If linger wasn't already set or it was set to a value other than 0, then override it

quic/s2n-quic-core/src/packet/number/sliding_window.rs

@@ -186,9 +186,7 @@ impl SlidingWindow {
                     // Our mask is the full window since it's all getting evicted.
                     !removed
                 };
-                if let Some(prev_right_edge) =
-                    core::mem::replace(&mut self.right_edge, Some(packet_number))
-                {
+                if let Some(prev_right_edge) = self.right_edge.replace(packet_number) {
                     Ok(EvictedSet {
                         window: removed,
                         right_edge: prev_right_edge,